fix: only use og:image if http or https url

Author: SethFalco

src/index.js

@@ -207,6 +207,9 @@ export async function render(resume) {
     return `<time datetime="${datetime}">${localeString}</time>`;
   });
 
+  /** @type {Record<string, unknown>} */
+  resume.custom = {};
+
   if (Array.isArray(resume.basics?.profiles)) {
     const { profiles } = resume.basics;
     const xTwitter = profiles.find((profile) => {
@@ -218,7 +221,7 @@ export async function render(resume) {
       let { username, url } = xTwitter;
 
       if (!username && url) {
-        const match = url.match(/https?:\/\/.+?\/(\w{1,15})/);
+        const match = url.match(/^https?:\/\/.+?\/(\w{1,15})/);
 
         if (match.length == 2) {
           username = match[1];
@@ -229,9 +232,15 @@ export async function render(resume) {
         username = `@${username}`;
       }
 
-      resume.custom = {
-        xTwitterHandle: username
-      }
+      resume.custom.xTwitterHandle = username;
+    }
+  }
+
+  if (resume.basics?.image) {
+    const { image } = resume.basics;
+
+    if (image.match(/^https?:\/\//)) {
+      resume.custom.ogImage = image;
     }
   }
 

src/resume.handlebars

@@ -23,10 +23,13 @@
   {{/if}}
 
   {{#if resume.basics.image}}
-  <meta property="og:image" content="{{resume.basics.image}}">
-  <link rel="icon" href="{{resume.basics.image}}">
+  <link href="{{resume.basics.image}}" rel="icon">
+  {{/if}}
+  {{#if resume.custom.ogImage}}
+  <meta property="og:image" content="{{resume.custom.ogImage}}">
   {{#if resume.basics.name}}
-  <meta property="og:image:alt" content="{{i18n "avatar-description" "name" resume.basics.name}}">
+  <meta property="og:image:alt" content="{{i18n " avatar-description" "name"
+    resume.basics.name}}">
   {{/if}}
   {{/if}}
 

test/favicon.png

@@ -5,6 +5,7 @@
   },
   "basics": {
     "name": "Seth Falco",
+    "image": "./test/favicon.png",
     "label": "Open Sourcerer 🧙‍♂️",
     "email": "[email protected]",
     "phone": "+00 0694201337",