move component checks to components-pr workflow

Author: js07

.github/workflows/components-pr.yaml

@@ -42,6 +42,53 @@ jobs:
           base_commit: ${{ github.event.pull_request.base.sha }}
           head_commit: ${{ github.event.pull_request.head.sha }}
 
+  check_components:
+    name: Check component keys and app props
+    runs-on: ubuntu-latest
+
+    steps:
+      - name: Checkout Code
+        uses: actions/[email protected]
+        with:
+          # Full git history is needed to get a proper list of changed files
+          # within `super-linter`
+          fetch-depth: 0
+      - uses: pnpm/[email protected]
+        with:
+          version: 7.33.6
+      - name: Get pnpm store directory
+        id: pnpm-cache
+        run: |
+          echo "::set-output name=pnpm_cache_dir::$(pnpm store path)"
+      - uses: actions/cache@v4
+        name: Setup pnpm cache
+        with:
+          path: ${{ steps.pnpm-cache.outputs.pnpm_cache_dir }}
+          key: ${{ runner.os }}-pnpm-store-${{ hashFiles('**/pnpm-lock.yaml') }}
+          restore-keys: |
+            ${{ runner.os }}-pnpm-store-
+      - name: Install dependencies
+        run: pnpm install -r
+      - name: Setup Node Env
+        uses: actions/[email protected]
+        with:
+          node-version: 18
+          registry-url: https://registry.npmjs.org/
+          cache: 'pnpm'
+      - name: Compile TypeScript
+        run: npm run build
+      - name: Get Changed Files
+        id: changed_files
+        uses: jitterbit/get-changed-files@v1
+        with:
+          format: 'csv'
+      - name: Check component keys
+        run: node scripts/findBadKeys.js ${{ steps.changed_files.outputs.added_modified }} ${{ steps.changed_files.outputs.renamed }}
+      - name: Check component app prop
+        run: node scripts/checkComponentAppProp.js ${{ steps.changed_files.outputs.added_modified }} ${{ steps.changed_files.outputs.renamed }}
+      - name: Check for duplicate component keys
+        run: node scripts/findDuplicateKeys.js
+
   verify-typescript-components:
     name: Verify TypeScript components
     runs-on: ubuntu-latest

.github/workflows/pull-request-checks.yaml

@@ -75,8 +75,6 @@ jobs:
           node-version: 18
           registry-url: https://registry.npmjs.org/
           cache: 'pnpm'
-      - name: Compile TypeScript
-        run: npm run build
       - name: Lint Code Base
         uses: github/super-linter@v5
         env:
@@ -87,15 +85,3 @@ jobs:
           VALIDATE_ALL_CODEBASE: false
           VALIDATE_JAVASCRIPT_ES: true
           VALIDATE_JSON: true
-      - name: Get Changed Files
-        id: changed_files
-        uses: jitterbit/get-changed-files@v1
-        with:
-          format: 'csv'
-      # TODO: Move these checks to the Components workflow
-      - name: Check component keys
-        run: node scripts/findBadKeys.js ${{ steps.changed_files.outputs.added_modified }} ${{ steps.changed_files.outputs.renamed }}
-      - name: Check component app prop
-        run: node scripts/checkComponentAppProp.js ${{ steps.changed_files.outputs.added_modified }} ${{ steps.changed_files.outputs.renamed }}
-      - name: Check for duplicate component keys
-        run: node scripts/findDuplicateKeys.js