Skip to content

Compatibility request: Kerbalism science #727

@trijemusk

Description

@trijemusk

Bug:
I tried to use some science contract packs (Field Research and RAD) in combination with Kerbalism, and found out that they do not work together: the contracts never show up, and every contract type fails the requirement: "must have a valid experiment to perform".
I believe that this problem is caused by the fact that Kerbalism replaces all science experiments with their own version, which causes Contract Configurator to not find any experiment that can be performed.

Solution idea:
Looking into the source code it seems like all science related expressions boil down to the Science.getSubjects() method which is referenced multiple times in ExpressionParser/Parsers/Classes/Science. I propose to add a check whether Kerbalism (and its FeatureScience) is installed, and if so to instead use the method GetSubjectData() (located in the namespace KERBALISM, class ScienceDB, with this source code file) which seems to do the exact same things but instead with Kerbalism's science.

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions