`josh-filter --file` requires an extra placeholder argument for the filter

[kitlith]

Just some confusing user experience, it's confusing to need to do

josh-filter --file workflow/dotnet-filter not-a-filter refs/remotes/dotnet/main --update refs/heads/dotnet-subset-tmp

instead of

josh-filter --file workflow/dotnet-filter refs/remotes/dotnet/main --update refs/heads/dotnet-subset-tmp

This seems to stem from the filter being defined as a positional argument that is effectively ignored when a file is present.

[christian-schilling]

Interesting...
I thought I intended this to be treated as "apply the filter from the file and then the one from the command line" but apparently never implemented it that way 🤔
Just in case: Put ":/" in the spot for now.

[kitlith]

hm. I get why you would do that, but I don't think there's any real indication that josh-filter would work that way right now.

if it was oriented as josh-filter input-ref [filter-spec...] (aka it can take any number of filters, and it implicitly concatenates them) then that might make more sense.

either way, if you take this approach, it may make the most sense to the user if you take into account the relative order of the command line filter(s) and the file filter(s). i.e. josh-filter --file filter-file filter-spec would apply the file, then the cli filter, while josh-filter filter-spec --file filter-file would apply the cli filter, then the file. I'm not sure how that would be expressed in clap, but it's probably possible.