feat: strictTypes configurable form Mapper attribute and true by default

Author: MrMeshok

src/Attribute/Mapper.php

@@ -23,6 +23,7 @@ public function __construct(
         public ?bool $checkAttributes = null,
         public ?ConstructorStrategy $constructorStrategy = null,
         public ?bool $allowReadOnlyTargetToPopulate = null,
+        public ?bool $strictTypes = null,
         public int $priority = 0,
         public ?string $dateTimeFormat = null,
     ) {

src/Configuration.php

@@ -39,7 +39,7 @@ public function __construct(
         /**
          * Add declare(strict_types=1) to generated code.
          */
-        public bool $strictTypes = false,
+        public bool $strictTypes = true,
     ) {
     }
 }

src/Event/GenerateMapperEvent.php

@@ -22,6 +22,7 @@ public function __construct(
         public ?bool $checkAttributes = null,
         public ?ConstructorStrategy $constructorStrategy = null,
         public ?bool $allowReadOnlyTargetToPopulate = null,
+        public ?bool $strictTypes = null,
     ) {
     }
 }

src/EventListener/MapperListener.php

@@ -72,6 +72,7 @@ public function __invoke(GenerateMapperEvent $event): void
         $event->checkAttributes ??= $mapper->checkAttributes;
         $event->constructorStrategy ??= $mapper->constructorStrategy;
         $event->allowReadOnlyTargetToPopulate ??= $mapper->allowReadOnlyTargetToPopulate;
+        $event->strictTypes ??= $mapper->strictTypes;
         $event->mapperMetadata->dateTimeFormat = $mapper->dateTimeFormat;
     }
 }

src/Generator/MapperGenerator.php

@@ -35,7 +35,6 @@
     private MapperConstructorGenerator $mapperConstructorGenerator;
     private InjectMapperMethodStatementsGenerator $injectMapperMethodStatementsGenerator;
     private MapMethodStatementsGenerator $mapMethodStatementsGenerator;
-    private bool $declareStrictTypes;
     private bool $disableGeneratedMapper;
 
     public function __construct(
@@ -56,7 +55,6 @@ public function __construct(
 
         $this->injectMapperMethodStatementsGenerator = new InjectMapperMethodStatementsGenerator();
 
-        $this->declareStrictTypes = $configuration->strictTypes;
         $this->disableGeneratedMapper = !$configuration->autoRegister;
     }
 
@@ -75,7 +73,7 @@ public function generate(GeneratorMetadata $metadata): array
         }
 
         $statements = [];
-        if ($this->declareStrictTypes) {
+        if ($metadata->strictTypes) {
             // @phpstan-ignore argument.type
             $statements[] = new Stmt\Declare_([create_declare_item('strict_types', create_scalar_int(1))]);
         }

src/Metadata/GeneratorMetadata.php

@@ -24,7 +24,8 @@ public function __construct(
         public readonly array $propertiesMetadata,
         public readonly bool $checkAttributes = true,
         public readonly ConstructorStrategy $constructorStrategy = ConstructorStrategy::AUTO,
-        public bool $allowReadOnlyTargetToPopulate = false,
+        public readonly bool $allowReadOnlyTargetToPopulate = false,
+        public readonly bool $strictTypes = true,
         public readonly ?string $provider = null,
     ) {
         $this->variableRegistry = new VariableRegistry();

src/Metadata/MetadataFactory.php

@@ -312,6 +312,7 @@ private function createGeneratorMetadata(MapperMetadata $mapperMetadata): Genera
             $mapperEvent->checkAttributes ?? $this->configuration->attributeChecking,
             $mapperEvent->constructorStrategy ?? $this->configuration->constructorStrategy,
             $mapperEvent->allowReadOnlyTargetToPopulate ?? $this->configuration->allowReadOnlyTargetToPopulate,
+            $mapperEvent->strictTypes ?? $this->configuration->strictTypes,
             $mapperEvent->provider,
         );
     }

tests/AutoMapperTest.php

@@ -794,6 +794,15 @@ public function testStrictTypes(): void
         $automapper->map($data, Fixtures\IntDTO::class);
     }
 
+    public function testStrictTypesFromMapper(): void
+    {
+        $this->expectException(\TypeError::class);
+
+        $automapper = AutoMapper::create(new Configuration(strictTypes: false, classPrefix: 'StrictTypesFromMapper_'));
+        $data = ['foo' => 1.1];
+        $automapper->map($data, Fixtures\IntDTOWithMapper::class);
+    }
+
     public function testWithMixedArray(): void
     {
         $user = new Fixtures\User(1, 'yolo', '13');

tests/Fixtures/IntDTOWithMapper.php

@@ -0,0 +1,16 @@
+<?php
+
+declare(strict_types=1);
+
+namespace AutoMapper\Tests\Fixtures;
+
+use AutoMapper\Attribute\Mapper;
+
+#[Mapper(strictTypes: true)]
+readonly class IntDTOWithMapper
+{
+    public function __construct(
+        public int $foo,
+    ) {
+    }
+}