address review comments

Author: max-leuthaeuser

joern-cli/frontends/swiftsrc2cpg/src/test/scala/io/joern/swiftsrc2cpg/passes/ast/CallTests.scala

@@ -35,13 +35,17 @@ class CallTests extends SwiftCompilerSrc2CpgSuite {
       val List(barCall) = cpg.call.nameExact("bar").l
       barCall.methodFullName shouldBe x2cpg.Defines.DynamicCallUnknownFullName
       barCall.signature shouldBe ""
+      barCall.dispatchType shouldBe DispatchTypes.DYNAMIC_DISPATCH
+
       val List(barCallReceiverCall) = barCall.receiver.isIdentifier.l
       barCallReceiverCall.name shouldBe "self"
       barCallReceiverCall.typeFullName shouldBe "Sources/main.swift:<global>.Foo"
 
       val List(methodCall) = cpg.call.nameExact("method").l
       methodCall.methodFullName shouldBe x2cpg.Defines.DynamicCallUnknownFullName
       methodCall.signature shouldBe ""
+      methodCall.dispatchType shouldBe DispatchTypes.DYNAMIC_DISPATCH
+
       val List(methodCallReceiverCall) = methodCall.receiver.isIdentifier.l
       methodCallReceiverCall.name shouldBe "other"
       methodCallReceiverCall.typeFullName shouldBe "ANY"
@@ -64,13 +68,17 @@ class CallTests extends SwiftCompilerSrc2CpgSuite {
       val List(fooCall) = cpg.call.nameExact("foo").l
       fooCall.methodFullName shouldBe "SwiftTest.Foo.foo:()->()"
       fooCall.signature shouldBe "()->()"
+      fooCall.dispatchType shouldBe DispatchTypes.DYNAMIC_DISPATCH
+
       val List(fooCallReceiver) = fooCall.receiver.isIdentifier.l
       fooCallReceiver.name shouldBe "self"
       fooCallReceiver.typeFullName shouldBe "SwiftTest.Foo"
 
       val List(barCall) = cpg.call.nameExact("bar").l
       barCall.methodFullName shouldBe "SwiftTest.Foo.bar:()->Swift.String"
       barCall.signature shouldBe "()->Swift.String"
+      barCall.dispatchType shouldBe DispatchTypes.DYNAMIC_DISPATCH
+
       val List(barCallReceiverCall) = barCall.receiver.isIdentifier.l
       barCallReceiverCall.name shouldBe "self"
       barCallReceiverCall.typeFullName shouldBe "SwiftTest.Foo"

joern-cli/frontends/swiftsrc2cpg/src/test/scala/io/joern/swiftsrc2cpg/utils/SwiftCompilerTests.scala

@@ -597,8 +597,10 @@ class SwiftCompilerTests extends AnyWordSpec with Matchers {
               Some("SwiftHelloWorldLib.HelloWorld.init()->SwiftHelloWorldLib.HelloWorld")
             )
           )
-          mainMappings should contain(
-            ("func_decl", (67, 155), Some("Swift.Void"), Some("SwiftHelloWorld.Main.main()->()"))
+          mainMappings should contain oneElementOf List(
+            ("func_decl", (67, 155), Some("Swift.Void"), Some("SwiftHelloWorld.Main.main()->()")),
+            // TODO: in preparation for Swift 6.2.x migration, Void changed to () just like in the function signature
+            ("func_decl", (67, 155), Some("()"), Some("SwiftHelloWorld.Main.main()->()"))
           )
           mainMappings should contain(("var_decl", (102, 102), Some("SwiftHelloWorldLib.HelloWorld"), None))