[jssrc2cpg] Fix TS declare function handling (#5696)

max-leuthaeuser · web-flow · commit 0d1e3ce3bb61 · 2025-11-12T15:59:42.000+01:00
Method node generated for this construct were added twice into the AST.
diff --git a/joern-cli/frontends/jssrc2cpg/src/main/scala/io/joern/jssrc2cpg/astcreation/AstForFunctionsCreator.scala b/joern-cli/frontends/jssrc2cpg/src/main/scala/io/joern/jssrc2cpg/astcreation/AstForFunctionsCreator.scala
@@ -328,7 +328,7 @@ trait AstForFunctionsCreator(implicit withSchemaValidation: ValidationMode) { th
       .possibleTypes(possibleTypes)
     diffGraph.addEdge(getParentTypeDecl, memberNode_, EdgeTypes.AST)
     addModifier(functionNode, func.json)
-    Ast(functionNode)
+    Ast()
   }
 
   protected def createMethodDefinitionNode(
diff --git a/joern-cli/frontends/jssrc2cpg/src/test/scala/io/joern/jssrc2cpg/passes/ast/TsAstCreationPassTests.scala b/joern-cli/frontends/jssrc2cpg/src/test/scala/io/joern/jssrc2cpg/passes/ast/TsAstCreationPassTests.scala
@@ -109,6 +109,7 @@ class TsAstCreationPassTests extends AstJsSrc2CpgSuite(".ts") {
       arg.code shouldBe "arg: string"
       arg.index shouldBe 1
       cpg.method("foo").bindingTypeDecl.fullName.l shouldBe List("Test0.ts::program:foo")
+      func.astIn.size shouldBe 1
     }
 
     "have correct structure for type assertion" in {

Original file line number	Diff line number	Diff line change
`@@ -328,7 +328,7 @@ trait AstForFunctionsCreator(implicit withSchemaValidation: ValidationMode) { th`
`328`	`328`	`.possibleTypes(possibleTypes)`
`329`	`329`	`diffGraph.addEdge(getParentTypeDecl, memberNode_, EdgeTypes.AST)`
`330`	`330`	`addModifier(functionNode, func.json)`
`331`		`- Ast(functionNode)`
	`331`	`+ Ast()`
`332`	`332`	`}`
`333`	`333`
`334`	`334`	`protected def createMethodDefinitionNode(`
Original file line number	Diff line number	Diff line change
`@@ -109,6 +109,7 @@ class TsAstCreationPassTests extends AstJsSrc2CpgSuite(".ts") {`
`109`	`109`	`arg.code shouldBe "arg: string"`
`110`	`110`	`arg.index shouldBe 1`
`111`	`111`	`cpg.method("foo").bindingTypeDecl.fullName.l shouldBe List("Test0.ts::program:foo")`
	`112`	`+ func.astIn.size shouldBe 1`
`112`	`113`	`}`
`113`	`114`
`114`	`115`	`"have correct structure for type assertion" in {`