Skip to content

Commit cf6f7b2

Browse files
committed
clarify comment
1 parent aef8189 commit cf6f7b2

File tree

1 file changed

+4
-2
lines changed

1 file changed

+4
-2
lines changed

core/src/test/scala/flatgraph/SerializationTests.scala

Lines changed: 4 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -45,8 +45,10 @@ class SerializationTests extends AnyWordSpec with Matchers {
4545
originalDump shouldBe newDump
4646
}
4747

48-
/* show that we're no longer vulnerable to the denial of service issue filed here:
49-
* https://github.com/joernio/flatgraph/security/advisories/GHSA-jqmx-3x2p-69vh
48+
/* Show that we're no longer vulnerable to the 'denial of service attack by manipulating the manifest'
49+
* issue filed here: https://github.com/joernio/flatgraph/security/advisories/GHSA-jqmx-3x2p-69vh
50+
* Note that we cannot prevent all potential 'small flatgraph file leads to OOM error' attacks.
51+
* Always treat untrusted files with precaution...
5052
*/
5153
"is no longer vulnerable to manifest size attack" in {
5254
val schema = TestSchema.make(1, 0)

0 commit comments

Comments
 (0)