Performance improvements. Moved tests to NET 8

Author: alex-jitbit

.github/workflows/dotnet.yml

@@ -19,7 +19,7 @@ jobs:
     - name: Setup .NET
       uses: actions/setup-dotnet@v3
       with:
-        dotnet-version: 6.0.x
+        dotnet-version: 8.0.x
     - name: Restore dependencies
       run: dotnet restore
     - name: Build

CsvExport/CsvExport.cs

@@ -49,7 +49,7 @@ public class CsvExport
 		/// <summary>
 		/// The current row
 		/// </summary>
-		List<string> _currentRow { get { return _rows[_rows.Count - 1]; } }
+		List<string> _currentRow = null;
 
 		/// <summary>
 		/// The string used to separate columns in the output
@@ -98,7 +98,10 @@ public CsvExport(string columnSeparator = ",", bool includeColumnSeparatorDefini
 		/// </summary>
 		public object this[string field]
 		{
-			set {
+			set
+			{
+				if (_currentRow is null) return; // no row has been added yet
+
 				// Keep track of the field names
 				if (!_fields.TryGetValue(field, out int num)) //get the field's index
 				{
@@ -119,7 +122,8 @@ public object this[string field]
 		/// </summary>
 		public void AddRow()
 		{
-			_rows.Add(new(_fields.Count));
+			_currentRow = new(_fields.Count);
+			_rows.Add(_currentRow);
 		}
 
 		/// <summary>
@@ -129,7 +133,7 @@ public void AddRows<T>(IEnumerable<T> list)
 		{
 			if (list.Any())
 			{
-				var values = typeof(T).GetProperties();
+				var values = ReflectionCache<T>.Properties;
 				foreach (T obj in list)
 				{
 					AddRow();
@@ -157,27 +161,24 @@ public static string MakeValueCsvFriendly(object value, string columnSeparator =
 			if (value == null) return "";
 			if (value is INullable && ((INullable)value).IsNull) return "";
 
-			string output;
 			if (value is DateTime date)
 			{
 				if (date.TimeOfDay.TotalSeconds == 0)
 				{
-					output = date.ToString("yyyy-MM-dd");
+					return date.ToString("yyyy-MM-dd");
 				}
 				else
 				{
-					output = date.ToString("yyyy-MM-dd HH:mm:ss");
+					return date.ToString("yyyy-MM-dd HH:mm:ss");
 				}
 			}
-			else
-			{
-				output = value.ToString().Trim();
-			}
+
+			var output = value.ToString().Trim();
 
 			if (output.Length > 30000) //cropping value for stupid Excel
 				output = output.Substring(0, 30000);
 
-			if (output.Contains(columnSeparator) || output.Contains("\"") || output.Contains("\n") || output.Contains("\r"))
+			if (output.Contains(columnSeparator) || output.Contains('\"') || output.Contains('\n') || output.Contains('\r'))
 				output = '"' + output.Replace("\"", "\"\"") + '"';
 
 			return output;
@@ -277,4 +278,10 @@ public MemoryStream ExportAsMemoryStream(Encoding encoding = null)
 			return ms;
 		}
 	}
+
+	internal static class ReflectionCache<T>
+	{
+		private static System.Reflection.PropertyInfo[] _properties;
+		public static System.Reflection.PropertyInfo[] Properties => _properties ??= typeof(T).GetProperties();
+	}
 }

SpeedBenchmarks/SpeedBenchmarks.csproj

@@ -2,7 +2,7 @@
 
   <PropertyGroup>
     <OutputType>Exe</OutputType>
-    <TargetFramework>net6.0</TargetFramework>
+    <TargetFramework>net8.0</TargetFramework>
     <ImplicitUsings>enable</ImplicitUsings>
     <Nullable>enable</Nullable>
   </PropertyGroup>

UnitTests/UnitTests.csproj

@@ -1,7 +1,7 @@
 <Project Sdk="Microsoft.NET.Sdk">
 
   <PropertyGroup>
-    <TargetFramework>net6.0</TargetFramework>
+    <TargetFramework>net8.0</TargetFramework>
     <ImplicitUsings>enable</ImplicitUsings>
     <Nullable>enable</Nullable>