Skip to content

Added hash part to aggregated branch name #970

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
eyalk007 merged 6 commits into from
Dec 2, 2025
Merged

Added hash part to aggregated branch name #970

eyalk007 merged 6 commits into from
Dec 2, 2025

Conversation

@orto17
Copy link
Contributor

@orto17 orto17 commented Nov 20, 2025 •
edited by eyalk007
Loading

  • All tests passed. If this feature is not already covered by the tests, I added new tests.
  • This pull request is on the dev branch.
  • I used gofmt for formatting the code before submitting the pull request.
  • Update documentation about new features / new supported technologies

When GIT_AGGEGATE is set to true and JF_BRANCH_NAME_TEMPLATE is defined by the user, the branch is being created in the wrong format, aka the BRANCH_NAME_HASH part is missing. This PR aims to fix the issue.

eyalk007
eyalk007 reviewed Nov 20, 2025
View reviewed changes
@orto17 orto17 requested a review from eyalk007 November 20, 2025 10:09
@eyalk007 eyalk007 added the bug Something isn't working label Nov 24, 2025
@eyalk007 eyalk007 added the safe to test Approve running integration tests on a pull request label Nov 24, 2025
@github-actions github-actions bot removed the safe to test Approve running integration tests on a pull request label Nov 24, 2025
@eyalk007 eyalk007 added the safe to test Approve running integration tests on a pull request label Nov 25, 2025
@github-actions github-actions bot removed the safe to test Approve running integration tests on a pull request label Nov 25, 2025
@eyalk007 eyalk007 added the safe to test Approve running integration tests on a pull request label Nov 28, 2025
@github-actions github-actions bot removed the safe to test Approve running integration tests on a pull request label Nov 28, 2025
@orto17 orto17 added the safe to test Approve running integration tests on a pull request label Nov 30, 2025
@github-actions github-actions bot removed the safe to test Approve running integration tests on a pull request label Nov 30, 2025
@eyalk007 eyalk007 added the safe to test Approve running integration tests on a pull request label Dec 2, 2025
@github-actions github-actions bot removed the safe to test Approve running integration tests on a pull request label Dec 2, 2025
@eyalk007 eyalk007 added the safe to test Approve running integration tests on a pull request label Dec 2, 2025
@github-actions github-actions bot removed the safe to test Approve running integration tests on a pull request label Dec 2, 2025
@eyalk007 eyalk007 added the safe to test Approve running integration tests on a pull request label Dec 2, 2025
@github-actions github-actions bot removed the safe to test Approve running integration tests on a pull request label Dec 2, 2025
@github-actions
Copy link
Contributor

github-actions bot commented Dec 2, 2025

👍 Frogbot scanned this pull request and did not find any new security issues.

@eyalk007 eyalk007 merged commit 12d3148 into jfrog:dev Dec 2, 2025
33 checks passed
eyalk007 pushed a commit to eyalk007/frogbot that referenced this pull request Dec 4, 2025
@orto17 @eyalk007
Added hash part to aggregated branch name (jfrog#970)
d57c19b
eyalk007 pushed a commit to eyalk007/frogbot that referenced this pull request Dec 4, 2025
@orto17 @eyalk007
Added hash part to aggregated branch name (jfrog#970)
3766bc4
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@eyalk007 eyalk007 eyalk007 approved these changes

Assignees

@orto17 orto17

Labels

bug Something isn't working

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@orto17 @eyalk007