Skip to content

Commit a00dc93

Browse files
committed
test: update tests
Signed-off-by: Jack Cherng <[email protected]>
1 parent 598f0f4 commit a00dc93

File tree

1 file changed

+7
-7
lines changed

1 file changed

+7
-7
lines changed

tests/Renderer/RendererTest.php

Lines changed: 7 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -85,7 +85,7 @@ public function testSetOptionsWithInvalidResultForIdenticals(): void
8585
'we are the same',
8686
'Inline',
8787
[],
88-
['resultForIdenticals' => 50]
88+
['resultForIdenticals' => 50 /* should be string */],
8989
);
9090
}
9191

@@ -96,15 +96,15 @@ public function testSetOptionsWithInvalidResultForIdenticals(): void
9696
*/
9797
public function testHtmlRendererRenderWithResultFromJsonRenderer(): void
9898
{
99-
static $rendererNames = ['Inline', 'SideBySide', 'JsonHtml'];
99+
static $rendererNames = ['Inline', 'SideBySide', 'Combined', 'JsonHtml'];
100100

101101
$old = '_TEST_MARKER_OLD_';
102102
$new = '_TEST_MARKER_NEW_';
103103
$differOptions = [];
104104
$rendererOptions = [];
105105

106106
foreach ($rendererNames as $rendererName) {
107-
$renerer = RendererFactory::make($rendererName, $rendererOptions);
107+
$renderer = RendererFactory::make($rendererName, $rendererOptions);
108108

109109
$goldenResult = DiffHelper::calculate(
110110
$old,
@@ -125,8 +125,8 @@ public function testHtmlRendererRenderWithResultFromJsonRenderer(): void
125125

126126
static::assertSame(
127127
$goldenResult,
128-
$renerer->renderArray(\json_decode($jsonResult, true)),
129-
"HTML renderers should be able to render with JSON result. ('outputTagAsString' => false)"
128+
$renderer->renderArray(json_decode($jsonResult, true)),
129+
"HTML renderers should be able to render with JSON result. ('outputTagAsString' => false)",
130130
);
131131

132132
// test "outputTagAsString" is true
@@ -140,8 +140,8 @@ public function testHtmlRendererRenderWithResultFromJsonRenderer(): void
140140

141141
static::assertSame(
142142
$goldenResult,
143-
$renerer->renderArray(\json_decode($jsonResult, true)),
144-
"HTML renderers should be able to render with JSON result. ('outputTagAsString' => true)"
143+
$renderer->renderArray(json_decode($jsonResult, true)),
144+
"HTML renderers should be able to render with JSON result. ('outputTagAsString' => true)",
145145
);
146146
}
147147
}

0 commit comments

Comments
 (0)