[Bug]: Jest 30 beta causes random ERR_INVALID_THIS errors

[faulpeltz]

Version

30.0.0-beta

Steps to reproduce

1. Use https://github.com/faulpeltz/jest-issue-repro
2. Run jest

Expected behavior

Tests pass

Actual behavior

The test which is executed after the first fails with:
TypeError: Value of "this" must be of type EventTarget

Note that using worker_threads in my example is just one of many Node-builtin locations where this causes issues (in my actual test suite), mostly related to streams, child processes, etc.

Additional context

The issue cannot be reproduced in alpha.7, and I was able to track it down to this commit: 999bb65

This introduces a cleanup of the global object but it looks like it cleans up way to much - in my example EventTarget is removed after the first test file, causing the second to fail.
In this example this is caused by the cleanup of Symbol(nodejs.event_target) which is only defined after the initial setup phase and then is cleaned up - and probably other things as well. It seems that many Node builtin APIs lazily intialize some symbol properties on the global object when first used, and cleaning those up is probably unsafe.

If symbol-properties are skipped for cleanup, then things work normally

Environment

Linux Mint, x64, Node v22.16.0

[mrazauskas]

Thanks for the report. I think it is worth to ping @eyalroth

[eyalroth]

Thanks for the report and the minimal reproduction project. That was really helpful for debugging the issue.

Looks like my change in #15215 accidentally failed to protect all of the builtin node globals (especially the "lazy" ones).

I've opened a draft PR with what seems to be a straightforward fix. Hopefully all the tests pass and I'll move the PR from draft.

@mrazauskas Thanks for the ping, that's indeed my bad 😬

Edit: tests looking good on the PR (except for 1 flaky test, unrelated to my changes I believe).

[faulpeltz]

I tried the changes from #15636 with my repro code, but unfortunately it doesn't help

[eyalroth]

@faulpeltz how did you try to run it?

[faulpeltz]

I cloned the jest repo and ran the built output (which is described in the docs), removing the npm package first, applying your changes

[faulpeltz]

Looking at deleteProperties in the garbage-collection-utlils, why in general does it delete properties from within the builtins?
This is the list it deletes when cleaning up in my example:

structuredClone -> prototype
atob -> prototype
btoa -> prototype
fetch -> prototype
Symbol($$jest-matchers-object) -> customEqualityTesters
Symbol($$jest-matchers-object) -> matchers
Symbol($$jest-matchers-object) -> state
Symbol(JEST_STATE_SYMBOL) -> currentDescribeBlock
Symbol(JEST_STATE_SYMBOL) -> currentlyRunningTest
Symbol(JEST_STATE_SYMBOL) -> expand
Symbol(JEST_STATE_SYMBOL) -> parentProcess
Symbol(JEST_STATE_SYMBOL) -> rootDescribeBlock
Symbol(JEST_STATE_SYMBOL) -> randomize
Symbol(JEST_STATE_SYMBOL) -> originalGlobalErrorHandlers
Symbol(JEST_STATE_SYMBOL) -> Symbol($$jest-protect-from-deletion)
afterAll -> length
afterAll -> name
afterEach -> length
afterEach -> name
beforeAll -> length
beforeAll -> name
beforeEach -> length
beforeEach -> name
describe -> length
describe -> name
describe -> each
describe -> only
describe -> skip
it -> length
it -> name
it -> todo
it -> each
it -> failing
it -> only
it -> skip
it -> concurrent
fdescribe -> length
fdescribe -> name
fdescribe -> each
fit -> length
fit -> name
fit -> each
fit -> failing
xdescribe -> length
xdescribe -> name
xdescribe -> each
xit -> length
xit -> name
xit -> each
xit -> failing
expect -> length
expect -> name
expect -> extend
expect -> addEqualityTesters
expect -> anything
expect -> any
expect -> not
expect -> arrayContaining
expect -> arrayOf
expect -> closeTo
expect -> objectContaining
expect -> stringContaining
expect -> stringMatching
expect -> assertions
expect -> hasAssertions
expect -> getState
expect -> setState
expect -> extractExpectedAssertionsErrors
expect -> toMatchInlineSnapshot
expect -> toMatchSnapshot
expect -> toThrowErrorMatchingInlineSnapshot
expect -> toThrowErrorMatchingSnapshot
expect -> addSnapshotSerializer
EventTarget -> prototype

[eyalroth]

@faulpeltz can you describe step by step of how you ran the code from the pr?

Or alternatively link to the docs with the instructions you followed?

[faulpeltz]

Basically this:
https://github.com/jestjs/jest/blob/main/CONTRIBUTING.md#how-to-try-a-development-build-of-jest-in-another-project

I added some logging to make sure it actually runs the dev bundle

[lencioni]

@faulpeltz can you try this? #15636 (comment)

[faulpeltz]

This fixes the issue in my test project and also in the large test suite I originally tried it with, it now runs without any issues.

As a side note - with the curent beta, compared to the latest release, my large test suite completes ~10% faster and peaks at ~30% less memory