add process ID to temp file name to enable parallelised call of pdfbook #8
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When attempting to use pdfbook2 on multiple files simulataneously in a parallelised bash script, pdfbook2 throws a
file not founderror in line161because each launched process uses the same file name for the temporary file. This is defined in line41:41 tmpFile = ".crop-tmp.pdf"Adding the process ID to this temporary file fixes the issue. I suggest replacing line
41by41 tmpFile = f".{os.getpid()}.crop-tmp.pdf"In this way each of the temporary files is unique to each process.