chore: renovate plugin (#202)

* chore: renovate plugin dependencies

* chore: replace dependabot with renovate-bot

* chore: rephrase test TODO as it fails "style-check" 🙄

* chore: sure, complain about a "style issue" that existed for ages

🙄

---------

Co-authored-by: K3rnelPan1c <[email protected]>

Author: k3rnelpan1c-dev

.github/dependabot.yml renamed to .github/dependabot.yml.disabled

@@ -0,0 +1,37 @@
+{
+  "$schema": "https://docs.renovatebot.com/renovate-schema.json",
+  "extends": [
+    "config:base",
+    ":semanticCommits",
+    ":semanticCommitScope(deps)",
+    ":enableVulnerabilityAlertsWithLabel(security)",
+    "helpers:pinGitHubActionDigests",
+    "schedule:weekly"
+  ],
+  "dependencyDashboard": true,
+  "rebaseWhen": "conflicted",
+  "addLabels": ["dependencies"],
+  "packageRules": [
+    {
+      "description": "Add the ci and github-actions GitHub label to GitHub Action bump PRs",
+      "matchManagers": ["github-actions"],
+      "addLabels": ["ci", "github-actions"],
+      "semanticCommitType": "build"
+    },
+    {
+      "description": "Add the java GitHub label to Maven bump PRs",
+      "matchDatasources": ["maven"],
+      "addLabels": ["java"]
+    },
+    {
+      "description": "Group GitHub Action bumps to one PR as long as they have no major jump",
+      "matchManagers": ["github-actions"],
+      "groupName": "CI dependencies",
+      "groupSlug": "ci-dependencies",
+      "matchUpdateTypes": [
+        "minor",
+        "patch"
+      ]
+    }
+  ]
+}

.github/renovate.json

@@ -1,4 +1,4 @@
 buildPlugin(useContainerAgent: true, configurations: [
-  [ platform: "linux", jdk: "8" ],
-  [ platform: "linux", jdk: "11", javaLevel: "8" ]
+  [ platform: "linux", jdk: "11" ],
+  [ platform: "linux", jdk: "17" ]
 ])

Jenkinsfile

@@ -5,18 +5,18 @@
   <parent>
     <groupId>org.jenkins-ci.plugins</groupId>
     <artifactId>plugin</artifactId>
-    <version>4.47</version>
+    <version>4.66</version>
     <relativePath />
   </parent>
 
   <properties>
-    <revision>1.6.4</revision>
+    <revision>1.7.0</revision>
     <changelist>-SNAPSHOT</changelist>
     <!-- Baseline Jenkins version you use to build the plugin. Users must have this version or newer to run. -->
-    <jenkins.version>2.332.1</jenkins.version>
-    <bom.artifactId>2.332.x</bom.artifactId>
-    <bom.version>1595.v8c71c13cc3a_9</bom.version>
-    <java.level>8</java.level>
+    <jenkins.version>2.387.1</jenkins.version>
+    <bom.artifactId>2.387.x</bom.artifactId>
+    <bom.version>2143.ve4c3c9ec790a</bom.version>
+    <java.level>11</java.level>
     <!--
     Other properties you may want to use:
       ~ jenkins-test-harness.version: Jenkins Test Harness version you use to test the plugin. For Jenkins version >= 1.580.1 use JTH 2.0 or higher.
@@ -91,18 +91,25 @@
     </dependency>
     <dependency>
       <groupId>io.jenkins.plugins</groupId>
-      <artifactId>okhttp-api</artifactId>
-      <version>3.14.9</version>
+      <artifactId>commons-text-api</artifactId>
     </dependency>
     <dependency>
-      <groupId>com.jayway.jsonpath</groupId>
-      <artifactId>json-path</artifactId>
-      <version>2.7.0</version>
+      <groupId>io.jenkins.plugins</groupId>
+      <artifactId>commons-lang3-api</artifactId>
     </dependency>
     <dependency>
       <groupId>io.jenkins.plugins</groupId>
       <artifactId>jquery3-api</artifactId>
-      <version>3.6.0-4</version>
+    </dependency>
+    <dependency>
+      <groupId>io.jenkins.plugins</groupId>
+      <artifactId>okhttp-api</artifactId>
+      <version>3.14.9</version>
+    </dependency>
+    <dependency>
+      <groupId>com.jayway.jsonpath</groupId>
+      <artifactId>json-path</artifactId>
+      <version>2.8.0</version>
     </dependency>
     <dependency>
       <groupId>io.jenkins.plugins</groupId>

pom.xml

@@ -21,7 +21,7 @@ public static FormValidation doCheckXPathExpression(final String expression) {
       xpath.compile(expression);
       return FormValidation.ok();
     }
-    catch (XPathExpressionException | NullPointerException ignore) {
+    catch (XPathExpressionException ignore) {
       return FormValidation.error(Messages.RLP_PathExpressionValidationUtil_FormErr_xPath());
     }
   }

src/main/java/io/jenkins/plugins/restlistparam/util/PathExpressionValidationUtils.java

@@ -10,7 +10,7 @@
 
 import java.util.List;
 
-// TODO more unit tests here (preferably replace integration tests)
+// Task for later: more unit tests here (preferably replace integration tests)
 public class RestValueServiceTest {
   @Test
   public void successfulGetIntegrationTest() {