2.44.0

jdhitsolutions · jdhitsolutions · commit 198add301308 · 2022-09-15T10:08:00.000-04:00
diff --git a/Archive-ChangeLog.md b/Archive-ChangeLog.md
@@ -2,6 +2,14 @@
 
 This file contains older change history. It is maintained for reference purposes.
 
+## v2.40.0
+
++ Updated parameter validation for IP address in `Get-WhoIs` to allow addresses with 255 in an octet. [Issue #117](https://github.com/jdhitsolutions/PSScriptTools/issues/117).
++ Updated help files with missing online links.
++ Added command `Convert-HtmlToAnsi` with an alias of `cha`.
++ Modified `Convertto-Markdown` to add a `AsList` parameter. [Issue #114](https://github.com/jdhitsolutions/PSScriptTools/issues/114)
++ Updated `README.md`.
+
 ## v2.39.0
 
 + Updated `Test-WithCulture` to include additional Verbose output.
diff --git a/CONTRIBUTING.md b/CONTRIBUTING.md
@@ -1,5 +1,7 @@
 # PSScriptTools Contributions
 
-I welcome contributions and suggestions for this module. If you have a suggestion or problem, please post an issue. Please do not submit a pull request to fix a bug without first opening an issue as I may already be working on the problem. If you want to add an entirely new command through a pull request, create a new, stand-alone function in the `functions` directory and a markdown help document under the `docs`directory. Use the [Platyps](https://github.com/powershell/platyps) module to create the markdown file. When submitting a pull request, __do not__ update the module manifest or external help file. This module includes a documentation PDF that I need to generate with each new release. 
+I welcome contributions and suggestions for this module. If you have a suggestion or problem, please post an issue. Please __do not__ submit a pull request to fix a bug without first opening an issue as I may already be working on the problem. If you want to add an entirely new command through a pull request, create a new, stand-alone function in the `functions` directory and a markdown help document under the `docs`directory. Use the [Platyps](https://github.com/powershell/platyps) module to create the markdown file. When submitting a pull request, __do not__ update the module manifest or external help file. This module includes a documentation PDF that I need to generate with each new release.
+
+If you would like to update command documentation, you are welcome to submit a PR on the markdown file. Or, if it is a simple change, post an issue and I'll take care of it.
 
 If you have any questions about how you can contribute, please post an issue. One area where contributions *would* be welcome is Pester tests.
diff --git a/PSScriptTools.psd1 b/PSScriptTools.psd1
diff --git a/PSScriptToolsManual.pdf b/PSScriptToolsManual.pdf
diff --git a/README.md b/README.md
@@ -2,10 +2,6 @@
 
 ![PSGallery Version](https://img.shields.io/powershellgallery/v/PSScripttools.png?style=for-the-badge&logo=powershell&label=PowerShell%20Gallery)![PSGallery Downloads](https://img.shields.io/powershellgallery/dt/PSScripttools.png?style=for-the-badge&label=Downloads)
 
-## PowerShellGet v3 Beta :spider:
-
-There is a bug with the new cmdlets in the PowerShellGet v3 beta module and this module. You cannot use the beta cmdlets to install or update this module. Use `Install-Module` or `Update-Module` from the current stable release of PowerShellGet.
-
 ## Abstract
 
 This module contains a collection of functions, variables, and format files that you can use to enhance your PowerShell scripting work or get more done from a PowerShell prompt with less typing. Most of the commands are designed to work cross-platform. Please post any questions, problems, or feedback at [Issues](https://github.com/jdhitsolutions/PSScriptTools/issues) section of this module's Github repository. Feedback is greatly appreciated.
diff --git a/changelog.md b/changelog.md
@@ -2,6 +2,12 @@
 
 This file contains the most recent change history for the PSScriptTools module.
 
+## v2.44.0
+
++ Updated `Show-ANSISequence` to fix a bug where foreground samples where included when specifying background. [Issue #130](https://github.com/jdhitsolutions/PSScriptTools/issues/130)
++ Updated contributing guidelines.
++ Updated `README.md`.
+
 ## v2.43.0
 
 + Fixed VSCode snippets to run in a PowerShell 7 integrated console. [Issue #124](https://github.com/jdhitsolutions/PSScriptTools/issues/124)
@@ -33,14 +39,6 @@ This file contains the most recent change history for the PSScriptTools module.
 + Updated missing online help links.
 + Updated `README.md`.
 
-## v2.40.0
-
-+ Updated parameter validation for IP address in `Get-WhoIs` to allow addresses with 255 in an octet. [Issue #117](https://github.com/jdhitsolutions/PSScriptTools/issues/117).
-+ Updated help files with missing online links.
-+ Added command `Convert-HtmlToAnsi` with an alias of `cha`.
-+ Modified `Convertto-Markdown` to add a `AsList` parameter. [Issue #114](https://github.com/jdhitsolutions/PSScriptTools/issues/114)
-+ Updated `README.md`.
-
 ## Archive
 
 If you need to see older change history, look at the [Archive ChangeLog](https://github.com/jdhitsolutions/PSScriptTools/blob/master/Archive-ChangeLog.md) online.
diff --git a/functions/show-ansi.ps1 b/functions/show-ansi.ps1
@@ -27,8 +27,10 @@ Function Show-ANSISequence {
     if ($PSCmdlet.parametersetname -eq 'basic') {
         $Basic = $True
     }
-    elseif ($PSCmdlet.parametersetname -eq 'foreback') {
-        if ( (-Not ($PSBoundParameters.ContainsKey('foreground'))) -OR (-Not ($PSBoundParameters.ContainsKey('background')))) {
+    elseif ($PSCmdlet.ParameterSetName -eq 'foreback') {
+        Write-Debug "Testing bound parameters"
+        #9/15/2022 Fixed logic to avoid including Foreground unless specified. Issue #130 JDH
+        if ( (-Not ($PSBoundParameters.ContainsKey('foreground'))) -AND (-Not ($PSBoundParameters.ContainsKey('background')))) {
             #default to foreground Issue # 110
             Write-Debug "Setting Foreground as default"
             $Foreground = $True
