//JAVA should be win-first

[maxandersen]

not sure when this changed but pretty sure this wasn't done in past:

a.java

//JAVA 25
//SOURCES b.java

b.java

//JAVA 17

running this with jbang a.java should give you java 25 NOT java 17 but that is what is happening atm.

[quintesse]

That seems wrong indeed.

But unless you've got proof, I'm not assuming guilt of having caused a regression 😛

[quintesse]

I haven't looked at the code yet, but I could imagine that by default we take the "last one wins" approach ... which is fine if there's only a single file, but if you recurse down included files then that doesn't work anymore.

Besides, I'm not even sure that first/last would be correct either. We should probably go for "highest". Because if only one file says it need 24 but the main files says 11 then we're bound to get problems.

Edit: weird, looking at the code it already should be doing "highest"...

[maxandersen]

I haven't looked at the code yet, but I could imagine that by default we take the "last one wins" approach ... which is fine if there's only a single file, but if you recurse down included files then that doesn't work anymore.

no, last one wins is bad. I can't think of one where that makes sense.

i.e. deps is first one wins; as otherwise you can't meaningful control what dependency has highest importance.

Besides, I'm not even sure that first/last would be correct either. We should probably go for "highest". Because if only one file says it need 24 but the main files says 11 then we're bound to get problems.

I don't think that works.

Its first one wins for Java. If main one says //JAVA 11 and some other says //JAVA 24 then one of two thinks would happen:

1. java 11 syntax work for all, everyone is happy, 2) java 24 syntax used - compile error

And you'll want that be the case - fail if something not as expected.

Like, if //JAVA 24 after //JAVA 11 in sources wins...what should --java 12 on command line be? should that still give you Java 24? No, it should be Java 12.

Like think about maven or gradle, if you configure the compiler to be java 11 on your build file and then include somehtng that uses Java 24 - it uses Java 11...and fails if that does not work.

as mentioned elsewhere - classic config rules apply: defaults < sources < environment variables < command line flags

[quintesse]

Like, if //JAVA 24 after //JAVA 11 in sources wins...what should --java 12 on command line be? should that still give you Java 24? No, it should be Java 12.

I said "highest", so in the case of the source files 24 would win.

classic config rules apply

Of course , so that would mean that --java 12 wins in the end and the project will probably fail to compile because you overrode the 24 required by the source with a lower version.

To me it makes a lot of sense.

But I can also live with "hey, you put that //JAVA 11 line there, you do you, but you live with the consequences"