-
Notifications
You must be signed in to change notification settings - Fork 86
Open
Description
Hi, thanks for this project. Here's an issue I recently found. If the AWS upload fails for some reason (e.g., bad credentials), the backup script still proceeds as if nothing happened.
Here's an example where I intentionally messed up the AWS credentials:
[INFO] Uploading backup to S3
Will upload to bucket "***-backups"
upload failed: ./***-2022-11-27T17-47-09.tar.gz to s3://***-backups/***-2022-11-27T17-47-09.tar.gz An error occurred (SignatureDoesNotMatch) when calling the PutObject operation: The request signature we calculated does not match the signature you provided. Check your key and signing method.
Upload finished
...
[INFO] Backup finished
Will wait for next scheduled backupIt seems to be the expected behavior should be to fail the script.
virtualguy and m90
Metadata
Metadata
Assignees
Labels
No labels