Selection Colors

[japanoise]

As in the docs:

sam lets you configure a font for drawing text, and a colour to draw it with. However, due to the way sam draws selected text, you should set the foreground colour to black OR use a font without anti-aliasing. If you don't do at least one of those, selected text will be rainbow gibberish.

The best way to fix this would just be to update the selected text drawing code - and get some brownie points by making the selection color configurable!

[japanoise]

Current way it works is by bitblting a rectangle over the selection area, in libframe/frselect.c
This already conforms to the characters, so I think* we could change this to actually draw the buffer contents instead.

[japanoise]

Got into a bit of a rabbithole with this one. I think it'll have to wait until 16 is done - the bitblt stuff protects you from the complexities of redrawing in a way that is "helpful" but not great for this functionality. I'll leave it open in case follow ups are needed after 16 is done.

[japanoise]

the bitblt stuff protects you from the complexities of redrawing in a way that is "helpful" but not great for this functionality

These days though, we have SDL, and we could* store a reverse layer, and use masking to decide what to draw...

Here's a confirmation (for my own benefit) that indeed the colors are just reversed.