-
Notifications
You must be signed in to change notification settings - Fork 12
Open
Labels
code qualityframework/architectureimprovementImprovement of an existing featureImprovement of an existing feature
Description
At the moment we have a mixture of local and absolute imports within the project
from pyispyb.app.extensions.auth.AbstractAuthentication import AbstractAuthentication
from .extensions.auth.bearer import JWTBearer
I think i'd prefer relative imports if the paths arent crazy (we'll have to check the rest of the source)
And also whats imported in what order, i would usually import as follows
import pythonstandards
import os
import sys
import dependency1
import fastapi
import local
from .module import aThis makes it clear whats a standard module, whats a dependency, and whats relative to the package. I'm open to discussion on this.
We should probably also apply isort to sort imports alphabetically
Reactions are currently unavailable
Metadata
Metadata
Assignees
Labels
code qualityframework/architectureimprovementImprovement of an existing featureImprovement of an existing feature