Skip to content

Allow to use a IRB Interface as redundant distributed anycast gateway #122

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
felix-kaestner merged 1 commit into from
Dec 4, 2025
Merged

Allow to use a IRB Interface as redundant distributed anycast gateway #122

felix-kaestner merged 1 commit into from
Dec 4, 2025

Conversation

@felix-kaestner
Copy link
Contributor

@felix-kaestner felix-kaestner commented Nov 18, 2025

No description provided.

@felix-kaestner felix-kaestner requested a review from a team as a code owner November 18, 2025 15:59
@hardikdr hardikdr added the area/metal-automation Automation processes within the Metal project. label Nov 19, 2025
@hardikdr hardikdr added this to Roadmap Nov 19, 2025
@felix-kaestner felix-kaestner force-pushed the irb-anycast-gateway branch 2 times, most recently from c7dc3ad to 1875e7f Compare November 20, 2025 10:21
@felix-kaestner felix-kaestner force-pushed the evi-l2vni branch 2 times, most recently from abab336 to 602acbc Compare November 21, 2025 16:04
Base automatically changed from evi-l2vni to main December 3, 2025 14:40
nikatza
nikatza approved these changes Dec 4, 2025
View reviewed changes
Copy link
Contributor

@nikatza nikatza left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me.

The gNMI call will fail if feature fabric is not enabled, or the the MAC address is not configured on the nve interface, right?

@felix-kaestner
Copy link
Contributor Author

felix-kaestner commented Dec 4, 2025

The gNMI call will fail if feature fabric is not enabled, or the the MAC address is not configured on the nve interface, right?

Yes, this is correct. I've added a check to verify that the anycast gateway mac is configured and return an error otherwise. However, setting the anycast gateway mac address and enabling the fabric forwarding mode anycast-gateway should be done by the VTEP resource, I would say.

@github-actions
Copy link

github-actions bot commented Dec 4, 2025

Merging this branch changes the coverage (1 decrease, 1 increase)

Impacted Packages Coverage Δ 🤖
github.com/ironcore-dev/network-operator/api/core/v1alpha1 0.00% (ø)
github.com/ironcore-dev/network-operator/internal/controller/core 69.77% (+0.13%) 👍
github.com/ironcore-dev/network-operator/internal/provider/cisco/nxos 12.40% (-0.05%) 👎
Coverage by file

Changed files (no unit tests)

Changed File Coverage Δ Total Covered Missed 🤖
github.com/ironcore-dev/network-operator/api/core/v1alpha1/interface_types.go 0.00% (ø) 0 0 0
github.com/ironcore-dev/network-operator/internal/provider/cisco/nxos/intf.go 12.09% (+0.98%) 91 (+1) 11 (+1) 80 👍
github.com/ironcore-dev/network-operator/internal/provider/cisco/nxos/provider.go 0.09% (-0.00%) 1073 (+13) 1 1072 (+13) 👎

Please note that the "Total", "Covered", and "Missed" counts above refer to code statements instead of lines of code. The value in brackets refers to the test coverage of that file in the old version of the code.

Changed unit test files

  • github.com/ironcore-dev/network-operator/internal/controller/core/interface_controller_test.go
  • github.com/ironcore-dev/network-operator/internal/provider/cisco/nxos/intf_test.go

@felix-kaestner felix-kaestner merged commit f51823e into main Dec 4, 2025
9 of 11 checks passed
@felix-kaestner felix-kaestner deleted the irb-anycast-gateway branch December 4, 2025 17:26
@github-project-automation github-project-automation bot moved this to Done in Roadmap Dec 4, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@nikatza nikatza nikatza approved these changes

Assignees

No one assigned

Labels

area/metal-automation Automation processes within the Metal project.

Projects

Roadmap
Status: Done

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@felix-kaestner @nikatza @hardikdr