Report error on unknown BMC protocol (#530)

maxmoehl · web-flow · commit 337fbbde08b8 · 2025-11-18T14:45:53.000+01:00
* Report error on unknown BMC protocol

* Bump kubebuilder to v4.10.1
diff --git a/Makefile b/Makefile
@@ -279,7 +279,7 @@ ENVTEST_K8S_VERSION ?= $(shell go list -m -f "{{ .Version }}" k8s.io/api | awk -
 GOLANGCI_LINT_VERSION ?= v2.5
 GOIMPORTS_VERSION ?= v0.38.0
 GEN_CRD_API_REFERENCE_DOCS_VERSION ?= v0.3.0
-KUBEBUILDER_VERSION ?= v4.9.0
+KUBEBUILDER_VERSION ?= v4.10.1
 ADDLICENSE_VERSION ?= v1.1.1
 
 .PHONY: addlicense
diff --git a/internal/controller/endpoint_controller.go b/internal/controller/endpoint_controller.go
@@ -149,7 +149,8 @@ func (r *EndpointReconciler) reconcile(ctx context.Context, log logr.Logger, end
 					return ctrl.Result{}, fmt.Errorf("failed to apply BMC object: %w", err)
 				}
 				log.V(1).Info("Applied BMC object for Endpoint")
-
+			default:
+				return ctrl.Result{}, fmt.Errorf("uknown protocol: %s", m.Protocol)
 			}
 			// TODO: other types like Switches can be handled here later
 		}

Original file line number	Diff line number	Diff line change
`@@ -149,7 +149,8 @@ func (r *EndpointReconciler) reconcile(ctx context.Context, log logr.Logger, end`
`149`	`149`	`return ctrl.Result{}, fmt.Errorf("failed to apply BMC object: %w", err)`
`150`	`150`	`}`
`151`	`151`	`log.V(1).Info("Applied BMC object for Endpoint")`
`152`		`-`
	`152`	`+ default:`
	`153`	`+ return ctrl.Result{}, fmt.Errorf("uknown protocol: %s", m.Protocol)`
`153`	`154`	`}`
`154`	`155`	`// TODO: other types like Switches can be handled here later`
`155`	`156`	`}`