Fix coverity issues #659
Merged
Fix coverity issues #659
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
WalkthroughThe changes reorder resource cleanup calls in cloud deregistration error handling and simplify event callback timer polling by removing an unnecessary variable and explicitly resetting a global pointer before callbacks. Additionally, message reference counting and deallocation are refactored to separate concerns, with related updates in CoAP message handling and OSCORE message processing. Minor code style refinements were made in IP adapter source files. TLS handshake retry logic and certificate addition were refactored for clarity. Dockerfiles were reformatted for readability and package order adjusted. Changes
Sequence Diagram(s)sequenceDiagram
participant CloudDeregister
participant CloudContext
participant ApiParam
CloudDeregister->>CloudContext: clear (on error)
CloudDeregister->>ApiParam: free (after context cleared)
sequenceDiagram
participant EventCallbackPoll
participant EventCallback
participant GlobalPointer
loop For each event callback
EventCallbackPoll->>GlobalPointer: reset to NULL
alt Timer expired
EventCallbackPoll->>EventCallback: invoke callback
EventCallbackPoll->>EventCallback: remove and free if needed
else Timer not expired
EventCallbackPoll->>EventCallback: continue to next
end
end
sequenceDiagram
participant CoapEngine
participant Message
CoapEngine->>Message: oc_message_refcount()
alt refcount == 0
CoapEngine->>Message: oc_message_deallocate()
else
CoapEngine->>Message: retain message
end
sequenceDiagram
participant OSCOREEngine
participant OSCOREContext
participant Message
participant CoapPacket
OSCOREEngine->>OSCOREContext: find context for peer UUID
alt no context
OSCOREEngine->>OSCOREEngine: early exit to dispatch
else
OSCOREEngine->>Message: oc_message_unref2()
alt message not deallocated
OSCOREEngine->>CoapPacket: parse message (stack struct)
OSCOREEngine->>OSCOREEngine: process request or response with partial IV handling
OSCOREEngine->>Message: copy partial IV if needed
OSCOREEngine->>OSCOREEngine: serialize and encrypt OSCORE message
end
end
📜 Recent review detailsConfiguration used: CodeRabbit UI 📒 Files selected for processing (13)
✅ Files skipped from review due to trivial changes (1)
🚧 Files skipped from review as they are similar to previous changes (12)
⏰ Context from checks skipped due to timeout of 90000ms (50)
✨ Finishing Touches
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
SupportNeed help? Create a ticket on our support page for assistance with any issues or questions. Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
CodeRabbit Configuration File (
|
|
🎉 Thank you for your code contribution! To guarantee the change/addition is conformant to the OCF Specification, we would like to ask you to execute OCF Conformance Testing of your change ☝️ when your work is ready to be reviewed. ℹ️ To verify your latest change (b893536), label this PR with |
Danielius1922
added
OCF Conformance Testing
Fix issue 525174: Read from pointer after free in oc_cloud_deregister.c Fix issue 525173: Read from pointer after free in oc_event_callback.c Fix issue 525172: Read from pointer after free in oc_oscore_engine.c
Danielius1922
force-pushed
the
adam/feature/654-coverity-fixes-2
branch
from
c69a248 to
5c08316
Compare
ocf-conformance-test-tool
bot
removed
the
OCF Conformance Testing
|
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #654