fix promise in isPromotable()

Author: chrisdukakis

lib/api/api.js

@@ -639,31 +639,35 @@ api.prototype.sendTransfer = function(seed, depth, minWeightMagnitude, transfers
 * @param {object} params
 * @param callback
 *
-    * @returns 
+* @returns {array} transaction objects
 */
 api.prototype.promoteTransaction = function(tail, depth, minWeightMagnitude, transfer, params, callback) {
     var self = this;
     if (!inputValidator.isHash(tail)) {
         return callback(errors.invalidTrytes());
     }
 
-    if (!self.isPromotable(tail)) {
+    self.isPromotable(tail).then(function (isPromotable) {
+      if (!isPromotable) {
         return callback(errors.inconsistentSubtangle(tail));
-    }
+      }
 
-    if (params.interrupt === true) {
-        return callback(null, tail);
-    }
+      if (params.interrupt === true) {
+          return callback(null, tail);
+      }
 
-    self.sendTransfer(transfer[0].address, depth, minWeightMagnitude, transfer, {reference: tail}, function(err, res) {
-        if (err == null && params.delay > 0) {
-            setTimeout (function() {
-                self.promoteTransaction(tail, depth, minWeightMagnitude, transfer, params, callback);
-            }, params.delay);
-        } else {
-            return callback(err, res);
-        }
-    });
+      self.sendTransfer(transfer[0].address, depth, minWeightMagnitude, transfer, {reference: tail}, function(err, res) {
+          if (err == null && params.delay > 0) {
+              setTimeout (function() {
+                  self.promoteTransaction(tail, depth, minWeightMagnitude, transfer, params, callback);
+              }, params.delay);
+          } else {
+              return callback(err, res);
+          }
+      });
+    }).catch(function (err) {
+      callback(err)
+    })
 }
 
 /**
@@ -1949,6 +1953,9 @@ api.prototype.isPromotable = function(tail) {
 
     var promise = new Promise(function(res, rej) {
         self.sendCommand(command, function(err, isConsistent) {
+            if (err) {
+              rej(err)
+            }
             res(isConsistent.state);
         });
     });