Skip to content

Commit 68ea4cb

Browse files
committed
remove forgotten useless code + final code review
1 parent ad9cf56 commit 68ea4cb

File tree

2 files changed

+5
-17
lines changed

2 files changed

+5
-17
lines changed

CONTRIBUTING.md

Lines changed: 5 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -44,7 +44,11 @@ Ensure you have TypeScript compiler running to listen to `react-native` submodul
4444
yarn build:rn:watch
4545
```
4646

47-
## Step 5
47+
## Testing Code
48+
49+
### Manual testing
50+
51+
To run the example app and do manual testing. Make sure step 3 above is done first!
4852

4953
Run on iOS. Change `--simulator 'iPhone 16'` for you simulator if needed.
5054
```bash
@@ -56,7 +60,6 @@ or Android
5660
yarn run:android
5761
```
5862

59-
## Testing Code
6063

6164
### Unit Testing
6265

android/src/main/java/app/notifee/core/NotificationPendingIntent.java

Lines changed: 0 additions & 15 deletions
Original file line numberDiff line numberDiff line change
@@ -17,17 +17,13 @@
1717
*
1818
*/
1919

20-
import static app.notifee.core.event.NotificationEvent.TYPE_ACTION_PRESS;
21-
2220
import android.app.PendingIntent;
2321
import android.content.Context;
2422
import android.content.Intent;
2523
import android.os.Bundle;
2624
import app.notifee.core.event.MainComponentEvent;
2725
import app.notifee.core.model.NotificationAndroidPressActionModel;
28-
import app.notifee.core.model.NotificationModel;
2926
import app.notifee.core.utility.IntentUtils;
30-
3127
import java.util.UUID;
3228

3329
public class NotificationPendingIntent {
@@ -192,15 +188,4 @@ static Intent createLaunchActivityIntent(
192188

193189
return null;
194190
}
195-
196-
public static PendingIntent createPendingIntent(Bundle hangUpActionBundle, int notificationModel, NotificationModel notificationModel1) {
197-
Bundle pressActionBundle = hangUpActionBundle.getBundle("pressAction");
198-
return NotificationPendingIntent.createIntent(
199-
notificationModel,
200-
pressActionBundle,
201-
TYPE_ACTION_PRESS,
202-
new String[]{"notification", "pressAction"},
203-
notificationModel1.toBundle(),
204-
pressActionBundle);
205-
}
206191
}

0 commit comments

Comments
 (0)