Problem

The Checkbox.checked property always returns False if no value is set on the Checkbox, even if the associated checkbox was checked.

However, if a value is set on a Checkbox, it returns True even if the checkbox is unchecked.

Reproducing the bug

Will likely require a debugger

1. Go to the /account/create page
2. Tick the checkbox to sign up for IA newsletters
3. Submit the form
4. Inspect the value of the ia_newsletter Checkbox's checked property

• Expected behavior: checked is True
• Actual behavior: checked is False

Context

• Browser (Chrome, Safari, Firefox, etc): Any
• OS (Windows, Mac, etc): Any
• Logged in (Y/N): No
• Environment (prod, dev, local): prod

Breakdown

These Python Checkbox objects are only used by the account registration form, and I don't think that we have any plans to use any of our custom Python form Input objects in any other code paths. Let's remove the Checkbox definition and update the account registration template with HTML for the checkboxes.

Requirements Checklist

• Remove Checkbox definition
• Remove any Checkbox inputs from the `RegisterForm'
• Add HTML for checkboxes to the /account/create.html template
• Add unit test for account registration checkboxes

Related files

• Checkbox is defined in: https://github.com/internetarchive/openlibrary/blob/b434d3231c3b149cee785099ad1ba4494ac183c7/openlibrary/utils/form.py
• Reference to login form in /account/create POST handler:

  openlibrary/openlibrary/plugins/upstream/account.py

  Line 297 in b434d32

  f: forms.RegisterForm = self.get_form()

Stakeholders

Instructions for Contributors

• Please run these commands to ensure your repository is up to date before creating a new branch to work on this issue and each time after pushing code to Github, because the pre-commit bot may add commits to your PRs upstream.