Skip to content
This repository was archived by the owner on Dec 17, 2024. It is now read-only.

Commit ccac174

Browse files
authored
Merge pull request #39 from intel/prep2120
changes for 2.12.0
2 parents 4df5920 + 5bc65fd commit ccac174

File tree

11 files changed

+223
-75
lines changed

11 files changed

+223
-75
lines changed

RELEASE_NOTES

Lines changed: 7 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -6,6 +6,13 @@ Fully Supported Platforms
66
- Operating Systems: Ubuntu 18.04, 20.04, 22.04, 24.04, CentOS 7, Amazon Linux 2, Debian 11, RHEL 9, Rocky Linux 8
77
Note: svr-info may work on other micro-architectures and Linux distributions, but has not been thoroughly tested
88

9+
2.12.0
10+
Features Added/Changed
11+
- Gaudi devices enumerated
12+
- GNR-D vRAN accelerators enumerated
13+
- Minor modification to Excel 'brief' report's System Summary field
14+
- Show ELC thresholds for Compute Die(s)
15+
916
2.11.1
1017
Bugs Fixed
1118
- Fix frequency benchmark on GNR

cmd/orchestrator/resources/collector_reports.yaml.tmpl

Lines changed: 14 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -290,11 +290,7 @@ commands:
290290

291291
# Print metrics
292292
echo -n "$socket_id,$die,$die_type,$min_ratio,$max_ratio,$eff_latency_ctrl_ratio,"
293-
if [ $die_type == "IO" ] ; then
294-
echo "$eff_latency_ctrl_low_threshold,$eff_latency_ctrl_high_threshold,$eff_latency_ctrl_high_threshold_enable"
295-
else
296-
echo ",,"
297-
fi
293+
echo "$eff_latency_ctrl_low_threshold,$eff_latency_ctrl_high_threshold,$eff_latency_ctrl_high_threshold_enable"
298294
}
299295

300296
# Print CSV header
@@ -383,8 +379,20 @@ commands:
383379
done
384380
superuser: true
385381
parallel: true
382+
- label: gaudi info
383+
command: hl-smi -Q module_id,serial,bus_id,driver_version -f csv
384+
superuser: true
385+
parallel: true
386+
- label: gaudi firmware
387+
command: hl-smi --fw-version
388+
superuser: true
389+
parallel: true
390+
- label: gaudi numa
391+
command: hl-smi topo -N
392+
superuser: true
393+
parallel: true
386394
- label: lspci bits
387-
command: lspci -s $(lspci | grep 325b | awk 'NR==1{{print $1}}') -xxx | awk '$1 ~ /^90/{{print $9 $8 $7 $6; exit}}'
395+
command: lspci -s $(lspci | grep 325b | awk 'NR==1{print $1}') -xxx | awk '$1 ~ /^90/{print $9 $8 $7 $6; exit}'
388396
superuser: true
389397
parallel: true
390398
- label: lspci devices

cmd/reporter/report.go

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -65,6 +65,7 @@ func NewConfigurationReport(sources []*Source, CPUdb cpudb.CPUDB) (report *Repor
6565
newFilesystemTable(sources, Storage),
6666

6767
newGPUTable(sources, GPU),
68+
newGaudiTable(sources, GPU),
6869

6970
newCXLDeviceTable(sources, CXL),
7071

@@ -112,7 +113,7 @@ func NewBriefReport(sources []*Source, fullReport *Report, CPUdb cpudb.CPUDB) (r
112113
fullReport.findTable("Power"),
113114
tableEfficiencyLatencyControlSummary,
114115
newVulnerabilitySummaryTable(fullReport.findTable("Vulnerability"), Security),
115-
newMarketingClaimTable(fullReport, tableNicSummary, tableDiskSummary, tableAcceleratorSummary, NoCategory),
116+
newMarketingClaimTable(fullReport, tableNicSummary, tableDiskSummary, NoCategory),
116117
}...,
117118
)
118119
// TODO: remove check when code is stable

cmd/reporter/report_tables.go

Lines changed: 133 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -34,15 +34,15 @@ import (
3434
* nicSummaryTable() - has info derived from the full table, but is presented in summary format
3535
*/
3636

37-
func newMarketingClaimTable(fullReport *Report, tableNicSummary *Table, tableDiskSummary *Table, tableAcceleratorSummary *Table, category TableCategory) (table *Table) {
37+
func newMarketingClaimTable(fullReport *Report, tableNicSummary *Table, tableDiskSummary *Table, category TableCategory) (table *Table) {
3838
table = &Table{
3939
Name: "Marketing Claim",
4040
Category: category,
4141
AllHostValues: []HostValues{},
4242
}
43-
// BASELINE: 1-node, 2x Intel® Xeon® <SKU, processor>, xx cores, 100W TDP, HT On/Off?, Turbo On/Off?, NUMA xxx, Integrated Accelerators Available [used]: xxx, Total Memory xxx GB (xx slots/ xx GB/ xxxx MHz [run @ xxxx MHz] ), <BIOS version>, <ucode version>, <OS Version>, <kernel version>. Software: WORKLOAD+VERSION, COMPILER, LIBRARIES, OTHER_SW. Test by Intel as of <mm/dd/yy>.
44-
template := "1-node, %sx %s, %s cores, %s TDP, HT %s, Turbo %s, NUMA %s, Integrated Accelerators Available [used]: %s, Total Memory %s, BIOS %s, microcode %s, %s, %s, %s, %s. Software: WORKLOAD+VERSION, COMPILER, LIBRARIES, OTHER_SW. Test by Intel as of %s."
45-
var date, socketCount, cpuModel, coreCount, tdp, htOnOff, turboOnOff, numaNodes, installedMem, biosVersion, uCodeVersion, nics, disks, operatingSystem, kernelVersion string
43+
// BASELINE: 1-node, 2x Intel® Xeon® <SKU, processor>, xx cores, 100W TDP, HT On/Off?, Turbo On/Off?, Total Memory xxx GB (xx slots/ xx GB/ xxxx MHz [run @ xxxx MHz] ), <BIOS version>, <ucode version>, <OS Version>, <kernel version>. Test by Intel as of <mm/dd/yy>.
44+
template := "1-node, %sx %s, %s cores, %s TDP, HT %s, Turbo %s, Total Memory %s, BIOS %s, microcode %s, %s, %s, %s, %s. Test by Intel as of %s."
45+
var date, socketCount, cpuModel, coreCount, tdp, htOnOff, turboOnOff, installedMem, biosVersion, uCodeVersion, nics, disks, operatingSystem, kernelVersion string
4646

4747
for sourceIdx, source := range fullReport.Sources {
4848
var hostValues = HostValues{
@@ -78,16 +78,14 @@ func newMarketingClaimTable(fullReport *Report, tableNicSummary *Table, tableDis
7878
} else {
7979
turboOnOff = "?"
8080
}
81-
numaNodes, _ = fullReport.findTable("CPU").getValue(sourceIdx, "NUMA Nodes")
82-
accelerators, _ := tableAcceleratorSummary.getValue(sourceIdx, "Accelerators Available [used]")
8381
installedMem, _ = fullReport.findTable("Memory").getValue(sourceIdx, "Installed Memory")
8482
biosVersion, _ = fullReport.findTable("BIOS").getValue(sourceIdx, "Version")
8583
uCodeVersion, _ = fullReport.findTable("Operating System").getValue(sourceIdx, "Microcode")
8684
nics, _ = tableNicSummary.getValue(sourceIdx, "NIC")
8785
disks, _ = tableDiskSummary.getValue(sourceIdx, "Disk")
8886
operatingSystem, _ = fullReport.findTable("Operating System").getValue(sourceIdx, "OS")
8987
kernelVersion, _ = fullReport.findTable("Operating System").getValue(sourceIdx, "Kernel")
90-
claim := fmt.Sprintf(template, socketCount, cpuModel, coreCount, tdp, htOnOff, turboOnOff, numaNodes, accelerators, installedMem, biosVersion, uCodeVersion, nics, disks, operatingSystem, kernelVersion, date)
88+
claim := fmt.Sprintf(template, socketCount, cpuModel, coreCount, tdp, htOnOff, turboOnOff, installedMem, biosVersion, uCodeVersion, nics, disks, operatingSystem, kernelVersion, date)
9189
hostValues.Values = append(hostValues.Values, []string{claim})
9290
table.AllHostValues = append(table.AllHostValues, hostValues)
9391
}
@@ -1131,6 +1129,133 @@ func newGPUTable(sources []*Source, category TableCategory) (table *Table) {
11311129
return
11321130
}
11331131

1132+
type Gaudi struct {
1133+
ModuleID string
1134+
SerialNumber string
1135+
BusID string
1136+
DriverVersion string
1137+
EROM string
1138+
CPLD string
1139+
SPI string
1140+
NUMA string
1141+
}
1142+
1143+
func newGaudiTable(sources []*Source, category TableCategory) (table *Table) {
1144+
table = &Table{
1145+
Name: "Gaudi",
1146+
Category: category,
1147+
AllHostValues: []HostValues{},
1148+
}
1149+
for _, source := range sources {
1150+
gaudis := []Gaudi{}
1151+
for i, line := range source.getCommandOutputLines("gaudi info") {
1152+
if line == "" || i == 0 { // skip blank lines and header
1153+
continue
1154+
}
1155+
fields := strings.Split(line, ", ")
1156+
if len(fields) != 4 {
1157+
log.Printf("unexpected number of fields in gaudi info output")
1158+
continue
1159+
}
1160+
gaudis = append(gaudis, Gaudi{ModuleID: fields[0], SerialNumber: fields[1], BusID: fields[2], DriverVersion: fields[3]})
1161+
}
1162+
// sort the gaudis by module ID
1163+
sort.Slice(gaudis, func(i, j int) bool {
1164+
return gaudis[i].ModuleID < gaudis[j].ModuleID
1165+
})
1166+
// get NUMA affinity
1167+
numaAffinities := source.valsArrayFromRegexSubmatch("gaudi numa", `^(\d+)\s+(\d+)$`)
1168+
if len(numaAffinities) != len(gaudis) {
1169+
log.Printf("number of gaudis in gaudi info and numa output do not match")
1170+
return nil
1171+
}
1172+
for i, numaAffinity := range numaAffinities {
1173+
gaudis[i].NUMA = numaAffinity[1]
1174+
}
1175+
// get firmware versions
1176+
reDevice := regexp.MustCompile(`^\[(\d+)] AIP \(accel\d+\) (.*)$`)
1177+
reErom := regexp.MustCompile(`^erom$`)
1178+
reCpld := regexp.MustCompile(`^cpld$`)
1179+
rePreboot := regexp.MustCompile(`^preboot$`)
1180+
reComponent := regexp.MustCompile(`^component\s+:\s+hl-gaudi\d-(.*)-sec-\d+`)
1181+
reCpldComponent := regexp.MustCompile(`^component\s+:\s+(0x[0-9a-fA-F]+\.[0-9a-fA-F]+)$`)
1182+
deviceIdx := -1
1183+
state := -1
1184+
for _, line := range source.getCommandOutputLines("gaudi firmware") {
1185+
if line == "" {
1186+
continue
1187+
}
1188+
match := reDevice.FindStringSubmatch(line)
1189+
if match != nil {
1190+
var err error
1191+
deviceIdx, err = strconv.Atoi(match[1])
1192+
if err != nil {
1193+
log.Printf("failed to parse device index")
1194+
return nil
1195+
}
1196+
if deviceIdx >= len(gaudis) {
1197+
log.Printf("device index out of range")
1198+
return nil
1199+
}
1200+
continue
1201+
}
1202+
if deviceIdx == -1 {
1203+
continue
1204+
}
1205+
if reErom.FindString(line) != "" {
1206+
state = 0
1207+
continue
1208+
}
1209+
if reCpld.FindString(line) != "" {
1210+
state = 1
1211+
continue
1212+
}
1213+
if rePreboot.FindString(line) != "" {
1214+
state = 2
1215+
continue
1216+
}
1217+
if state != -1 {
1218+
switch state {
1219+
case 0:
1220+
match := reComponent.FindStringSubmatch(line)
1221+
if match != nil {
1222+
gaudis[deviceIdx].EROM = match[1]
1223+
}
1224+
case 1:
1225+
match := reCpldComponent.FindStringSubmatch(line)
1226+
if match != nil {
1227+
gaudis[deviceIdx].CPLD = match[1]
1228+
}
1229+
case 2:
1230+
match := reComponent.FindStringSubmatch(line)
1231+
if match != nil {
1232+
gaudis[deviceIdx].SPI = match[1]
1233+
}
1234+
}
1235+
state = -1
1236+
}
1237+
}
1238+
var hostValues = HostValues{
1239+
Name: source.getHostname(),
1240+
ValueNames: []string{
1241+
"Module ID",
1242+
"Serial Number",
1243+
"Bus ID",
1244+
"Driver Version",
1245+
"EROM",
1246+
"CPLD",
1247+
"SPI",
1248+
"NUMA Node",
1249+
},
1250+
}
1251+
for _, gaudi := range gaudis {
1252+
hostValues.Values = append(hostValues.Values, []string{gaudi.ModuleID, gaudi.SerialNumber, gaudi.BusID, gaudi.DriverVersion, gaudi.EROM, gaudi.CPLD, gaudi.SPI, gaudi.NUMA})
1253+
}
1254+
table.AllHostValues = append(table.AllHostValues, hostValues)
1255+
}
1256+
return
1257+
}
1258+
11341259
func newNICTable(sources []*Source, category TableCategory) (table *Table) {
11351260
table = &Table{
11361261
Name: "NIC",
@@ -1140,7 +1265,7 @@ func newNICTable(sources []*Source, category TableCategory) (table *Table) {
11401265
idxNicName := 0
11411266
idxNicModel := 1
11421267
for _, source := range sources {
1143-
nicsInfo := source.valsArrayFromRegexSubmatch("lshw", `^pci.*? (\S+)\s+network\s+(\S.*?)\s+\[\w+:\w+]$`)
1268+
nicsInfo := source.valsArrayFromRegexSubmatch("lshw", `^\S+\s+(\S+)\s+network\s+([^\[]+?)(?:\s+\[.*\])?$`)
11441269
nicsInfo = append(nicsInfo, source.valsArrayFromRegexSubmatch("lshw", `^usb.*? (\S+)\s+network\s+(\S.*?)$`)...)
11451270
var nics [][]string
11461271
for _, nic := range nicsInfo {

cmd/reporter/resources/accelerators.yaml

Lines changed: 6 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -32,3 +32,9 @@
3232
devid: 37C8
3333
full_name: Intel Quick Assist Technology
3434
description: accelerates data encryption and compression for applications from networking to enterprise, cloud to storage, and content delivery to database
35+
36+
- name: vRAN Boost
37+
mfgid: 8086
38+
devid: 57C2
39+
full_name: Intel vRAN Boost Accelerator
40+
description: accelerates vRAN workloads

go.mod

Lines changed: 22 additions & 23 deletions
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,8 @@
11
module github.com/intel/svr-info
22

3-
go 1.22
3+
go 1.22.0
4+
5+
toolchain go1.23.0
46

57
replace github.com/intel/svr-info/internal/core => ./internal/core
68

@@ -21,29 +23,29 @@ require (
2123
github.com/deckarep/golang-set/v2 v2.6.0
2224
github.com/google/go-cmp v0.6.0
2325
github.com/hyperjumptech/grule-rule-engine v1.15.0
24-
github.com/intel/svr-info/internal/commandfile v0.0.0-00010101000000-000000000000
25-
github.com/intel/svr-info/internal/core v0.0.0-00010101000000-000000000000
26-
github.com/intel/svr-info/internal/cpudb v0.0.0-20240202173944-01aa39f167b4
27-
github.com/intel/svr-info/internal/msr v0.0.0-00010101000000-000000000000
28-
github.com/intel/svr-info/internal/progress v0.0.0-00010101000000-000000000000
29-
github.com/intel/svr-info/internal/target v0.0.0-00010101000000-000000000000
30-
github.com/intel/svr-info/internal/util v0.0.0-00010101000000-000000000000
26+
github.com/intel/svr-info/internal/commandfile v0.0.0-20240826225705-4df592082b12
27+
github.com/intel/svr-info/internal/core v0.0.0-20240826225705-4df592082b12
28+
github.com/intel/svr-info/internal/cpudb v0.0.0-20240826225705-4df592082b12
29+
github.com/intel/svr-info/internal/msr v0.0.0-20240826225705-4df592082b12
30+
github.com/intel/svr-info/internal/progress v0.0.0-20240826225705-4df592082b12
31+
github.com/intel/svr-info/internal/target v0.0.0-20240826225705-4df592082b12
32+
github.com/intel/svr-info/internal/util v0.0.0-20240826225705-4df592082b12
3133
github.com/xuri/excelize/v2 v2.8.1
32-
golang.org/x/exp v0.0.0-20240409090435-93d18d7e34b8
33-
golang.org/x/term v0.23.0
34-
golang.org/x/text v0.17.0
34+
golang.org/x/exp v0.0.0-20241004190924-225e2abe05e6
35+
golang.org/x/term v0.25.0
36+
golang.org/x/text v0.19.0
3537
gopkg.in/yaml.v2 v2.4.0
3638
)
3739

3840
require (
39-
dario.cat/mergo v1.0.0 // indirect
40-
github.com/Microsoft/go-winio v0.6.1 // indirect
41+
dario.cat/mergo v1.0.1 // indirect
42+
github.com/Microsoft/go-winio v0.6.2 // indirect
4143
github.com/ProtonMail/go-crypto v1.0.0 // indirect
4244
github.com/antlr/antlr4/runtime/Go/antlr v1.4.10 // indirect
4345
github.com/bmatcuk/doublestar v1.3.4 // indirect
44-
github.com/cloudflare/circl v1.3.7 // indirect
46+
github.com/cloudflare/circl v1.4.0 // indirect
4547
github.com/creasty/defaults v1.8.0 // indirect
46-
github.com/cyphar/filepath-securejoin v0.2.4 // indirect
48+
github.com/cyphar/filepath-securejoin v0.3.3 // indirect
4749
github.com/emirpasic/gods v1.18.1 // indirect
4850
github.com/go-git/gcfg v1.5.1-0.20230307220236-3a3c6141e376 // indirect
4951
github.com/go-git/go-billy/v5 v5.5.0 // indirect
@@ -55,20 +57,17 @@ require (
5557
github.com/mohae/deepcopy v0.0.0-20170929034955-c48cc78d4826 // indirect
5658
github.com/pjbgf/sha1cd v0.3.0 // indirect
5759
github.com/richardlehane/mscfb v1.0.4 // indirect
58-
github.com/richardlehane/msoleps v1.0.3 // indirect
60+
github.com/richardlehane/msoleps v1.0.4 // indirect
5961
github.com/sergi/go-diff v1.3.2-0.20230802210424-5b0b94c5c0d3 // indirect
6062
github.com/sirupsen/logrus v1.9.3 // indirect
61-
github.com/skeema/knownhosts v1.2.2 // indirect
63+
github.com/skeema/knownhosts v1.3.0 // indirect
6264
github.com/xanzy/ssh-agent v0.3.3 // indirect
6365
github.com/xuri/efp v0.0.0-20240408161823-9ad904a10d6d // indirect
6466
github.com/xuri/nfp v0.0.0-20240318013403-ab9948c2c4a7 // indirect
6567
go.uber.org/multierr v1.11.0 // indirect
6668
go.uber.org/zap v1.27.0 // indirect
67-
golang.org/x/crypto v0.23.0 // indirect
68-
golang.org/x/mod v0.17.0 // indirect
69-
golang.org/x/net v0.25.0 // indirect
70-
golang.org/x/sync v0.8.0 // indirect
71-
golang.org/x/sys v0.23.0 // indirect
72-
golang.org/x/tools v0.21.1-0.20240508182429-e35e4ccd0d2d // indirect
69+
golang.org/x/crypto v0.28.0 // indirect
70+
golang.org/x/net v0.30.0 // indirect
71+
golang.org/x/sys v0.26.0 // indirect
7372
gopkg.in/warnings.v0 v0.1.2 // indirect
7473
)

0 commit comments

Comments
 (0)