From f49d51e599a1aee5062a93cf5b548fb773a1e4e1 Mon Sep 17 00:00:00 2001 From: dev-tomek Date: Mon, 15 Dec 2025 09:21:29 +0000 Subject: [PATCH 1/4] disable ignore errors on windows --- .github/workflows/build-test-windows.yml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/.github/workflows/build-test-windows.yml b/.github/workflows/build-test-windows.yml index beadb7f8a4..f45eaa5c5b 100644 --- a/.github/workflows/build-test-windows.yml +++ b/.github/workflows/build-test-windows.yml @@ -24,7 +24,7 @@ env: PYTHON_VERSION: "3.10" NEW_WORKSPACE: C:\gh${{ github.run_id }} SKIPLIST: --skip-list scripts/skiplist/${{ inputs.skip_list }} - TRITON_TEST_CMD: bash -x scripts/test-triton.sh --skip-pytorch-install --skip-pip-install --skip-list scripts/skiplist/${{ inputs.skip_list }} --reports-dir reports --ignore-errors + TRITON_TEST_CMD: bash -x scripts/test-triton.sh --skip-pytorch-install --skip-pip-install --skip-list scripts/skiplist/${{ inputs.skip_list }} --reports-dir reports jobs: build: From dc269426e96580b0e5e62710c55b2a80e9707453 Mon Sep 17 00:00:00 2001 From: dev-tomek Date: Mon, 15 Dec 2025 11:29:37 +0000 Subject: [PATCH 2/4] continue on error for validation steps --- .github/workflows/build-test-windows.yml | 7 +++++++ 1 file changed, 7 insertions(+) diff --git a/.github/workflows/build-test-windows.yml b/.github/workflows/build-test-windows.yml index f45eaa5c5b..9b91b3d090 100644 --- a/.github/workflows/build-test-windows.yml +++ b/.github/workflows/build-test-windows.yml @@ -151,6 +151,7 @@ jobs: Invoke-BatchFile "C:\Program Files (x86)\Intel\oneAPI\setvars.bat" cd ${{ env.NEW_WORKSPACE }} ${{ env.TRITON_TEST_CMD }} --unit + continue-on-error: true - name: Run core tests run: | @@ -158,6 +159,7 @@ jobs: Invoke-BatchFile "C:\Program Files (x86)\Intel\oneAPI\setvars.bat" cd ${{ env.NEW_WORKSPACE }} ${{ env.TRITON_TEST_CMD }} --core + continue-on-error: true - name: Run gluon tests run: | @@ -165,6 +167,7 @@ jobs: Invoke-BatchFile "C:\Program Files (x86)\Intel\oneAPI\setvars.bat" cd ${{ env.NEW_WORKSPACE }} ${{ env.TRITON_TEST_CMD }} --gluon + continue-on-error: true - name: Run triton kernels tests run: | @@ -172,6 +175,7 @@ jobs: Invoke-BatchFile "C:\Program Files (x86)\Intel\oneAPI\setvars.bat" cd ${{ env.NEW_WORKSPACE }} ${{ env.TRITON_TEST_CMD }} --triton-kernels + continue-on-error: true - name: Run interpreter tests run: | @@ -179,6 +183,7 @@ jobs: Invoke-BatchFile "C:\Program Files (x86)\Intel\oneAPI\setvars.bat" cd ${{ env.NEW_WORKSPACE }} ${{ env.TRITON_TEST_CMD }} --interpreter + continue-on-error: true - name: Run tutorials run: | @@ -188,6 +193,7 @@ jobs: $env:MPLBACKEND = "Agg" cd ${{ env.NEW_WORKSPACE }} ${{ env.TRITON_TEST_CMD }} --tutorial + continue-on-error: true - name: Run instrumentation tests run: | @@ -195,6 +201,7 @@ jobs: Invoke-BatchFile "C:\Program Files (x86)\Intel\oneAPI\setvars.bat" cd ${{ env.NEW_WORKSPACE }} ${{ env.TRITON_TEST_CMD }} --instrumentation + continue-on-error: true - name: Pass rate run: | From 9b5ab6427419f1af239bc4833a11d0ca789fbe27 Mon Sep 17 00:00:00 2001 From: dev-tomek Date: Tue, 16 Dec 2025 09:32:24 +0000 Subject: [PATCH 3/4] change continue-on-error --- .github/workflows/build-test-windows.yml | 14 +++++++------- 1 file changed, 7 insertions(+), 7 deletions(-) diff --git a/.github/workflows/build-test-windows.yml b/.github/workflows/build-test-windows.yml index 9b91b3d090..0f22b223bb 100644 --- a/.github/workflows/build-test-windows.yml +++ b/.github/workflows/build-test-windows.yml @@ -146,46 +146,47 @@ jobs: pip uninstall pytest_forked -y - name: Run unit tests + if: ${{ !cancelled() }} run: | .venv\Scripts\activate.ps1 Invoke-BatchFile "C:\Program Files (x86)\Intel\oneAPI\setvars.bat" cd ${{ env.NEW_WORKSPACE }} ${{ env.TRITON_TEST_CMD }} --unit - continue-on-error: true - name: Run core tests + if: ${{ !cancelled() }} run: | .venv\Scripts\activate.ps1 Invoke-BatchFile "C:\Program Files (x86)\Intel\oneAPI\setvars.bat" cd ${{ env.NEW_WORKSPACE }} ${{ env.TRITON_TEST_CMD }} --core - continue-on-error: true - name: Run gluon tests + if: ${{ !cancelled() }} run: | .venv\Scripts\activate.ps1 Invoke-BatchFile "C:\Program Files (x86)\Intel\oneAPI\setvars.bat" cd ${{ env.NEW_WORKSPACE }} ${{ env.TRITON_TEST_CMD }} --gluon - continue-on-error: true - name: Run triton kernels tests + if: ${{ !cancelled() }} run: | .venv\Scripts\activate.ps1 Invoke-BatchFile "C:\Program Files (x86)\Intel\oneAPI\setvars.bat" cd ${{ env.NEW_WORKSPACE }} ${{ env.TRITON_TEST_CMD }} --triton-kernels - continue-on-error: true - name: Run interpreter tests + if: ${{ !cancelled() }} run: | .venv\Scripts\activate.ps1 Invoke-BatchFile "C:\Program Files (x86)\Intel\oneAPI\setvars.bat" cd ${{ env.NEW_WORKSPACE }} ${{ env.TRITON_TEST_CMD }} --interpreter - continue-on-error: true - name: Run tutorials + if: ${{ !cancelled() }} run: | .venv\Scripts\activate.ps1 Invoke-BatchFile "C:\Program Files (x86)\Intel\oneAPI\setvars.bat" @@ -193,15 +194,14 @@ jobs: $env:MPLBACKEND = "Agg" cd ${{ env.NEW_WORKSPACE }} ${{ env.TRITON_TEST_CMD }} --tutorial - continue-on-error: true - name: Run instrumentation tests + if: ${{ !cancelled() }} run: | .venv\Scripts\activate.ps1 Invoke-BatchFile "C:\Program Files (x86)\Intel\oneAPI\setvars.bat" cd ${{ env.NEW_WORKSPACE }} ${{ env.TRITON_TEST_CMD }} --instrumentation - continue-on-error: true - name: Pass rate run: | From 9975eebdf3da666491630a5bced837b0cc6a4c8f Mon Sep 17 00:00:00 2001 From: dev-tomek Date: Tue, 16 Dec 2025 14:15:32 +0000 Subject: [PATCH 4/4] add more steps --- .github/workflows/build-test-windows.yml | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/.github/workflows/build-test-windows.yml b/.github/workflows/build-test-windows.yml index 0f22b223bb..232e8e281e 100644 --- a/.github/workflows/build-test-windows.yml +++ b/.github/workflows/build-test-windows.yml @@ -204,6 +204,7 @@ jobs: ${{ env.TRITON_TEST_CMD }} --instrumentation - name: Pass rate + if: ${{ !cancelled() }} run: | .venv\Scripts\activate.ps1 # oneAPI is required for sycl-ls, which is used by scripts/capture-hw-details.sh @@ -219,13 +220,14 @@ jobs: - name: Upload pass rate report # upload reports only for the default branch - if: github.ref_name == 'main' + if: ${{ !cancelled() && github.ref_name == 'main' }} uses: actions/upload-artifact@v5 with: name: pass_rate path: ${{ env.NEW_WORKSPACE }}\pass_rate*.json - name: Upload tutorial performance + if: ${{ !cancelled() }} uses: actions/upload-artifact@v5 with: name: tutorials-report