build: add clang-tidy restriction for Enum case

Signed-off-by: Mateusz Jablonski <[email protected]>

Author: JablonskiMateusz

.clang-tidy

@@ -24,6 +24,8 @@ CheckOptions:
     value:           CamelCase
   - key:             readability-identifier-naming.StructIgnoredRegexp
     value:           '(_|TOKSTR_).+'
+  - key:             readability-identifier-naming.EnumCase
+    value:           CamelCase
   - key:             readability-identifier-naming.MethodCase
     value:           camelBack
   - key:             readability-identifier-naming.PrivateMethodCase

level_zero/core/source/cmdqueue/cmdqueue.cpp

@@ -283,34 +283,34 @@ ze_result_t CommandQueueImp::CommandBufferManager::initialize(Device *device, si
         secondBuffer = device->getNEODevice()->getMemoryManager()->allocateGraphicsMemoryWithProperties(properties);
     }
 
-    buffers[BUFFER_ALLOCATION::FIRST] = firstBuffer;
-    buffers[BUFFER_ALLOCATION::SECOND] = secondBuffer;
+    buffers[BufferAllocation::first] = firstBuffer;
+    buffers[BufferAllocation::second] = secondBuffer;
 
-    if (!buffers[BUFFER_ALLOCATION::FIRST] || !buffers[BUFFER_ALLOCATION::SECOND]) {
+    if (!buffers[BufferAllocation::first] || !buffers[BufferAllocation::second]) {
         return ZE_RESULT_ERROR_OUT_OF_DEVICE_MEMORY;
     }
 
-    flushId[BUFFER_ALLOCATION::FIRST] = std::make_pair(0u, 0u);
-    flushId[BUFFER_ALLOCATION::SECOND] = std::make_pair(0u, 0u);
+    flushId[BufferAllocation::first] = std::make_pair(0u, 0u);
+    flushId[BufferAllocation::second] = std::make_pair(0u, 0u);
     return ZE_RESULT_SUCCESS;
 }
 
 void CommandQueueImp::CommandBufferManager::destroy(Device *device) {
-    if (buffers[BUFFER_ALLOCATION::FIRST]) {
-        device->storeReusableAllocation(*buffers[BUFFER_ALLOCATION::FIRST]);
-        buffers[BUFFER_ALLOCATION::FIRST] = nullptr;
+    if (buffers[BufferAllocation::first]) {
+        device->storeReusableAllocation(*buffers[BufferAllocation::first]);
+        buffers[BufferAllocation::first] = nullptr;
     }
-    if (buffers[BUFFER_ALLOCATION::SECOND]) {
-        device->storeReusableAllocation(*buffers[BUFFER_ALLOCATION::SECOND]);
-        buffers[BUFFER_ALLOCATION::SECOND] = nullptr;
+    if (buffers[BufferAllocation::second]) {
+        device->storeReusableAllocation(*buffers[BufferAllocation::second]);
+        buffers[BufferAllocation::second] = nullptr;
     }
 }
 
 NEO::WaitStatus CommandQueueImp::CommandBufferManager::switchBuffers(NEO::CommandStreamReceiver *csr) {
-    if (bufferUse == BUFFER_ALLOCATION::FIRST) {
-        bufferUse = BUFFER_ALLOCATION::SECOND;
+    if (bufferUse == BufferAllocation::first) {
+        bufferUse = BufferAllocation::second;
     } else {
-        bufferUse = BUFFER_ALLOCATION::FIRST;
+        bufferUse = BufferAllocation::first;
     }
 
     auto waitStatus{NEO::WaitStatus::ready};

level_zero/core/source/cmdqueue/cmdqueue_imp.h

@@ -36,10 +36,10 @@ struct Kernel;
 struct CommandQueueImp : public CommandQueue {
     class CommandBufferManager {
       public:
-        enum BUFFER_ALLOCATION : uint32_t {
-            FIRST = 0,
-            SECOND,
-            COUNT
+        enum BufferAllocation : uint32_t {
+            first = 0,
+            second,
+            count
         };
 
         ze_result_t initialize(Device *device, size_t sizeRequested);
@@ -58,9 +58,9 @@ struct CommandQueueImp : public CommandQueue {
         }
 
       private:
-        NEO::GraphicsAllocation *buffers[BUFFER_ALLOCATION::COUNT]{};
-        std::pair<TaskCountType, NEO::FlushStamp> flushId[BUFFER_ALLOCATION::COUNT];
-        BUFFER_ALLOCATION bufferUse = BUFFER_ALLOCATION::FIRST;
+        NEO::GraphicsAllocation *buffers[BufferAllocation::count]{};
+        std::pair<TaskCountType, NEO::FlushStamp> flushId[BufferAllocation::count];
+        BufferAllocation bufferUse = BufferAllocation::first;
     };
     static constexpr size_t defaultQueueCmdBufferSize = 128 * MemoryConstants::kiloByte;
     static constexpr size_t minCmdBufferPtrAlign = 8;

level_zero/core/source/gfx_core_helpers/l0_gfx_core_helper.h

@@ -29,12 +29,10 @@ class Debugger;
 
 namespace L0 {
 
-typedef enum _ze_rtas_device_format_internal_t {
-    ZE_RTAS_DEVICE_FORMAT_EXP_INVALID = 0,   // invalid acceleration structure format
-    ZE_RTAS_DEVICE_FORMAT_EXP_VERSION_1 = 1, // acceleration structure format version 1
-    ZE_RTAS_DEVICE_FORMAT_EXP_VERSION_2 = 2, // acceleration structure format version 2
-    ZE_RTAS_DEVICE_FORMAT_EXP_VERSION_MAX = 2
-} ze_rtas_device_format_internal_t;
+enum class RTASDeviceFormatInternal {
+    version1 = 1,
+    version2 = 2,
+};
 
 struct Event;
 struct Device;

level_zero/core/source/gfx_core_helpers/l0_gfx_core_helper_xehp_and_later.inl

@@ -74,7 +74,7 @@ NEO::HeapAddressModel L0GfxCoreHelperHw<Family>::getPlatformHeapAddressModel() c
 
 template <typename Family>
 ze_rtas_format_exp_t L0GfxCoreHelperHw<Family>::getSupportedRTASFormat() const {
-    return static_cast<ze_rtas_format_exp_t>(ZE_RTAS_DEVICE_FORMAT_EXP_VERSION_1);
+    return static_cast<ze_rtas_format_exp_t>(RTASDeviceFormatInternal::version1);
 }
 
 template <typename Family>

level_zero/core/test/unit_tests/fixtures/module_fixture.cpp

@@ -88,7 +88,7 @@ void ModuleImmutableDataFixture::setUp() {
     DeviceFixture::setupWithExecutionEnvironment(*executionEnvironment);
 }
 
-void ModuleImmutableDataFixture::createModuleFromMockBinary(uint32_t perHwThreadPrivateMemorySize, bool isInternal, MockImmutableData *mockKernelImmData, std::initializer_list<ZebinTestData::appendElfAdditionalSection> additionalSections) {
+void ModuleImmutableDataFixture::createModuleFromMockBinary(uint32_t perHwThreadPrivateMemorySize, bool isInternal, MockImmutableData *mockKernelImmData, std::initializer_list<ZebinTestData::AppendElfAdditionalSection> additionalSections) {
     DebugManagerStateRestore restore;
     debugManager.flags.FailBuildProgramWithStatefulAccess.set(0);
 

level_zero/core/test/unit_tests/fixtures/module_fixture.h

@@ -108,7 +108,7 @@ struct ModuleImmutableDataFixture : public DeviceFixture {
     void setUp();
 
     void createModuleFromMockBinary(uint32_t perHwThreadPrivateMemorySize, bool isInternal, MockImmutableData *mockKernelImmData,
-                                    std::initializer_list<ZebinTestData::appendElfAdditionalSection> additionalSections = {});
+                                    std::initializer_list<ZebinTestData::AppendElfAdditionalSection> additionalSections = {});
 
     void createKernel(MockKernel *kernel);
 

level_zero/core/test/unit_tests/sources/cmdqueue/test_cmdqueue_2.cpp

@@ -723,7 +723,7 @@ TEST_F(CommandQueueInitTests, givenMultipleSubDevicesWhenInitializingThenAllocat
         }
     }
 
-    EXPECT_EQ(static_cast<uint32_t>(CommandQueueImp::CommandBufferManager::BUFFER_ALLOCATION::COUNT), cmdBufferAllocationsFound);
+    EXPECT_EQ(static_cast<uint32_t>(CommandQueueImp::CommandBufferManager::BufferAllocation::count), cmdBufferAllocationsFound);
 
     commandQueue->destroy();
 }

level_zero/core/test/unit_tests/sources/debugger/test_module_with_debug.cpp

@@ -614,7 +614,7 @@ HWTEST_F(NotifyModuleLoadTest, givenDebuggingEnabledWhenModuleIsCreatedAndFullyL
     auto debugger = MockDebuggerL0Hw<FamilyType>::allocate(neoDevice);
     neoDevice->getExecutionEnvironment()->rootDeviceEnvironments[0]->debugger.reset(debugger);
 
-    auto elfAdditionalSections = {ZebinTestData::appendElfAdditionalSection::constant}; // for const surface allocation copy
+    auto elfAdditionalSections = {ZebinTestData::AppendElfAdditionalSection::constant}; // for const surface allocation copy
     auto zebinData = std::make_unique<ZebinTestData::ZebinWithL0TestCommonModule>(device->getHwInfo(), elfAdditionalSections);
     const auto &src = zebinData->storage;
 

level_zero/core/test/unit_tests/sources/kernel/test_kernel.cpp

@@ -719,7 +719,7 @@ TEST_F(KernelImmutableDataIsaCopyTests, whenUserKernelIsCreatedThenIsaIsCopiedWh
 
     std::unique_ptr<MockImmutableData> mockKernelImmData = std::make_unique<MockImmutableData>(perHwThreadPrivateMemorySizeRequested);
 
-    auto additionalSections = {ZebinTestData::appendElfAdditionalSection::global};
+    auto additionalSections = {ZebinTestData::AppendElfAdditionalSection::global};
     createModuleFromMockBinary(perHwThreadPrivateMemorySizeRequested, isInternal, mockKernelImmData.get(), additionalSections);
 
     size_t copyForGlobalSurface = 1u;
@@ -799,7 +799,7 @@ TEST_F(KernelImmutableDataTests, givenInternalModuleWhenKernelIsCreatedThenIsaIs
     size_t previouscopyMemoryToAllocationCalledTimes =
         mockMemoryManager->copyMemoryToAllocationCalledTimes;
 
-    auto additionalSections = {ZebinTestData::appendElfAdditionalSection::global};
+    auto additionalSections = {ZebinTestData::AppendElfAdditionalSection::global};
     createModuleFromMockBinary(perHwThreadPrivateMemorySizeRequested, isInternal, mockKernelImmData.get(), additionalSections);
 
     size_t copyForGlobalSurface = 1u;