skeleton for PDU temp

Signed-off-by: Harper, Jason M <[email protected]>

Author: harp-intel

cmd/telemetry/telemetry.go

@@ -294,15 +294,14 @@ func runCmd(cmd *cobra.Command, args []string) error {
 		tableNames = append(tableNames, report.GaudiTelemetryTableName)
 	}
 	// hidden feature - PDU telemetry, only enabled when four environment variables are set
-	// PERFSPECT_PDU_HOST, PERFSPECT_PDU_USER, PERFSPECT_PDU_PASSWORD, PERFSPECT_PDU_OUTLET
-	// pduHost := os.Getenv("PERFSPECT_PDU_HOST")
-	// pduUser := os.Getenv("PERFSPECT_PDU_USER")
-	// pduPassword := os.Getenv("PERFSPECT_PDU_PASSWORD")
-	// pduOutlet := os.Getenv("PERFSPECT_PDU_OUTLET")
-	// if pduHost != "" && pduUser != "" && pduPassword != "" && pduOutlet != "" {
-	// 	slog.Info("PDU telemetry enabled", slog.String("host", pduHost), slog.String("outlet", pduOutlet))
-	// 	tableNames = append(tableNames, report.PDUTelemetryTableName)
-	// }
+	pduHost := os.Getenv("PERFSPECT_PDU_HOST")
+	pduUser := os.Getenv("PERFSPECT_PDU_USER")
+	pduPassword := os.Getenv("PERFSPECT_PDU_PASSWORD")
+	pduOutlet := os.Getenv("PERFSPECT_PDU_OUTLET")
+	if pduHost != "" && pduUser != "" && pduPassword != "" && pduOutlet != "" {
+		slog.Info("PDU telemetry enabled", slog.String("host", pduHost), slog.String("outlet", pduOutlet))
+		tableNames = append(tableNames, report.PDUTelemetryTableName)
+	}
 	// include telemetry summary table if all telemetry options are selected
 	var summaryFunc common.SummaryFunc
 	if flagAll {
@@ -322,10 +321,10 @@ func runCmd(cmd *cobra.Command, args []string) error {
 			"InstrMixPID":       strconv.Itoa(flagInstrMixPid),
 			"InstrMixFrequency": strconv.Itoa(flagInstrMixFrequency),
 			"GaudiHlsmiPath":    gaudiHlsmiPath,
-			// "PDUHost":           pduHost,
-			// "PDUUser":           pduUser,
-			// "PDUPassword":       pduPassword,
-			// "PDUOutlet":         pduOutlet,
+			"PDUHost":           pduHost,
+			"PDUUser":           pduUser,
+			"PDUPassword":       pduPassword,
+			"PDUOutlet":         pduOutlet,
 		},
 		TableNames:             tableNames,
 		SummaryFunc:            summaryFunc,

internal/report/render_html.go

@@ -1511,6 +1511,23 @@ func gaudiTelemetryTableHTMLRenderer(tableValues TableValues, targetName string)
 	return out
 }
 
+func pduTelemetryTableHTMLRenderer(tableValues TableValues, targetName string) string {
+	data := [][]float64{}
+	datasetNames := []string{}
+	chartConfig := chartTemplateStruct{
+		ID:            fmt.Sprintf("%s%d", tableValues.Name, util.RandUint(10000)),
+		XaxisText:     "Time",
+		YaxisText:     "Value",
+		TitleText:     "",
+		DisplayTitle:  "false",
+		DisplayLegend: "true",
+		AspectRatio:   "2",
+		SuggestedMin:  "0",
+		SuggestedMax:  "0",
+	}
+	return telemetryTableHTMLRenderer(tableValues, data, datasetNames, chartConfig)
+}
+
 func callStackFrequencyTableHTMLRenderer(tableValues TableValues, targetName string) string {
 	out := `<style>
 

internal/report/table_defs.go

@@ -130,6 +130,7 @@ const (
 	PowerTelemetryTableName                 = "Power Telemetry"
 	TemperatureTelemetryTableName           = "Temperature Telemetry"
 	GaudiTelemetryTableName                 = "Gaudi Telemetry"
+	PDUTelemetryTableName                   = "PDU Telemetry"
 	// config  table names
 	ConfigurationTableName = "Configuration"
 	// flamegraph table names
@@ -156,6 +157,7 @@ const (
 	PowerTelemetryMenuLabel                 = "Power"
 	TemperatureTelemetryMenuLabel           = "Temperature"
 	GaudiTelemetryMenuLabel                 = "Gaudi"
+	PDUTelemetryMenuLabel                   = "PDU"
 )
 
 const (
@@ -790,6 +792,15 @@ var tableDefinitions = map[string]TableDefinition{
 		NoDataFound:           "No Gaudi telemetry found. Gaudi devices and the hl-smi tool must be installed on the target system to collect Gaudi stats.",
 		FieldsFunc:            gaudiTelemetryTableValues,
 		HTMLTableRendererFunc: gaudiTelemetryTableHTMLRenderer},
+	PDUTelemetryTableName: {
+		Name:      PDUTelemetryTableName,
+		MenuLabel: PDUTelemetryMenuLabel,
+		HasRows:   true,
+		ScriptNames: []string{
+			script.PDUTelemetryScriptName,
+		},
+		FieldsFunc:            pduTelemetryTableValues,
+		HTMLTableRendererFunc: pduTelemetryTableHTMLRenderer},
 	//
 	// flamegraph tables
 	//
@@ -2756,6 +2767,10 @@ func gaudiTelemetryTableValues(outputs map[string]script.ScriptOutput) []Field {
 	return fields
 }
 
+func pduTelemetryTableValues(outputs map[string]script.ScriptOutput) []Field {
+	return []Field{}
+}
+
 func callStackFrequencyTableValues(outputs map[string]script.ScriptOutput) []Field {
 	fields := []Field{
 		{Name: "Native Stacks", Values: []string{nativeFoldedFromOutput(outputs)}},

internal/script/script_defs.go

@@ -116,6 +116,7 @@ const (
 	TurbostatTelemetryScriptName   = "turbostat telemetry"
 	InstructionTelemetryScriptName = "instruction telemetry"
 	GaudiTelemetryScriptName       = "gaudi telemetry"
+	PDUTelemetryScriptName         = "pdu telemetry"
 	// flamegraph scripts
 	CollapsedCallStacksScriptName = "collapsed call stacks"
 	// lock scripts
@@ -1324,6 +1325,12 @@ fi
 		Superuser: true,
 		NeedsKill: true,
 	},
+	PDUTelemetryScriptName: {
+		Name:           PDUTelemetryScriptName,
+		ScriptTemplate: ``,
+		Superuser:      false,
+		NeedsKill:      false,
+	},
 	// flamegraph scripts
 	CollapsedCallStacksScriptName: {
 		Name: CollapsedCallStacksScriptName,