Merge pull request #152 from intel/noinf

harp-intel · web-flow · commit 0f0d72b7b7cf · 2025-01-13T13:06:09.000-08:00
filter out infinite values in metrics summary
diff --git a/cmd/metrics/summary.go b/cmd/metrics/summary.go
@@ -223,7 +223,7 @@ func (m *metricsFromCSV) getStats() (stats map[string]metricStats, err error) {
 			distanceSquaredSum := 0.0
 			for _, row := range m.rows {
 				val := row.metrics[metricName]
-				if math.IsNaN(val) {
+				if math.IsNaN(val) || math.IsInf(val, 0) {
 					continue
 				}
 				distance := mean - val
@@ -312,7 +312,7 @@ func (m *metricsFromCSV) getHTML() (html string, err error) {
 			if rIdx == 0 {
 				firstTimestamp = row.timestamp
 			}
-			if math.IsNaN(row.metrics[tmpl.metricNames[archIndex]]) {
+			if math.IsNaN(row.metrics[tmpl.metricNames[archIndex]]) || math.IsInf(row.metrics[tmpl.metricNames[archIndex]], 0) {
 				continue
 			}
 			series = append(series, []float64{row.timestamp - firstTimestamp, row.metrics[tmpl.metricNames[archIndex]]})

Original file line number	Diff line number	Diff line change
`@@ -223,7 +223,7 @@ func (m *metricsFromCSV) getStats() (stats map[string]metricStats, err error) {`
`223`	`223`	`distanceSquaredSum := 0.0`
`224`	`224`	`for _, row := range m.rows {`
`225`	`225`	`val := row.metrics[metricName]`
`226`		`- if math.IsNaN(val) {`
	`226`	`+ if math.IsNaN(val) \|\| math.IsInf(val, 0) {`
`227`	`227`	`continue`
`228`	`228`	`}`
`229`	`229`	`distance := mean - val`
`@@ -312,7 +312,7 @@ func (m *metricsFromCSV) getHTML() (html string, err error) {`
`312`	`312`	`if rIdx == 0 {`
`313`	`313`	`firstTimestamp = row.timestamp`
`314`	`314`	`}`
`315`		`- if math.IsNaN(row.metrics[tmpl.metricNames[archIndex]]) {`
	`315`	`+ if math.IsNaN(row.metrics[tmpl.metricNames[archIndex]]) \|\| math.IsInf(row.metrics[tmpl.metricNames[archIndex]], 0) {`
`316`	`316`	`continue`
`317`	`317`	`}`
`318`	`318`	`series = append(series, []float64{row.timestamp - firstTimestamp, row.metrics[tmpl.metricNames[archIndex]]})`