Fix cargo clippy when spdm_attestation feature is enabled

And add cargo clippy check with spdm_attestation enabled in CI.

Author: IntelCaisui

.github/workflows/format.yml

@@ -55,7 +55,7 @@ jobs:
       - name: Run rust-clippy for result collection
         run:
           cargo clippy 
-          --features stack-guard,virtio-vsock,virtio-serial,vmcall-interrupt
+          --features stack-guard,virtio-vsock,virtio-serial,vmcall-interrupt,spdm_attestation
           --message-format=json | clippy-sarif | tee rust-clippy-results.sarif | sarif-fmt
         continue-on-error: true
 
@@ -66,7 +66,7 @@ jobs:
           wait-for-processing: true
 
       - name: Run rust-clippy
-        run: cargo clippy --features stack-guard,virtio-vsock,virtio-serial,vmcall-interrupt
+        run: cargo clippy --features stack-guard,virtio-vsock,virtio-serial,vmcall-interrupt,spdm_attestation
 
   rustfmt:
     name: Format

src/attestation/src/ghci.rs

@@ -46,7 +46,7 @@ pub extern "C" fn servtd_get_quote(tdquote_req_buf: *mut c_void, len: u64) -> i3
 
     let _ = tdvmcall_get_quote(shared.as_mut_bytes()).map_err(|e| {
         log::error!("tdvmcall_get_quote failed with error: {:?}\n", e);
-        return AttestLibError::QuoteFailure as i32;
+        AttestLibError::QuoteFailure as i32
     });
 
     if let Err(err) = wait_for_quote_completion(notify_registered, shared.as_bytes()) {
@@ -69,9 +69,9 @@ fn set_vmm_notification() -> bool {
         NOTIFY_VECTOR as usize,
         InterruptCallback::new(vmm_notification),
     )
-    .map_err(|e| {
+    .map_err(|_e| {
         log::error!("Fail to setup interrupt callback for VMM notify\n");
-        return false;
+        false
     });
 
     // Setup event notifier