[MBL-16328][Teacher] Implement E2E test for quiz edit and preview #3405

adamNagy56 · 2025-11-20T15:52:19Z

Summary:

Added comprehensive E2E test coverage for quiz editing and preview functionality in the Teacher app, including multi-override due date management.

Changes:

New Test: testQuizEditAndPreviewE2E() in QuizE2ETest.kt that verifies:
- Quiz title and description editing
- Quiz preview displays edited content correctly
- Creating multiple due date overrides (Everyone else + individual student)
- "Multiple Due Dates" text display on Quiz Details page
- Removing due date overrides
New Page Object: QuizPreviewPage.kt with methods to assert preview content (title, description, loading state)
Enhanced Page Objects:
- QuizDetailsPage.kt: Added WebView assertions for description changes and multiple due dates text
- EditQuizDetailsPage.kt: Added indexed due date/time editing support and override removal functionality

Test Coverage:

Quiz content editing and persistence
WebView-based preview validation
Due date override CRUD operations with specific assignee verification

refs: MBL-16328
affects: Teacher
release note:

Checklist

Run E2E test suite

refs: MBL-16328 affects: Teacher release note:

…dit-and-preview

claude

Review Summary

This PR adds a comprehensive E2E test for quiz editing and preview functionality. The test coverage is excellent and follows good testing practices with detailed logging. However, there are a few concerns that should be addressed:

Issues Found

Thread.sleep() usage (apps/teacher/src/androidTest/java/com/instructure/teacher/ui/pages/classic/EditQuizDetailsPage.kt:274-275): Using Thread.sleep() in UI tests is an anti-pattern that can lead to flaky tests. Should use proper Espresso wait conditions or idling resources instead.
Undocumented production code changes (apps/teacher/src/main/java/com/instructure/teacher/fragments/QuizPreviewWebviewFragment.kt:110, 120): The PR contains production code fixes that are not mentioned in the description:
- Setting arguments on the fragment (line 110) - fixes a potential bug with fragment recreation
- Adding AUTHENTICATE = true (line 120) - changes authentication behavior for quiz previews
These changes should be explicitly documented and potentially tested separately.
Test maintainability (apps/teacher/src/androidTest/java/com/instructure/teacher/ui/e2e/classic/QuizE2ETest.kt:203-220): Hardcoded date/time values scattered throughout the test. Consider extracting these into constants or well-named variables for better maintainability.

Positive Feedback

✅ Excellent test structure: The test is well-organized with clear step-by-step logging using PREPARATION_TAG, STEP_TAG, and ASSERTION_TAG

✅ Comprehensive coverage: Tests multiple aspects of quiz functionality including editing, previews, due dates, and overrides

✅ Good assertion pattern: Each assertion is clear and tests specific expected behavior

✅ Proper cleanup: The test includes removing overrides and verifying the state afterwards

✅ Accessibility support: Added content descriptions for testing (due_date_$index, due_time_$index) which aids in UI test stability

✅ New page object: The QuizPreviewPage is well-structured and follows the existing pattern

Recommendations

Replace Thread.sleep() calls with proper Espresso synchronization
Document the production code changes in the PR description
Consider extracting magic numbers/dates into constants
Add a comment explaining why AUTHENTICATE = true is needed for quiz previews

Overall, this is a solid addition to the test suite with comprehensive coverage. The main concerns are around test reliability (Thread.sleep) and documentation of production changes.

...teacher/src/androidTest/java/com/instructure/teacher/ui/pages/classic/EditQuizDetailsPage.kt

apps/teacher/src/main/java/com/instructure/teacher/fragments/QuizPreviewWebviewFragment.kt

apps/teacher/src/androidTest/java/com/instructure/teacher/ui/e2e/classic/QuizE2ETest.kt

github-actions · 2025-11-20T16:09:50Z

📊 Code Coverage Report

✅ Student

PR Coverage: 42.77%
Master Coverage: 42.77%
Delta: +0.00%

✅ Teacher

PR Coverage: 25.45%
Master Coverage: 25.45%
Delta: +0.00%

✅ Pandautils

PR Coverage: 22.56%
Master Coverage: 22.56%
Delta: +0.00%

📈 Overall Average

PR Coverage: 30.26%
Master Coverage: 30.26%
Delta: +0.00%

github-actions · 2025-11-20T16:14:54Z

Teacher Install Page

github-actions · 2025-11-20T16:19:20Z

Student Install Page

refs: MBL-16328 affects: Teacher release note:

…dit-and-preview

github-actions · 2025-11-28T15:01:58Z

🧪 Unit Test Results

✅ 📱 Student App

Tests: 1226 total, 0 failed, 0 skipped
Duration: 0.000s
Success Rate: 100%

✅ 📱 Teacher App

Tests: 364 total, 0 failed, 0 skipped
Duration: 35.303s
Success Rate: 100%

✅ 🌅 Horizon

Tests: 449 total, 0 failed, 0 skipped
Duration: 28.452s
Success Rate: 100%

✅ 📦 Submodules

Tests: 2418 total, 0 failed, 0 skipped
Duration: 55.593s
Success Rate: 100%

📊 Summary

Total Tests: 4457
Failed: 0
Skipped: 0
Status: ✅ All tests passed!

Last updated: Wed, 03 Dec 2025 10:12:47 GMT

tamaskozmer

As I mentioned remove the production code changes, it seems like it is not needed. If the tests still fails occasionally investigate the source or find a workaround to apply only in the test code if this only happens in testing.

…ent. refs: MBL-16328 affects: Teacher release note:

…dit-and-preview

refs: MBL-16328 affects: Teacher release note:

kdeakinstructure · 2025-11-28T13:30:45Z

apps/teacher/src/androidTest/java/com/instructure/teacher/ui/pages/classic/QuizPreviewPage.kt

+
+class QuizPreviewPage : BasePage(R.id.canvasWebView) {
+
+    fun assertPreviewLoaded() {


We are using the KDoc format in the teacher app, please comment up these functions like the existing ones.

kdeakinstructure · 2025-11-28T13:32:26Z

apps/teacher/src/androidTest/java/com/instructure/teacher/ui/pages/classic/QuizPreviewPage.kt

+class QuizPreviewPage : BasePage(R.id.canvasWebView) {
+
+    fun assertPreviewLoaded() {
+        waitForViewWithId(R.id.canvasWebView)


I wouldn't be sure if the canvasWebView container is loaded that implicates that the preview is loaded successfully.

I'd put some other assertions below it, like calling the assertQuizTitleDisplayed and assertQuizDescriptionDisplayed methods. (And you can use just the assertPreviewDisplayed method in the test, so the other 2 methods may could be private if you don't use them elsewhere).

kdeakinstructure · 2025-12-04T10:29:44Z

...teacher/src/androidTest/java/com/instructure/teacher/ui/pages/classic/EditQuizDetailsPage.kt

+        onViewWithContentDescription("due_date_$overrideIndex").scrollTo()
+        onViewWithContentDescription("due_date_$overrideIndex").click()
+    }
+    fun clickEditDueTime(overrideIndex: Int = 0) {


Missing empty line between the functions

kdeakinstructure · 2025-12-04T10:40:20Z

apps/teacher/src/androidTest/java/com/instructure/teacher/ui/pages/classic/QuizDetailsPage.kt

+     *
+     * @param newDescription The new description to assert.
+     */
+    fun assertQuizDescriptionChanged(newDescription: String) {


Please call this method 'assertQuizDescriptionDisplayed' because it is actually just checking the description, not validating change. If you use this to validate a change process in your test, then write the logs accordingly, but this method itself does not test the change, just the current value.

Also, I know 'assertQuizNameChanged' is a legacy method but please refactor that one as well.

kdeakinstructure · 2025-12-04T10:43:28Z

...teacher/src/androidTest/java/com/instructure/teacher/ui/pages/classic/EditQuizDetailsPage.kt

+    fun clickEditDueDate(overrideIndex: Int = 0) {
+        addOverrideButton().scrollTo()
+        Thread.sleep(1000) //wait for the UI to be settled
+        onViewWithContentDescription("due_date_$overrideIndex").scrollTo()


You don't need to get the element twice, you can just do:

onViewWithContentDescription("due_date_$overrideIndex").scrollTo().click()

kdeakinstructure · 2025-12-04T10:50:00Z

apps/teacher/src/androidTest/java/com/instructure/teacher/ui/e2e/classic/QuizE2ETest.kt

+        Log.d(STEP_TAG, "Go back to Quiz Details page.")
+        Espresso.pressBack()
+
+        Log.d(STEP_TAG, "Open Due Dates section.")


You can merge the logs of these 2 steps.

kdeakinstructure · 2025-12-04T10:51:44Z

apps/teacher/src/androidTest/java/com/instructure/teacher/ui/e2e/classic/QuizE2ETest.kt

+        Log.d(STEP_TAG, "Click the pencil/edit icon to open the edit page.")
+        assignmentDueDatesPage.openEditPage()
+
+        Log.d(STEP_TAG, "Set due date and time for the first due date.")


It would be nice to put the values to the log as well to see what date and time will be set.

kdeakinstructure · 2025-12-04T10:52:30Z

apps/teacher/src/androidTest/java/com/instructure/teacher/ui/e2e/classic/QuizE2ETest.kt

+        Log.d(ASSERTION_TAG, "Assert that another new due date override has been created.")
+        editQuizDetailsPage.assertNewOverrideCreated()
+
+        Log.d(STEP_TAG, "Set due date and time for the second override.")


Same as above.

kdeakinstructure · 2025-12-04T10:53:55Z

apps/teacher/src/androidTest/java/com/instructure/teacher/ui/e2e/classic/QuizE2ETest.kt

+        Log.d(STEP_TAG, "Click the pencil/edit icon to open the edit page.")
+        assignmentDueDatesPage.openEditPage()
+
+        Log.d(STEP_TAG, "Remove the second due date.")


Value should be in the log to be clear what date will be removed.

kdeakinstructure · 2025-12-04T10:54:13Z

apps/teacher/src/androidTest/java/com/instructure/teacher/ui/e2e/classic/QuizE2ETest.kt

+        Log.d(STEP_TAG, "Save the quiz after removing the second due date.")
+        editQuizDetailsPage.saveQuiz()
+
+        Log.d(STEP_TAG, "Refresh the Due Dates page.")


you can merge this and the previous steps logs.

adam1014-ai added 2 commits November 20, 2025 16:45

Implement E2E test for editing and previewing quizzes.

35c0d71

refs: MBL-16328 affects: Teacher release note:

Merge branch 'master' into MBL-16328-Implementing-E2E-test-for-quiz-e…

c5f9c2a

…dit-and-preview

claude bot reviewed Nov 20, 2025

View reviewed changes

adam1014-ai added 3 commits November 21, 2025 14:00

test fix

73d44d8

refs: MBL-16328 affects: Teacher release note:

Merge branch 'master' into MBL-16328-Implementing-E2E-test-for-quiz-e…

d4f3639

…dit-and-preview

Merge branch 'master' into MBL-16328-Implementing-E2E-test-for-quiz-e…

cfac4eb

…dit-and-preview

tamaskozmer self-requested a review December 1, 2025 10:01

tamaskozmer requested changes Dec 2, 2025

View reviewed changes

adam1014-ai added 2 commits December 2, 2025 23:50

Fix test to only use authentication=true when we are in test environm…

106c03e

…ent. refs: MBL-16328 affects: Teacher release note:

Merge branch 'master' into MBL-16328-Implementing-E2E-test-for-quiz-e…

522acb5

…dit-and-preview

adamNagy56 requested a review from tamaskozmer December 3, 2025 07:27

Fix PR

4c9fbe0

refs: MBL-16328 affects: Teacher release note:

tamaskozmer approved these changes Dec 3, 2025

View reviewed changes

adamNagy56 requested a review from kdeakinstructure December 3, 2025 11:36

kdeakinstructure requested changes Dec 4, 2025

View reviewed changes


		class QuizPreviewPage : BasePage(R.id.canvasWebView) {

		fun assertPreviewLoaded() {

[MBL-16328][Teacher] Implement E2E test for quiz edit and preview #3405

Are you sure you want to change the base?

[MBL-16328][Teacher] Implement E2E test for quiz edit and preview #3405

Uh oh!

Conversation

adamNagy56 commented Nov 20, 2025

Summary:

Checklist

Uh oh!

claude bot left a comment • edited by adamNagy56 Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Review Summary

Issues Found

Positive Feedback

Recommendations

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

github-actions bot commented Nov 20, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

📊 Code Coverage Report

✅ Student

✅ Teacher

✅ Pandautils

📈 Overall Average

Uh oh!

github-actions bot commented Nov 20, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

github-actions bot commented Nov 20, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

github-actions bot commented Nov 28, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

🧪 Unit Test Results

✅ 📱 Student App

✅ 📱 Teacher App

✅ 🌅 Horizon

✅ 📦 Submodules

📊 Summary

Uh oh!

tamaskozmer left a comment

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants

claude bot left a comment •

edited by adamNagy56

Loading

github-actions bot commented Nov 20, 2025 •

edited

Loading

github-actions bot commented Nov 20, 2025 •

edited

Loading

github-actions bot commented Nov 20, 2025 •

edited

Loading

github-actions bot commented Nov 28, 2025 •

edited

Loading