Skip to content

Commit 305fc16

Browse files
authored
Merge pull request #17 from inspector-apm/symfony_v4_compatibility
Symfony v4 compatibility
2 parents 017e466 + 89896d1 commit 305fc16

File tree

3 files changed

+21
-13
lines changed

3 files changed

+21
-13
lines changed

composer.json

Lines changed: 9 additions & 9 deletions
Original file line numberDiff line numberDiff line change
@@ -18,18 +18,18 @@
1818
"require": {
1919
"php": ">=7.2.5",
2020
"inspector-apm/inspector-php": "^3.6",
21-
"symfony/config": "^5.2",
22-
"symfony/dependency-injection": "^5.2",
23-
"symfony/http-kernel": "^5.2",
24-
"symfony/event-dispatcher": "^5.2",
25-
"symfony/console": "^5.2",
26-
"symfony/framework-bundle": "^5.2",
27-
"symfony/yaml": "^5.2",
28-
"symfony/security-bundle": "^5.2"
21+
"symfony/config": "^4.4|^5.2",
22+
"symfony/dependency-injection": "^4.4|^5.2",
23+
"symfony/http-kernel": "^4.4|^5.2",
24+
"symfony/event-dispatcher": "^4.4|^5.2",
25+
"symfony/console": "^4.4|^5.2",
26+
"symfony/framework-bundle": "^4.4|^5.2",
27+
"symfony/yaml": "^4.4|^5.2",
28+
"symfony/security-bundle": "^4.4|^5.2"
2929
},
3030
"require-dev": {
3131
"doctrine/doctrine-bundle": "^2.4",
32-
"symfony/framework-bundle": "^5.3.2",
32+
"symfony/framework-bundle": "^4.4|^5.2",
3333
"phpunit/phpunit": "^9.5",
3434
"symfony/test-pack": "^1.0"
3535
},

src/DependencyInjection/Compiler/DoctrineDBALCompilerPass.php

Lines changed: 8 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -7,6 +7,7 @@
77
use Doctrine\DBAL\Logging\LoggerChain;
88
use Doctrine\DBAL\SQLParserUtils;
99
use Inspector\Symfony\Bundle\Inspectable\Doctrine\DBAL\Logging\InspectableSQLLogger;
10+
use OutOfBoundsException;
1011
use Symfony\Component\DependencyInjection\Compiler\CompilerPassInterface;
1112
use Symfony\Component\DependencyInjection\ContainerBuilder;
1213
use Symfony\Component\DependencyInjection\Definition;
@@ -51,9 +52,13 @@ public function process(ContainerBuilder $container)
5152
// doctrine/dbal < 2.10.0
5253
$chainLogger->addMethodCall('addLogger', [$logger]);
5354
} else {
54-
$loggers = $chainLogger->getArgument(0);
55-
array_push($loggers, $logger);
56-
$chainLogger->replaceArgument(0, $loggers);
55+
try {
56+
$loggers = $chainLogger->getArgument(0);
57+
array_push($loggers, $logger);
58+
$chainLogger->replaceArgument(0, $loggers);
59+
} catch (OutOfBoundsException $exception) {
60+
$chainLogger->addArgument([$logger]);
61+
}
5762
}
5863

5964
$container->getDefinition(sprintf('doctrine.dbal.%s_connection.configuration', $name))->addMethodCall('setSQLLogger', [$logger]);

src/Listeners/ConsoleEventsSubscriber.php

Lines changed: 4 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -42,9 +42,12 @@ public static function getSubscribedEvents(): array
4242
ConsoleEvents::COMMAND => ['onConsoleStart', 9999],
4343
ConsoleEvents::ERROR => ['onConsoleError', 128],
4444
ConsoleEvents::TERMINATE => ['onConsoleTerminate', 0],
45-
ConsoleEvents::SIGNAL => ['onConsoleSignal', 0],
4645
];
4746

47+
if (defined('Symfony\Component\Console::CONSOLE_SIGNAL')) {
48+
$listeners[ConsoleEvents::SIGNAL] = ['onConsoleSignal', 0];
49+
}
50+
4851
return $listeners;
4952
}
5053

0 commit comments

Comments
 (0)