feat: add support for clickhouse as the engine #255
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add support for clickhouse as the engine for for arrays and custom types specified in proto/types/types.proto file
chinmayb
reviewed
Dec 15, 2023
|
|
||
| if strings.EqualFold(params["engine"], "postgres") { | ||
| builder.dbEngine = ENGINE_POSTGRES | ||
| } else if strings.EqualFold(params["engine"], "clickhouse") { |
Contributor
There was a problem hiding this comment.
Since now we're introducing a new engine, its high time we modularize it by refactoring it. May be we can define an interface & include the methods which are different for different engines.
Author
There was a problem hiding this comment.
@chinmayb Should i start working on this new refactoring you talked about?
Author
There was a problem hiding this comment.
sure, i will open a new PR when i'm done with that
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add support for clickhouse as the engine for arrays and custom types specified in proto/types/types.proto file