chore: optimize webhook log send (#30)

Co-authored-by: hardy <[email protected]>

Author: luohoufu

api/app/v1/applicationdefinition_types.go

@@ -184,6 +184,11 @@ type ApplicationDefinitionStatus struct {
 	// +optional
 	SuspendedReplicas map[string]int32 `json:"suspendedReplicas,omitempty"`
 
+	// LastChangeID records the last change ID that was processed and sent to the webhook.
+	// This is used to avoid sending duplicate webhook events for the same change ID.
+	// +optional
+	LastChangeID string `json:"lastChangeID,omitempty"`
+
 	// Annotations holds additional metadata annotations for the application definition.
 	Annotations map[string]string `json:"annotations,omitempty"`
 }

config/crd/bases/infini.cloud_applicationdefinitions.yaml

@@ -229,6 +229,11 @@ spec:
                 x-kubernetes-list-map-keys:
                 - type
                 x-kubernetes-list-type: map
+              lastChangeID:
+                description: |-
+                  LastChangeID records the last change ID that was processed and sent to the webhook.
+                  This is used to avoid sending duplicate webhook events for the same change ID.
+                type: string
               observedGeneration:
                 description: ObservedGeneration reflects the generation of the ApplicationDefinition
                   spec that was last processed by the controller.

internal/controller/app/applicationdefinition_controller.go

@@ -223,6 +223,14 @@ func (r *ApplicationDefinitionReconciler) Reconcile(ctx context.Context, req ctr
 	// 7. Determine final phase and update status if needed
 	r.determineFinalPhase(state, allReady)                                              // Update phase based on errors and readiness
 	state.appDef.Status.Components = mapToSliceComponentStatus(state.componentStatuses) // Update components status list
+
+	// Update LastChangeID in status if reconciliation was successful
+	if allReady && state.firstError == nil {
+		if changeID, exists := state.appDef.Annotations[appv1.AnnotationChangeID]; exists && changeID != "" {
+			state.appDef.Status.LastChangeID = changeID
+		}
+	}
+
 	_, statusUpdateErr := r.updateStatusIfNeeded(ctx, state.appDef, state.originalStatus)
 	if statusUpdateErr != nil {
 		// Distinguish between conflicts (expected, will retry) and other errors
@@ -811,7 +819,8 @@ func (r *ApplicationDefinitionReconciler) updateStatusIfNeeded(ctx context.Conte
 	if currentApp.Status.Phase == originalStatus.Phase &&
 		conditionsEqual(currentApp.Status.Conditions, originalStatus.Conditions) &&
 		componentStatusesEqual(currentApp.Status.Components, originalStatus.Components) &&
-		currentApp.Status.ObservedGeneration == originalStatus.ObservedGeneration {
+		currentApp.Status.ObservedGeneration == originalStatus.ObservedGeneration &&
+		currentApp.Status.LastChangeID == originalStatus.LastChangeID {
 		logger.V(1).Info("Status unchanged, skipping update.")
 		return false, nil // No changes detected
 	}
@@ -1045,6 +1054,14 @@ func (r *ApplicationDefinitionReconciler) recordEvent(app *appv1.ApplicationDefi
 	recorder := r.getEventRecorder(app)
 
 	if wr, ok := recorder.(*webrecorder.WebhookEventRecorder); ok {
+		// Get current change ID from annotations
+		currentChangeID := app.Annotations[appv1.AnnotationChangeID]
+
+		// Check if this change ID has already been processed
+		if app.Status.LastChangeID == currentChangeID {
+			// Skip sending duplicate webhook event for the same change ID
+			return
+		}
 		annotations := map[string]string{
 			webrecorder.PhaseKey:  phase,
 			webrecorder.StatusKey: status,
@@ -1061,6 +1078,14 @@ func (r *ApplicationDefinitionReconciler) recordEventf(app *appv1.ApplicationDef
 	recorder := r.getEventRecorder(app)
 
 	if wr, ok := recorder.(*webrecorder.WebhookEventRecorder); ok {
+		// Get current change ID from annotations
+		currentChangeID := app.Annotations[appv1.AnnotationChangeID]
+
+		// Check if this change ID has already been processed
+		if app.Status.LastChangeID == currentChangeID {
+			// Skip sending duplicate webhook event for the same change ID
+			return
+		}
 		annotations := map[string]string{
 			webrecorder.PhaseKey:  phase,
 			webrecorder.StatusKey: status,