Things that should be in 1.0.0 release - PLEASE FEEL FREE TO CONTRIBUTE IF YOU FEEL SOMETHING IS MISSING OR WRONG

[Mokto]

Hi everyone,

With the work I've done/accomplished this week-end, I think we are close to a major 1.0.0 release.
I would like to make a Todo List of what is needed for this final release.

Please feel free to contribute and tell me what's wrong/missing in this plugin.

I'll update this post according to your advice. Thanks !!

TODO in 1.0.0

• Subscriptions ready Subscriptions ready #40
• Add unit tests (@vermiculite Testing #38)
• Test on a production app [95 %]
• createContainer Meteor 1.3

TODO next

• Meteor.collection(collectionName).update should work offline and not just wait that the connection is live again
• [Meteor.loginWith[Provider]] : create submodules like react-native-meteor-facebook-login or something like that because native code is needed
• Save data to cache to make apps work offline Is it possible to save data to cache after subscribe? #36

[radiegtya]

Meteor.ddp.on("change") etc still not working on mine. Can you give some example about implementing that?

[balibou]

Hello, for Meteor.loginWith[Provider], maybe with a Oauth authentication like https://github.com/FranciscoVictor/accounts-facebook-ddp ?

@Mokto @spencercarli

[spencercarli]

I personally like the way that meteor does Oauth - more of an opt-in than baked in out of the box.

What I found when writing this Google Oauth tutorial is that there are a lot of moving parts on both the meteor side and RN side (especially configuration on the RN side).

Maybe it would be better to write docs/guides/tutorials for this and link to them in the README? Can we build extensions off of this npm package to enable oauth? i.e. react-native-meteor-oauth-google

[Mokto]

@radiegtya can you please create an issue regarding this ? It is not appropriate here.

@balibou The problem is that we have to add native code to this plugin event for users who don't use oauth signin.

@spencercarli I do not know yet what to do. There are 2 possibilities in my opinion :

1. Do what you say, it could be really nice to add plugins to extend features. In this case maybe we should move FSCollection to another plugin called react-native-meteor-collectionfs. Or just in case native code is needed. What do you think ?

2. Or maybe we should just call login method with credential token and credential secret and let each user do the work to get these credentials.

I do not know yet ^^

[radiegtya]

@Mokto : ok I'll 👍

[spencercarli]

@Mokto I would rather go the first route - put as much work as possible on the extension packages rather than in application code. I've found with OAuth there are a ton of ways to mess it up and I would love to have one "right" way to do it.

[Mokto]

Ok, I'll go for first solution then. What do you think about plugins that don't need native code ? Shall I include them in this plugin ?

[spencercarli]

That's an interesting one - if it's in a different package then it can be released independently of the entire react-native-meteor package but then it's an additional repo to manage...

I guess it goes to the whole debate we often see in the Meteor community. Is it worth it to be a "core" package or should we split it out to more of a community type package?

I've offered no solutions, simply more questions haha

[Mokto]

Ok,

CollectionFS seems to be pretty important to me so I'll let it in this package. I'll think about it for other packages.

[radiegtya]

What will you do with collectionFS @Mokto? You want a complete one (saving data to gridfs/filesystem/s3, fetch the data, and modify the data) or you just want a part of it? This is interesting, ofc if you can implement it with combination of the popular react-native-image-picker

[Mokto]

No I want the full CollectionFS !

I have done what is needed to read data (this is more important to me) but eventually I'll add something to upload photo (by the way, I think it is already working, I just did not try yet).

React-native-image-picker sends base64 back, so the only thing that matters is to do Meteor.collection('images').insert(base64ImageData)

[radiegtya]

yeah it's working. I have tried 3 days a go lol. But video cannot be saved because it doesn't return base64Data on react-native-image-picker. I can't successfully convert the response.uri callback to base64 manually for video. Plus taken picture (not from camera roll) but directly using camera, the base64 file able to be saved to collectionFS, but it cannot be shown (on react native only) but the link able to be opened (very strange behaviour).

Dunno if it's appropriate to talk here. But if you can help me, it will be cool and ofc can be used to be added to Readme working example

[Mokto]

https://github.com/facebook/react-native-fbsdk/tree/release-0.1.0-alpha just released, looking into it when I get time available.

[philohelp]

Just wanted to say many thanks for the great project. I hope Ill be able to help as soon as I get better at all this.