Feat: basic auth support for calendar (optional) #363
Conversation
|
Are we waiting for that person you asked to test this? |
The code should be fine, at least not break anything. Feel free to merge if it looks ok to you :) |
JW-CH
force-pushed
the
dev/jw/calendarauth
branch
from
0caf4a8 to
cecb3b4
Compare
| var appointments = new List<IAppointment>(); | ||
|
|
||
| var icals = await GetCalendars(_serverSettings.Webcalendars); | ||
| List<(string? auth, string url)> cals = _serverSettings.Webcalendars.Select(x => x.Contains(';') ? (x.Split(';')[0], x.Split(';')[1]) : (null, x.ToString())).ToList(); |
There was a problem hiding this comment.
I would suggest that you use the standard auth formatting in URLs: https://<user>:<pass>@host/path, rather that semicolon delimited.
|
I just tried the dev/jw/calendarauth branch and can confirm that using an ics from Baikal CalDAV works fine. Here an example of the env (redacted): Webcalendars="user:password;https://baikal.mydomain.tld/dav.php/calendars/user/default?export" The URL returns directly the .ics file (In case you wonder why there isn't a .ics in the path 😃 ) Looking forward for it to get merged. |
Closes #281