Allowed nullable type declarations for method parameters across the codebase

Author: MateuszKolankowski

phpstan-baseline.neon

@@ -588,18 +588,6 @@ parameters:
 			count: 1
 			path: src/lib/Gateway/EndpointResolver/NativeEndpointResolver.php
 
-		-
-			message: '#^Method Ibexa\\Solr\\Gateway\\HttpClient\\Stream\:\:getResponseMessage\(\) has parameter \$method with no type specified\.$#'
-			identifier: missingType.parameter
-			count: 1
-			path: src/lib/Gateway/HttpClient/Stream.php
-
-		-
-			message: '#^Method Ibexa\\Solr\\Gateway\\HttpClient\\Stream\:\:getResponseMessage\(\) has parameter \$path with no type specified\.$#'
-			identifier: missingType.parameter
-			count: 1
-			path: src/lib/Gateway/HttpClient/Stream.php
-
 		-
 			message: '#^Method Ibexa\\Solr\\Gateway\\Message\:\:__construct\(\) has parameter \$headers with no value type specified in iterable type array\.$#'
 			identifier: missingType.iterableValue

src/lib/Gateway/HttpClient.php

@@ -11,14 +11,7 @@
  */
 interface HttpClient
 {
-    /**
-     * @param string $method
-     * @param \Ibexa\Solr\Gateway\Endpoint $endpoint
-     * @param string $path
-     *
-     * @return \Ibexa\Solr\Gateway\Message
-     */
-    public function request($method, Endpoint $endpoint, $path, ?Message $message = null);
+    public function request(string $method, Endpoint $endpoint, string $path, ?Message $message = null): Message;
 }
 
 class_alias(HttpClient::class, 'EzSystems\EzPlatformSolrSearchEngine\Gateway\HttpClient');

src/lib/Gateway/HttpClient/Stream.php

@@ -40,11 +40,7 @@ public function __construct(HttpClientInterface $client, int $timeout = 10)
         $this->setLogger(new NullLogger());
     }
 
-    /**
-     * @param string $method
-     * @param string $path
-     */
-    public function request($method, Endpoint $endpoint, $path, ?Message $message = null): Message
+    public function request(string $method, Endpoint $endpoint, string $path, ?Message $message = null): Message
     {
         $message = $message ?? new Message();
 
@@ -67,9 +63,9 @@ public function request($method, Endpoint $endpoint, $path, ?Message $message =
      * @throws \Symfony\Contracts\HttpClient\Exception\TransportExceptionInterface
      */
     private function getResponseMessage(
-        $method,
+        string $method,
         Endpoint $endpoint,
-        $path,
+        string $path,
         Message $message
     ): Message {
         if ($endpoint->user !== null) {

src/lib/Query/Common/CriterionVisitor/Aggregate.php

@@ -53,15 +53,9 @@ public function canVisit(Criterion $criterion)
     }
 
     /**
-     * Map field value to a proper Solr representation.
-     *
      * @throws \Ibexa\Contracts\Core\Repository\Exceptions\NotImplementedException
-     *
-     * @param \Ibexa\Contracts\Solr\Query\CriterionVisitor $subVisitor
-     *
-     * @return string
      */
-    public function visit(Criterion $criterion, ?CriterionVisitor $subVisitor = null)
+    public function visit(Criterion $criterion, ?CriterionVisitor $subVisitor = null): string
     {
         foreach ($this->visitors as $visitor) {
             if ($visitor->canVisit($criterion)) {

src/lib/Query/Common/CriterionVisitor/ContentIdIn.php

@@ -30,10 +30,7 @@ public function canVisit(Criterion $criterion)
             );
     }
 
-    /**
-     * @return string
-     */
-    public function visit(Criterion $criterion, ?CriterionVisitor $subVisitor = null)
+    public function visit(Criterion $criterion, ?CriterionVisitor $subVisitor = null): string
     {
         return '(' .
             implode(

src/lib/Query/Common/CriterionVisitor/ContentTypeGroupIdIn.php

@@ -30,10 +30,7 @@ public function canVisit(Criterion $criterion)
             );
     }
 
-    /**
-     * @return string
-     */
-    public function visit(Criterion $criterion, ?CriterionVisitor $subVisitor = null)
+    public function visit(Criterion $criterion, ?CriterionVisitor $subVisitor = null): string
     {
         return '(' .
             implode(

src/lib/Query/Common/CriterionVisitor/ContentTypeIdIn.php

@@ -30,10 +30,7 @@ public function canVisit(Criterion $criterion)
             );
     }
 
-    /**
-     * @return string
-     */
-    public function visit(Criterion $criterion, ?CriterionVisitor $subVisitor = null)
+    public function visit(Criterion $criterion, ?CriterionVisitor $subVisitor = null): string
     {
         return '(' .
             implode(

src/lib/Query/Common/CriterionVisitor/ContentTypeIdentifierIn.php

@@ -56,13 +56,9 @@ public function canVisit(Criterion $criterion)
     }
 
     /**
-     * Map field value to a proper Solr representation.
-     *
      * @param \Ibexa\Contracts\Solr\Query\CriterionVisitor $subVisitor
-     *
-     * @return string
      */
-    public function visit(Criterion $criterion, ?CriterionVisitor $subVisitor = null)
+    public function visit(Criterion $criterion, ?CriterionVisitor $subVisitor = null): string
     {
         $validIds = [];
         $invalidIdentifiers = [];

src/lib/Query/Common/CriterionVisitor/CustomField/CustomFieldIn.php

@@ -31,10 +31,7 @@ public function canVisit(Criterion $criterion)
             );
     }
 
-    /**
-     * @return string
-     */
-    public function visit(Criterion $criterion, ?CriterionVisitor $subVisitor = null)
+    public function visit(Criterion $criterion, ?CriterionVisitor $subVisitor = null): string
     {
         $queries = [];
         $values = (array)$criterion->value;

src/lib/Query/Common/CriterionVisitor/CustomField/CustomFieldRange.php

@@ -33,10 +33,7 @@ public function canVisit(Criterion $criterion)
             );
     }
 
-    /**
-     * @return string
-     */
-    public function visit(Criterion $criterion, ?CriterionVisitor $subVisitor = null)
+    public function visit(Criterion $criterion, ?CriterionVisitor $subVisitor = null): string
     {
         $values = (array)$criterion->value;
         $start = $values[0];