IBX-9727: Applied review remarks

Author: barw4

src/bundle/ApiLoader/BoostFactorProviderFactory.php

@@ -16,6 +16,9 @@
  */
 readonly class BoostFactorProviderFactory
 {
+    /**
+     * @param class-string<\Ibexa\Solr\FieldMapper\BoostFactorProvider> $boostFactorProviderClass
+     */
     public function __construct(
         private ContainerInterface $container,
         private RepositoryConfigurationProviderInterface $repositoryConfigurationProvider,
@@ -33,9 +36,8 @@ public function buildService(): BoostFactorProvider
             $connection = $repositoryConfig['search']['connection'];
         }
 
-        /** @var \Ibexa\Solr\FieldMapper\BoostFactorProvider */
         return new $this->boostFactorProviderClass(
-            $this->container->getParameter(
+            (array)$this->container->getParameter(
                 "ibexa.solr.connection.{$connection}.boost_factor_map_id"
             )
         );

src/bundle/ApiLoader/IndexingDepthProviderFactory.php

@@ -14,6 +14,9 @@
 
 readonly class IndexingDepthProviderFactory
 {
+    /**
+     * @param class-string<\Ibexa\Solr\FieldMapper\IndexingDepthProvider> $indexingDepthProviderClass
+     */
     public function __construct(
         private ContainerInterface $container,
         private RepositoryConfigurationProviderInterface $repositoryConfigurationProvider,
@@ -31,12 +34,11 @@ public function buildService(): IndexingDepthProvider
             $connection = $repositoryConfig['search']['connection'];
         }
 
-        /** @var \Ibexa\Solr\FieldMapper\IndexingDepthProvider */
         return new $this->indexingDepthProviderClass(
-            $this->container->getParameter(
+            (array)$this->container->getParameter(
                 "ibexa.solr.connection.{$connection}.indexing_depth.map"
             ),
-            $this->container->getParameter(
+            (int)$this->container->getParameter(
                 "ibexa.solr.connection.{$connection}.indexing_depth.default"
             )
         );

src/bundle/ApiLoader/SolrEngineFactory.php

@@ -16,6 +16,9 @@
 
 readonly class SolrEngineFactory
 {
+    /**
+     * @param class-string<\Ibexa\Solr\Handler> $searchEngineClass
+     */
     public function __construct(
         private RepositoryConfigurationProviderInterface $repositoryConfigurationProvider,
         private string $defaultConnection,
@@ -38,7 +41,6 @@ public function buildEngine(): \Ibexa\Solr\Handler
         $gateway = $this->gatewayRegistry->getGateway($connection);
         $coreFilter = $this->coreFilterRegistry->getCoreFilter($connection);
 
-        /** @var \Ibexa\Solr\Handler */
         return new $this->searchEngineClass(
             $gateway,
             $this->contentHandler,

src/lib/FieldMapper/ContentTranslationFieldMapper/ContentDocumentFulltextFields.php

@@ -137,11 +137,11 @@ private function doMapRelatedFields(Content $sourceContent, $languageCode, $maxD
         );
 
         $relatedContents = $this->contentHandler->loadContentList(
-            array_map(static fn (Content\Relation $relation) => $relation->destinationContentId, $relations)
+            array_map(static fn (Content\Relation $relation): int => $relation->destinationContentId, $relations)
         );
 
         $contentTypes = $this->contentTypeHandler->loadContentTypeList(
-            array_map(static fn (Content $content) => $content->versionInfo->contentInfo->contentTypeId, $relatedContents)
+            array_map(static fn (Content $content): int => $content->versionInfo->contentInfo->contentTypeId, $relatedContents)
         );
 
         $fields = [];