Added rule for enforcing either interface or abstract class as dependency / method argument

Author: ViniTou

phpstan-baseline.neon

@@ -0,0 +1,26 @@
+parameters:
+	ignoreErrors:
+		-
+			message: "#^Property Ibexa\\\\Tests\\\\PHPStan\\\\Rules\\\\Fixtures\\\\RequireAbstractionInDependenciesFixture\\:\\:\\$abstractClass is never read, only written\\.$#"
+			count: 1
+			path: tests/rules/Fixtures/RequireAbstractionInDependenciesFixture.php
+
+		-
+			message: "#^Property Ibexa\\\\Tests\\\\PHPStan\\\\Rules\\\\Fixtures\\\\RequireAbstractionInDependenciesFixture\\:\\:\\$classWithoutInterface is never read, only written\\.$#"
+			count: 1
+			path: tests/rules/Fixtures/RequireAbstractionInDependenciesFixture.php
+
+		-
+			message: "#^Property Ibexa\\\\Tests\\\\PHPStan\\\\Rules\\\\Fixtures\\\\RequireAbstractionInDependenciesFixture\\:\\:\\$concreteClass is never read, only written\\.$#"
+			count: 1
+			path: tests/rules/Fixtures/RequireAbstractionInDependenciesFixture.php
+
+		-
+			message: "#^Property Ibexa\\\\Tests\\\\PHPStan\\\\Rules\\\\Fixtures\\\\RequireAbstractionInDependenciesFixture\\:\\:\\$concreteExtendingAbstract is never read, only written\\.$#"
+			count: 1
+			path: tests/rules/Fixtures/RequireAbstractionInDependenciesFixture.php
+
+		-
+			message: "#^Property Ibexa\\\\Tests\\\\PHPStan\\\\Rules\\\\Fixtures\\\\RequireAbstractionInDependenciesFixture\\:\\:\\$testInterface is never read, only written\\.$#"
+			count: 1
+			path: tests/rules/Fixtures/RequireAbstractionInDependenciesFixture.php

rules/RequireInterfaceInDependenciesRule.php renamed to rules/RequireAbstractionInDependenciesRule.php

@@ -17,7 +17,7 @@
 /**
  * @implements \PHPStan\Rules\Rule<\PhpParser\Node\Stmt\ClassMethod>
  */
-final class RequireInterfaceInDependenciesRule implements Rule
+final class RequireAbstractionInDependenciesRule implements Rule
 {
     public function getNodeType(): string
     {
@@ -33,7 +33,6 @@ public function processNode(Node $node, Scope $scope): array
         }
 
         foreach ($node->params as $param) {
-
             if (!$param->type instanceof Node\Name) {
                 continue;
             }
@@ -47,17 +46,42 @@ public function processNode(Node $node, Scope $scope): array
                 continue;
             }
 
-            if (!interface_exists($typeName) && class_exists($typeName)) {
-                // Check if this class implements any interface
+            // Skip interfaces - they are always acceptable
+            if (interface_exists($typeName)) {
+                continue;
+            }
+
+            // Check if it's a class
+            if (class_exists($typeName)) {
+                $reflection = new \ReflectionClass($typeName);
+
+                // Skip abstract classes - they are acceptable
+                if ($reflection->isAbstract()) {
+                    continue;
+                }
+
+                // This is a concrete class - check if it has interfaces or extends an abstract class
                 $interfaces = class_implements($typeName);
+                $parentClass = $reflection->getParentClass();
+                $hasAbstractParent = $parentClass && $parentClass->isAbstract();
+
+                if (!empty($interfaces) || $hasAbstractParent) {
+                    $suggestions = [];
+
+                    if (!empty($interfaces)) {
+                        $suggestions[] = 'Available interfaces: ' . implode(', ', $interfaces);
+                    }
+
+                    if ($hasAbstractParent) {
+                        $suggestions[] = 'Abstract parent: ' . $parentClass->getName();
+                    }
 
-                if (!empty($interfaces)) {
                     $errors[] = RuleErrorBuilder::message(
                         sprintf(
-                            'Parameter $%s uses concrete class %s instead of an interface. Available interfaces: %s',
+                            'Parameter $%s uses concrete class %s instead of an interface or abstract class. %s',
                             is_string($param->var->name) ? $param->var->name : $param->var->name->getType(),
                             $typeName,
-                            implode(', ', $interfaces)
+                            implode('. ', $suggestions)
                         )
                     )->build();
                 }

tests/rules/Fixtures/NamingConvention/CorrectNameInterface.php

@@ -6,8 +6,9 @@
  */
 declare(strict_types=1);
 
-namespace Ibexa\Tests\PHPStan\Rules\Fixtures\NamingConvention;
+namespace Ibexa\Tests\PHPStan\Rules\Fixtures\RequireAbstractionInDependencies;
 
-abstract class SimpleClass
+abstract class AbstractClass
 {
+    abstract public function doSomethingAbstract(): void;
 }

tests/rules/Fixtures/NamingConvention/CorrectNameTrait.php

@@ -6,8 +6,12 @@
  */
 declare(strict_types=1);
 
-namespace Ibexa\Tests\PHPStan\Rules\Fixtures\NamingConvention;
+namespace Ibexa\Tests\PHPStan\Rules\Fixtures\RequireAbstractionInDependencies;
 
-abstract class AbstractCorrectClass
+class ClassWithoutInterface
 {
+    public function doNothing(): void
+    {
+        // Implementation
+    }
 }

tests/rules/Fixtures/NamingConvention/SimpleThing.php

@@ -6,7 +6,7 @@
  */
 declare(strict_types=1);
 
-namespace Ibexa\Tests\PHPStan\Rules\Fixtures\RequireInterfaceInDependencies;
+namespace Ibexa\Tests\PHPStan\Rules\Fixtures\RequireAbstractionInDependencies;
 
 class ConcreteClass implements TestInterface
 {

tests/rules/Fixtures/NamingConvention/WrongName.php

@@ -0,0 +1,17 @@
+<?php
+
+/**
+ * @copyright Copyright (C) Ibexa AS. All rights reserved.
+ * @license For full copyright and license information view LICENSE file distributed with this source code.
+ */
+declare(strict_types=1);
+
+namespace Ibexa\Tests\PHPStan\Rules\Fixtures\RequireAbstractionInDependencies;
+
+class ConcreteClassExtendingAbstract extends AbstractClass
+{
+    public function doSomethingAbstract(): void
+    {
+        // Implementation
+    }
+}