IBX-6312: View matcher ParentContentType should not throw execption if parent is not available

Author: vidarl

src/bundle/Core/Resources/config/services.yml

@@ -110,6 +110,8 @@ services:
             $authorizationChecker: "@security.authorization_checker"
             $locationProvider: '@Ibexa\Core\Helper\PreviewLocationProvider'
             $controllerChecker: '@Ibexa\Core\MVC\Symfony\View\CustomLocationControllerChecker'
+            $debugMode: '%kernel.debug%'
+            $logger: '@logger'
         tags:
             - { name: controller.service_arguments }
 

src/lib/MVC/Symfony/Controller/Content/PreviewController.php

@@ -8,6 +8,7 @@
 
 use Exception;
 use Ibexa\Contracts\Core\Repository\ContentService;
+use Ibexa\Contracts\Core\Repository\Exceptions\NotFoundException;
 use Ibexa\Contracts\Core\Repository\Exceptions\NotImplementedException;
 use Ibexa\Contracts\Core\Repository\Exceptions\UnauthorizedException;
 use Ibexa\Contracts\Core\Repository\LocationService;
@@ -21,6 +22,9 @@
 use Ibexa\Core\MVC\Symfony\SiteAccess;
 use Ibexa\Core\MVC\Symfony\View\CustomLocationControllerChecker;
 use Ibexa\Core\MVC\Symfony\View\ViewManagerInterface;
+use Psr\Log\LoggerAwareTrait;
+use Psr\Log\LoggerInterface;
+use Psr\Log\NullLogger;
 use Symfony\Component\HttpFoundation\Request;
 use Symfony\Component\HttpFoundation\Response;
 use Symfony\Component\HttpKernel\HttpKernelInterface;
@@ -29,6 +33,8 @@
 
 class PreviewController
 {
+    use LoggerAwareTrait;
+
     public const PREVIEW_PARAMETER_NAME = 'isPreview';
     public const CONTENT_VIEW_ROUTE = 'ibexa.content.view';
 
@@ -53,14 +59,19 @@ class PreviewController
     /** @var \Ibexa\Core\MVC\Symfony\View\CustomLocationControllerChecker */
     private $controllerChecker;
 
+    /** @var bool */
+    private $debugMode;
+
     public function __construct(
         ContentService $contentService,
         LocationService $locationService,
         HttpKernelInterface $kernel,
         ContentPreviewHelper $previewHelper,
         AuthorizationCheckerInterface $authorizationChecker,
         PreviewLocationProvider $locationProvider,
-        CustomLocationControllerChecker $controllerChecker
+        CustomLocationControllerChecker $controllerChecker,
+        bool $debugMode,
+        ?LoggerInterface $logger = null
     ) {
         $this->contentService = $contentService;
         $this->locationService = $locationService;
@@ -69,6 +80,8 @@ public function __construct(
         $this->authorizationChecker = $authorizationChecker;
         $this->locationProvider = $locationProvider;
         $this->controllerChecker = $controllerChecker;
+        $this->debugMode = $debugMode;
+        $this->logger = $logger ?? new NullLogger();
     }
 
     /**
@@ -120,17 +133,45 @@ public function previewContentAction(
                 false
             );
         } catch (\Exception $e) {
-            if ($location->isDraft() && $this->controllerChecker->usesCustomController($content, $location)) {
-                // @todo This should probably be an exception that embeds the original one
-                $message = <<<EOF
+            try {
+                if ($location->isDraft() && $this->controllerChecker->usesCustomController($content, $location)) {
+                    // @todo This should probably be an exception that embeds the original one
+                    $message = <<<EOF
 <p>The view that rendered this location draft uses a custom controller, and resulted in a fatal error.</p>
 <p>Location View is deprecated, as it causes issues with preview, such as an empty location id when previewing the first version of a content.</p>
 EOF;
 
-                throw new Exception($message, 0, $e);
+                    throw new Exception($message, 0, $e);
+                }
+            } catch (\Exception $e2) {
+                $this->logger->warning('Unable to check if location uses a custom controller when loading the preview page', ['exception' => $e2]);
+                if ($this->debugMode) {
+                    throw $e2;
+                }
+            }
+            $message = '';
+
+            if ($e instanceof NotFoundException) {
+                $message .= 'Location not found or not available in requested language';
+                $this->logger->warning('Location not found or not available in requested language when loading the preview page', ['exception' => $e]);
+                if ($this->debugMode) {
+                    throw new Exception($message, 0, $e);
+                }
             } else {
+                $this->logger->warning('Unable to load the preview page', ['exception' => $e]);
+            }
+
+            if ($this->debugMode) {
                 throw $e;
             }
+
+            $message = <<<EOF
+<p>$message</p>
+<p>Unable to load the preview page</p>
+<p>See logs for more information</p>
+EOF;
+
+            return new Response($message);
         }
         $response->headers->addCacheControlDirective('no-cache', true);
         $response->setPrivate();

tests/lib/MVC/Symfony/Controller/Controller/Content/PreviewControllerTest.php

@@ -73,7 +73,9 @@ protected function getPreviewController(): PreviewController
             $this->previewHelper,
             $this->authorizationChecker,
             $this->locationProvider,
-            $this->controllerChecker
+            $this->controllerChecker,
+            false,
+            null
         );
     }