IBX-10669: Fixed accessing isContainer property for CT drafts (#653)

For more details see https://issues.ibexa.co/browse/IBX-10669 and #653

Key changes:

* Fixed accessing `isContainer` property for content type drafts

Author: konradoboza

rector.php

@@ -7,6 +7,7 @@
 declare(strict_types=1);
 
 use Ibexa\Contracts\Rector\Sets\IbexaSetList;
+use Ibexa\Rector\Rule\PropertyToGetterRector;
 use Rector\Config\RectorConfig;
 use Rector\Doctrine\Set\DoctrineSetList;
 use Rector\Symfony\Set\SymfonySetList;
@@ -33,4 +34,7 @@
         CommandConfigureToAttributeRector::class => [
             __DIR__ . '/tests/bundle/Core/EventListener/BackwardCompatibleCommandListenerTest.php',
         ],
+        PropertyToGetterRector::class => [
+            __DIR__ . '/tests/lib/Repository/Values/ContentType/ContentTypeTest.php',
+        ]
     ]);

src/lib/Repository/Values/ContentType/ContentTypeDraft.php

@@ -149,4 +149,9 @@ public function hasFieldDefinition(string $fieldDefinitionIdentifier): bool
     {
         return $this->innerContentType->hasFieldDefinition($fieldDefinitionIdentifier);
     }
+
+    public function isContainer(): bool
+    {
+        return $this->innerContentType->isContainer();
+    }
 }

tests/integration/RepositoryInstaller/.gitkeep

@@ -11,15 +11,16 @@
 use Ibexa\Contracts\Core\Repository\Values\ContentType\FieldDefinition;
 use Ibexa\Contracts\Core\Repository\Values\ContentType\FieldDefinitionCollection as APIFieldDefinitionCollection;
 use Ibexa\Core\Repository\Values\ContentType\ContentType;
+use Ibexa\Core\Repository\Values\ContentType\ContentTypeDraft;
 use PHPUnit\Framework\TestCase;
 
 /**
  * @covers \Ibexa\Core\Repository\Values\ContentType\ContentType
  */
 final class ContentTypeTest extends TestCase
 {
-    private const EXAMPLE_FIELD_DEFINITION_IDENTIFIER = 'example';
-    private const EXAMPLE_FIELD_TYPE_IDENTIFIER = 'ezcustom';
+    private const string EXAMPLE_FIELD_DEFINITION_IDENTIFIER = 'example';
+    private const string EXAMPLE_FIELD_TYPE_IDENTIFIER = 'ezcustom';
 
     public function testStrictGetters(): void
     {
@@ -139,4 +140,31 @@ public function testGetFirstFieldDefinitionOfType(): void
             $contentType->getFirstFieldDefinitionOfType(self::EXAMPLE_FIELD_TYPE_IDENTIFIER)
         );
     }
+
+    /**
+     * @dataProvider provideForDeprecatedPropertyAccessMatchesMethodCallResult
+     */
+    public function testDeprecatedPropertyAccessMatchesMethodCallResult(bool $isContainer): void
+    {
+        $contentTypeDraft = new ContentTypeDraft([
+            'innerContentType' => new ContentType([
+                'isContainer' => $isContainer,
+            ]),
+        ]);
+
+        /** @phpstan-ignore-next-line property.protected
+         * intentionally violating deprecated property access.
+         */
+        self::assertSame($isContainer, $contentTypeDraft->isContainer);
+        self::assertSame($isContainer, $contentTypeDraft->isContainer());
+    }
+
+    /**
+     * @return iterable<string, array{0: bool}>
+     */
+    public function provideForDeprecatedPropertyAccessMatchesMethodCallResult(): iterable
+    {
+        yield 'content type draft is a container' => [true];
+        yield 'content type draft is not a container' => [false];
+    }
 }