IBX-8534: Cleaned up deprecations (#456)

For more details see https://issues.ibexa.co/browse/IBX-8534 and #456

Key changes:

* Removed deprecation from `SectionService::countAssignedContents` and `SectionService::count` methods, as they're used by AdminUI and there is no replacement for them

* Removed deprecation from `\Ibexa\Core\FieldType\Image\Value::fromString`

* Dropped \Ibexa\Core\Helper\FieldHelper::getFieldDefinition

* Dropped \Ibexa\Core\FieldType\StorageGateway

* Dropped \Ibexa\Contracts\Core\Persistence\Content\ContentInfo::STATUS_ARCHIVED

* Dropped \Ibexa\Contracts\Core\Persistence\Content\ContentInfo::$isPublished

* Dropped $name from bookmarks

* Dropped \Ibexa\Contracts\Core\Persistence\Content\Handler::loadRelations

* Dropped Identity contracts

* Injected TransactionHandler into repository

* Dropped imageValue::path

* Dropped imageValue::path

* Dropped \Ibexa\Core\FieldType\Image\Value::fromString

* Dropped \Ibexa\Contracts\Core\Persistence\Content\LoadStruct

* Dropped \Ibexa\Core\Persistence\Cache\PersistenceLogger::getCount

* Dropped \Ibexa\Contracts\Core\Repository\PasswordHashService

* Dropped Location::pathIdentificationString

* Dropped markSubtreeModified & updateSubtreeModificationTime

* Dropped \Ibexa\Contracts\Core\Persistence\FieldType\IsEmptyValue

* Dropped Indexer::createSearchIndex

* Dropped \Ibexa\Contracts\Core\Persistence\User\Handler::loadPoliciesByUserId

* Dropped \Ibexa\Contracts\Core\Repository\Values\Content\Query\Criterion\Location\IsMainLocation::createFromQueryBuilder

* Dropped \Ibexa\Core\Repository\Helper\RoleDomainMapper

* Dropped Ibexa\Core\Repository\Helper\NameSchemaService

* Dropped \Ibexa\Contracts\Core\Repository\Values\Content\Query\Criterion\Location\Priority::createFromQueryBuilder

* Dropped Location::SORT_FIELD_MODIFIED_SUBNODE

* Replaced abstract Criterion with CriterionInterface

Author: ViniTou

phpstan-baseline.neon

@@ -11,12 +11,12 @@
 use Ibexa\Contracts\Core\Persistence\Filter\Content\Handler as ContentFilteringHandler;
 use Ibexa\Contracts\Core\Persistence\Filter\Location\Handler as LocationFilteringHandler;
 use Ibexa\Contracts\Core\Persistence\Handler as PersistenceHandler;
+use Ibexa\Contracts\Core\Persistence\TransactionHandler;
 use Ibexa\Contracts\Core\Repository\LanguageResolver;
 use Ibexa\Contracts\Core\Repository\NameSchema\NameSchemaServiceInterface;
 use Ibexa\Contracts\Core\Repository\PasswordHashService;
 use Ibexa\Contracts\Core\Repository\PermissionService;
 use Ibexa\Contracts\Core\Repository\Repository;
-use Ibexa\Contracts\Core\Repository\Strategy\ContentThumbnail\ThumbnailStrategy;
 use Ibexa\Contracts\Core\Repository\Validator\ContentValidator;
 use Ibexa\Contracts\Core\Search\Handler as SearchHandler;
 use Ibexa\Contracts\Core\SiteAccess\ConfigResolverInterface;
@@ -81,7 +81,6 @@ public function buildRepository(
         RelationProcessor $relationProcessor,
         FieldTypeRegistry $fieldTypeRegistry,
         PasswordHashService $passwordHashService,
-        ThumbnailStrategy $thumbnailStrategy,
         ProxyDomainMapperFactoryInterface $proxyDomainMapperFactory,
         Mapper\ContentDomainMapper $contentDomainMapper,
         Mapper\ContentTypeDomainMapper $contentTypeDomainMapper,
@@ -95,6 +94,7 @@ public function buildRepository(
         PasswordValidatorInterface $passwordValidator,
         ConfigResolverInterface $configResolver,
         NameSchemaServiceInterface $nameSchemaService,
+        TransactionHandler $transactionHandler
     ): Repository {
         $config = $this->repositoryConfigurationProvider->getRepositoryConfig();
 
@@ -105,7 +105,6 @@ public function buildRepository(
             $relationProcessor,
             $fieldTypeRegistry,
             $passwordHashService,
-            $thumbnailStrategy,
             $proxyDomainMapperFactory,
             $contentDomainMapper,
             $contentTypeDomainMapper,
@@ -120,6 +119,7 @@ public function buildRepository(
             $passwordValidator,
             $configResolver,
             $nameSchemaService,
+            $transactionHandler,
             [
                 'role' => [
                     'policyMap' => $this->policyMap,

src/bundle/Core/ApiLoader/RepositoryFactory.php

@@ -177,6 +177,7 @@ protected function execute(InputInterface $input, OutputInterface $output): int
                     $contentInfo,
                     $removeAll ? null : $this->mapStatusToVersionInfoStatus($status)
                 );
+                $versions = iterator_to_array($versions);
                 $versionsCount = count($versions);
 
                 $output->writeln(sprintf(

src/bundle/Core/Command/CleanupVersionsCommand.php

@@ -14,7 +14,6 @@
 use Ibexa\Contracts\Core\Persistence\Content\Location\Handler;
 use Ibexa\Contracts\Core\Search\Content\IndexerGateway;
 use Ibexa\Core\Base\Exceptions\InvalidArgumentException;
-use Ibexa\Core\Search\Common\IncrementalIndexer;
 use Ibexa\Core\Search\Common\Indexer;
 use Psr\Log\LoggerInterface;
 use RuntimeException;
@@ -191,48 +190,31 @@ protected function execute(InputInterface $input, OutputInterface $output): int
             throw new InvalidArgumentException('--iteration-count', "The value must be > 0, you provided '{$iterationCount}'");
         }
 
-        if (!$this->searchIndexer instanceof IncrementalIndexer) {
-            $output->writeln(<<<EOT
-                DEPRECATED:
-                Running indexing against an Indexer that has not been updated to use IncrementalIndexer abstract.
-                
-                Options that won't be taken into account:
-                - since
-                - content-ids
-                - subtree
-                - processes
-                - no-purge
-            EOT);
-            $this->searchIndexer->createSearchIndex($output, (int) $iterationCount, !$commit);
-        } else {
-            if (\in_array($input->getOption('processes'), ['0', '1'])) {
-                $io = new SymfonyStyle($input, $output);
-                $xdebugState = \extension_loaded('xdebug') ? 'enabled' : 'disabled';
-                $memoryLimit = ini_get('memory_limit');
-
-                $io->warning(<<<EOT
-                    It's not recommended to run this command in a single process mode with a large dataset!
-
-                    For optimal performance, before running this command, make sure that:
-                    - the xdebug extension is disabled (you have it $xdebugState),
-                    - you're running the command in "prod" environment (default: dev), 
-                    - memory limit for big databases is set to "-1" or an adequately high value (your value: $memoryLimit),
-                    - --iteration-count is low enough (default: 50),
-                    - number of processes for parallel batch operations is high enough (default: 'auto' is a good choice).
-                EOT);
-
-                if (!$io->confirm('Continue?', true)) {
-                    return self::SUCCESS;
-                }
-            }
+        if (\in_array($input->getOption('processes'), ['0', '1'])) {
+            $io = new SymfonyStyle($input, $output);
+            $xdebugState = \extension_loaded('xdebug') ? 'enabled' : 'disabled';
+            $memoryLimit = ini_get('memory_limit');
+
+            $io->warning(<<<EOT
+                It's not recommended to run this command in a single process mode with a large dataset!
 
-            $output->writeln('Re-indexing started for search engine: ' . $this->searchIndexer->getName());
-            $output->writeln('');
+                For optimal performance, before running this command, make sure that:
+                - the xdebug extension is disabled (you have it $xdebugState),
+                - you're running the command in "prod" environment (default: dev), 
+                - memory limit for big databases is set to "-1" or an adequately high value (your value: $memoryLimit),
+                - --iteration-count is low enough (default: 50),
+                - number of processes for parallel batch operations is high enough (default: 'auto' is a good choice).
+            EOT);
 
-            return $this->indexIncrementally($input, $output, $iterationCount, $commit);
+            if (!$io->confirm('Continue?', true)) {
+                return self::SUCCESS;
+            }
         }
 
-        return self::SUCCESS;
+        $output->writeln('Re-indexing started for search engine: ' . get_class($this->searchIndexer));
+        $output->writeln('');
+
+        return $this->indexIncrementally($input, $output, $iterationCount, $commit);
     }
 
     /**
@@ -253,7 +235,7 @@ protected function indexIncrementally(
 
             $this->searchIndexer->updateSearchIndex($contentIds, $commit);
 
-            return 0;
+            return self::SUCCESS;
         }
 
         if ($since = $input->getOption('since')) {
@@ -278,7 +260,7 @@ protected function indexIncrementally(
         if (!$count) {
             $output->writeln('<error>Could not find any items to index, aborting.</error>');
 
-            return 1;
+            return self::FAILURE;
         }
 
         $iterations = ceil($count / $iterationCount);
@@ -326,7 +308,7 @@ protected function indexIncrementally(
         // clear leftover progress bar parts
         $progress->clear();
 
-        return 0;
+        return self::SUCCESS;
     }
 
     /**

src/bundle/Core/Command/ReindexCommand.php

@@ -82,7 +82,7 @@ public function reindex()
             try {
                 // In case version has changed we make sure to fetch fresh ContentInfo
                 $contentInfo = $contentHandler->loadContentInfo($contentInfo->id);
-                if ($contentInfo->isPublished) {
+                if ($contentInfo->status === ContentInfo::STATUS_PUBLISHED) {
                     $this->searchHandler->indexContent(
                         $contentHandler->load($contentInfo->id, $contentInfo->currentVersionNo)
                     );
@@ -109,7 +109,7 @@ public function reindex()
             try {
                 // In case version has changed we make sure to fetch fresh ContentInfo
                 $contentInfo = $contentHandler->loadContentInfo($location->contentId);
-                if ($contentInfo->isPublished) {
+                if ($contentInfo->status === ContentInfo::STATUS_PUBLISHED) {
                     $this->searchHandler->indexContent(
                         $contentHandler->load($contentInfo->id, $contentInfo->currentVersionNo)
                     );

src/bundle/Core/EventListener/BackgroundIndexingTerminateListener.php

@@ -13,7 +13,7 @@ services:
             - "@?logger"
 
     Ibexa\Core\Helper\FieldHelper:
-        arguments: ['@Ibexa\Core\Helper\TranslationHelper', '@ibexa.api.service.content_type', '@ibexa.api.service.field_type']
+        arguments: ['@Ibexa\Core\Helper\TranslationHelper', '@ibexa.api.service.field_type']
 
     Ibexa\Core\Helper\ContentPreviewHelper:
         arguments: ["@event_dispatcher", '@Ibexa\Core\MVC\Symfony\SiteAccess\Router']

src/bundle/Core/Resources/config/helpers.yml

@@ -19,15 +19,6 @@ class Bookmark extends ValueObject
      */
     public $id;
 
-    /**
-     * Name of the bookmarked location.
-     *
-     * @deprecated Property is here purely for BC with 5.x.
-     *
-     * @var string
-     */
-    public $name;
-
     /**
      * ID of the bookmarked Location.
      *

src/contracts/Persistence/Bookmark/Bookmark.php

@@ -12,15 +12,6 @@
 
 class CreateStruct extends ValueObject
 {
-    /**
-     * Name of the bookmarked location.
-     *
-     * @deprecated Property is here purely for BC with 5.x.
-     *
-     * @var string
-     */
-    public $name;
-
     /**
      * ID of the bookmarked Location.
      *

src/contracts/Persistence/Bookmark/CreateStruct.php

@@ -20,9 +20,6 @@ class ContentInfo extends ValueObject
     public const STATUS_PUBLISHED = 1;
     public const STATUS_TRASHED = 2;
 
-    /** @deprecated Use {@see ContentInfo::STATUS_TRASHED} */
-    public const STATUS_ARCHIVED = self::STATUS_TRASHED;
-
     /**
      * Content's unique ID.
      *
@@ -59,15 +56,6 @@ class ContentInfo extends ValueObject
      */
     public $currentVersionNo;
 
-    /**
-     * @deprecated Use {@see ContentInfo::$status} (with value {@see ContentInfo::STATUS_PUBLISHED})
-     *
-     * Flag indicating if content is currently published.
-     *
-     * @var bool
-     */
-    public $isPublished;
-
     /**
      * Content owner's id.
      *

src/contracts/Persistence/Content/ContentInfo.php

@@ -281,22 +281,6 @@ public function loadRelation(int $relationId): Relation;
      */
     public function removeRelation($relationId, $type, ?int $destinationContentId = null);
 
-    /**
-     * Loads relations from $sourceContentId. Optionally, loads only those with $type and $sourceContentVersionNo.
-     *
-     * @deprecated 4.5.7 It will be removed in 5.0. Use {@see \Ibexa\Contracts\Core\Repository\ContentService::loadRelationList()} instead.
-     *
-     * @param mixed $sourceContentId Source Content ID
-     * @param mixed|null $sourceContentVersionNo Source Content Version, null if not specified
-     * @param int|null $type {@see \Ibexa\Contracts\Core\Repository\Values\Content\Relation::COMMON,
-     *                 \Ibexa\Contracts\Core\Repository\Values\Content\Relation::EMBED,
-     *                 \Ibexa\Contracts\Core\Repository\Values\Content\Relation::LINK,
-     *                 \Ibexa\Contracts\Core\Repository\Values\Content\Relation::FIELD}
-     *
-     * @return \Ibexa\Contracts\Core\Persistence\Content\Relation[]
-     */
-    public function loadRelations($sourceContentId, $sourceContentVersionNo = null, $type = null);
-
     /**
      * Counts all outgoing relations for the given version.
      */