Fixed deprecation notices in string interpolation with PHP 8.2 (#205)

Author: patrickallaert

src/bundle/Core/DependencyInjection/IbexaCoreExtension.php

@@ -782,7 +782,7 @@ private function configureGenericSetup(ContainerBuilder $container): void
 
         // Cache settings
         // If CACHE_POOL env variable is set, check if there is a yml file that needs to be loaded for it
-        if (($pool = $_SERVER['CACHE_POOL'] ?? false) && file_exists($projectDir . "/config/packages/cache_pool/${pool}.yaml")) {
+        if (($pool = $_SERVER['CACHE_POOL'] ?? false) && file_exists($projectDir . "/config/packages/cache_pool/$pool.yaml")) {
             $loader = new Loader\YamlFileLoader($container, new FileLocator($projectDir . '/config/packages/cache_pool'));
             $loader->load($pool . '.yaml');
         }

src/bundle/Core/Features/Context/UserContext.php

@@ -544,7 +544,7 @@ public function assertUserWithNameExistsWithFields($username, TableNode $table)
      */
     private function findNonExistingUserEmail($username = 'User')
     {
-        $email = "${username}@ibexa.co";
+        $email = "{$username}@ibexa.co";
         if ($this->checkUserExistenceByEmail($email)) {
             return $email;
         }

src/lib/FieldType/GatewayBasedStorage.php

@@ -87,7 +87,7 @@ protected function getGateway(array $context)
         );
 
         if (!isset($this->gateways[$context['identifier']])) {
-            throw new \OutOfBoundsException("No gateway for ${context['identifier']} available.");
+            throw new \OutOfBoundsException("No gateway for $context[identifier] available.");
         }
 
         $gateway = $this->gateways[$context['identifier']];

src/lib/Persistence/Cache/ContentHandler.php

@@ -131,7 +131,7 @@ public function copy($contentId, $versionNo = null, $newOwnerId = null)
      */
     public function load($contentId, $versionNo = null, array $translations = null)
     {
-        $keySuffix = $versionNo ? "-${versionNo}-" : '-';
+        $keySuffix = $versionNo ? "-{$versionNo}-" : '-';
         $keySuffix .= empty($translations) ? self::ALL_TRANSLATIONS_KEY : implode('|', $translations);
 
         return $this->getCacheValue(
@@ -238,7 +238,7 @@ function () use ($remoteId) {
      */
     public function loadVersionInfo($contentId, $versionNo = null)
     {
-        $keySuffix = $versionNo ? "-${versionNo}" : '';
+        $keySuffix = $versionNo ? "-{$versionNo}" : '';
         $cacheItem = $this->cache->getItem(
             $this->cacheIdentifierGenerator->generateKey(
                 self::CONTENT_VERSION_INFO_IDENTIFIER,

tests/integration/Core/Repository/BaseTest.php

@@ -173,7 +173,7 @@ protected function getSetupFactory(): SetupFactory
         if (null === $this->setupFactory) {
             if (false === ($setupClass = getenv('setupFactory'))) {
                 $setupClass = LegacySetupFactory::class;
-                putenv("setupFactory=${setupClass}");
+                putenv("setupFactory=$setupClass");
             }
 
             if (false === getenv('fixtureDir')) {

tests/integration/Core/Repository/ContentTypeServiceTest.php

@@ -874,7 +874,7 @@ public function testCreateContentTypeStructValues(array $data)
                     $this->assertEquals(
                         $typeCreate->$propertyName,
                         $contentType->$propertyName,
-                        "Did not assert that property '${propertyName}' is equal on struct and resulting value object"
+                        "Did not assert that property '$propertyName' is equal on struct and resulting value object"
                     );
                     break;
             }