Skip to content

Commit 2c1b555

Browse files
author
Ryan Lee
committed
IBX-10186 Run everything like 20 times and to not play wack-a-mole with errors
1 parent 500b400 commit 2c1b555

File tree

2 files changed

+10
-4
lines changed

2 files changed

+10
-4
lines changed

phpstan-baseline.neon

Lines changed: 7 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -4068,6 +4068,12 @@ parameters:
40684068
count: 1
40694069
path: src/bundle/Core/Imagine/Cache/AliasGeneratorDecorator.php
40704070

4071+
-
4072+
message: '#^PHPDoc tag @throws with type Psr\\Cache\\InvalidArgumentException is not subtype of Throwable$#'
4073+
identifier: throws.notThrowable
4074+
count: 1
4075+
path: src/bundle/Core/Imagine/Cache/AliasGeneratorDecorator.php
4076+
40714077
-
40724078
message: '#^Property Ibexa\\Bundle\\Core\\Imagine\\Cache\\AliasGeneratorDecorator\:\:\$siteAccess \(Ibexa\\Core\\MVC\\Symfony\\SiteAccess\) does not accept Ibexa\\Core\\MVC\\Symfony\\SiteAccess\|null\.$#'
40734079
identifier: assign.propertyType
@@ -42003,7 +42009,7 @@ parameters:
4200342009
-
4200442010
message: '#^Method Ibexa\\Contracts\\Core\\Repository\\LocationService\:\:getSubtreeSize\(\) invoked with 2 parameters, 1 required\.$#'
4200542011
identifier: arguments.count
42006-
count: 1
42012+
count: 2
4200742013
path: tests/integration/Core/Repository/LocationServiceTest.php
4200842014

4200942015
-

tests/integration/Core/Repository/LocationServiceTest.php

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -8,6 +8,7 @@
88

99
use Exception;
1010
use Ibexa\Contracts\Core\Repository\Exceptions\BadStateException;
11+
use Ibexa\Contracts\Core\Repository\Exceptions\InvalidArgumentException;
1112
use Ibexa\Contracts\Core\Repository\Exceptions\NotFoundException;
1213
use Ibexa\Contracts\Core\Repository\URLAliasService as URLAliasServiceInterface;
1314
use Ibexa\Contracts\Core\Repository\Values\Content\Content;
@@ -22,7 +23,6 @@
2223
use Ibexa\Contracts\Core\Repository\Values\Content\Search\SearchHit;
2324
use Ibexa\Contracts\Core\Repository\Values\Content\URLAlias;
2425
use Ibexa\Contracts\Core\Repository\Values\User\Limitation\SubtreeLimitation;
25-
use Ibexa\Contracts\Core\Repository\Exceptions\InvalidArgumentException;
2626
use Ibexa\Core\Repository\Values\Content\ContentUpdateStruct;
2727

2828
/**
@@ -3588,8 +3588,6 @@ public function testGetSubtreeSizeWithLimit(): Location
35883588
$location = $folder->getVersionInfo()->getContentInfo()->getMainLocation();
35893589
self::assertNotNull($location);
35903590

3591-
self::assertSame(1, $locationService->getSubtreeSize($location));
3592-
35933591
for ($i = 1; $i <= 10; ++$i) {
35943592
$this->createFolder(['eng-GB' => 'Child ' . $i], $location->id);
35953593
}
@@ -3617,6 +3615,8 @@ public function testGetSubtreeSizeWithInvalidLimitThrowsExpectedError(): Locatio
36173615
$this->expectException(InvalidArgumentException::class);
36183616
$this->expectExceptionMessageRegExp('/Limit must be greater than 0/');
36193617

3618+
self::assertSame(3, $locationService->getSubtreeSize($location, -42));
3619+
36203620
return $location;
36213621
}
36223622

0 commit comments

Comments
 (0)