IBX-10936: CS

Author: barw4

phpstan-baseline.neon

@@ -45030,6 +45030,18 @@ parameters:
 			count: 1
 			path: tests/integration/Core/Repository/SearchServiceTest.php
 
+		-
+			message: '#^Cannot access offset ''id'' on Ibexa\\Contracts\\Core\\Repository\\Values\\ValueObject\.$#'
+			identifier: offsetAccess.nonOffsetAccessible
+			count: 3
+			path: tests/integration/Core/Repository/SearchServiceTest.php
+
+		-
+			message: '#^Cannot access offset ''title'' on Ibexa\\Contracts\\Core\\Repository\\Values\\ValueObject\.$#'
+			identifier: offsetAccess.nonOffsetAccessible
+			count: 1
+			path: tests/integration/Core/Repository/SearchServiceTest.php
+
 		-
 			message: '#^Cannot access property \$valueObject on Ibexa\\Contracts\\Core\\Repository\\Values\\Content\\Search\\SearchHit\|null\.$#'
 			identifier: property.nonObject

tests/integration/Core/Repository/SearchServiceTest.php

@@ -1734,10 +1734,6 @@ static function (&$data): void {
                 usort(
                     $data->searchHits,
                     static function (SearchHit $a, SearchHit $b): int {
-                        if (!is_array($a->valueObject) || !is_array($b->valueObject)) {
-                            throw new \RuntimeException('Expected simplified search hit value objects to be arrays.');
-                        }
-
                         return $a->valueObject['id'] <=> $b->valueObject['id'];
                     }
                 );
@@ -1933,10 +1929,6 @@ static function (&$data) {
                     usort(
                         $data->searchHits,
                         static function ($a, $b) use ($map) {
-                            if (!is_array($a->valueObject) || !is_array($b->valueObject)) {
-                                throw new \RuntimeException('Expected simplified search hit value objects to be arrays.');
-                            }
-
                             return ($map[$a->valueObject['id']] < $map[$b->valueObject['id']]) ? -1 : 1;
                         }
                     );
@@ -4772,28 +4764,23 @@ protected function assertQueryFixture(
 
         $fixture = require $fixtureFilePath;
 
-        if (!$fixture instanceof SearchResult) {
-            self::fail(sprintf(
-                'Fixture "%s" must return an instance of %s, %s given.',
-                $fixtureFilePath,
-                SearchResult::class,
-                is_object($fixture) ? get_class($fixture) : gettype($fixture)
-            ));
-        }
-
         if ($closure !== null) {
             $closure($fixture);
             $closure($result);
         }
 
         if ($ignoreScore) {
             foreach ([$fixture, $result] as $set) {
-                $property = new \ReflectionProperty(get_class($set), 'maxScore');
+                $setClass = get_class($set);
+                self::assertIsString($setClass);
+                $property = new \ReflectionProperty($setClass, 'maxScore');
                 $property->setAccessible(true);
                 $property->setValue($set, 0.0);
 
                 foreach ($set->searchHits as $hit) {
-                    $property = new \ReflectionProperty(get_class($hit), 'score');
+                    $hitClass = get_class($hit);
+                    self::assertIsString($hitClass);
+                    $property = new \ReflectionProperty($hitClass, 'score');
                     $property->setAccessible(true);
                     $property->setValue($hit, 0.0);
                 }
@@ -4802,19 +4789,17 @@ protected function assertQueryFixture(
 
         foreach ([$fixture, $result] as $set) {
             foreach ($set->searchHits as $hit) {
-                $property = new \ReflectionProperty(get_class($hit), 'index');
+                $hitClass = get_class($hit);
+                self::assertIsString($hitClass);
+                $property = new \ReflectionProperty($hitClass, 'index');
                 $property->setAccessible(true);
                 $property->setValue($hit, null);
 
-                $property = new \ReflectionProperty(get_class($hit), 'matchedTranslation');
+                $property = new \ReflectionProperty($hitClass, 'matchedTranslation');
                 $property->setAccessible(true);
                 $property->setValue($hit, null);
 
                 if (!$id) {
-                    if (!is_array($hit->valueObject)) {
-                        throw new \RuntimeException('Expected simplified search hit value objects to be arrays.');
-                    }
-
                     $hit->valueObject['id'] = null;
                 }
             }
@@ -4839,10 +4824,6 @@ protected function printResult(SearchResult $result)
     {
         $printed = '';
         foreach ($result->searchHits as $hit) {
-            if (!is_array($hit->valueObject)) {
-                throw new \RuntimeException('Expected simplified search hit value objects to be arrays.');
-            }
-
             $printed .= sprintf(" - %s (%s)\n", $hit->valueObject['title'], $hit->valueObject['id']);
         }