IBX-10507: Allowed nullable type declarations for method parameters across the codebase (#154)

Co-authored-by: MateuszKolankowski <wiewiurdp@tlen. pl>

Author: wiewiurdp

src/lib/API/Context/UserContext.php

@@ -42,7 +42,7 @@ public function createUseGroup(string $userGroupName): void
      * @Given I create a user :userName with last name :userLastName with email :userEmail
      * @Given I create a user :userName with last name :userLastName in group :userGroupName with email :userEmail
      */
-    public function createUserInGroupWithEmail(string $userName, string $userLastName, string $userGroupName = null, string $userEmail = null): void
+    public function createUserInGroupWithEmail(string $userName, string $userLastName, ?string $userGroupName = null, ?string $userEmail = null): void
     {
         $this->userFacade->createUser($userName, $userLastName, $userGroupName, $userEmail);
     }
@@ -81,7 +81,7 @@ public function assignUserGroupToRoleIfPossible(string $userGroupName, string $r
      * @Given I assign user group :groupName to role :roleName
      * @Given I assign user group :groupName to role :roleName with limitations:
      */
-    public function assignUserGroupToRole(string $userGroupName, string $roleName, TableNode $limitationData = null): void
+    public function assignUserGroupToRole(string $userGroupName, string $roleName, ?TableNode $limitationData = null): void
     {
         $parsedLimitations = null === $limitationData ? null : $this->argumentParser->parseLimitations($limitationData);
 

src/lib/Browser/Context/AuthenticationContext.php

@@ -31,7 +31,7 @@ public function __construct(LoginPage $loginPage, RedirectLoginPage $redirectLog
      * @Given I log in as :username
      * @Given I log in as :username with password :password
      */
-    public function iLogInIn(string $username, string $password = null)
+    public function iLogInIn(string $username, ?string $password = null)
     {
         $password = $password ?? PasswordProvider::DEFAUlT_PASSWORD;
         $this->loginPage->loginSuccessfully($username, $password);
@@ -59,7 +59,7 @@ public function loggedAsAdmin()
      * @Given I am viewing the pages on siteaccess :siteaccess as :username :password
      * @Given I am viewing the pages on siteaccess :siteaccess as :username with password :password
      */
-    public function iAmViewingThePagesAsUserOnSiteaccess(string $siteaccess, string $username, string $password = null)
+    public function iAmViewingThePagesAsUserOnSiteaccess(string $siteaccess, string $username, ?string $password = null)
     {
         $this->loginPage->open($siteaccess);
         $this->loginPage->logout($siteaccess);

src/lib/Core/Context/ConfigurationContext.php

@@ -64,7 +64,7 @@ public function iAddSiteaccessWithSettings($siteaccessName, $siteaccessGroup, Ta
      *
      * @param mixed $siteaccessName
      */
-    public function iAppendOrSetConfigurationToSiteaccess(string $mode, $siteaccessName, TableNode $settings, string $configFilePath = null)
+    public function iAppendOrSetConfigurationToSiteaccess(string $mode, $siteaccessName, TableNode $settings, ?string $configFilePath = null)
     {
         $appendToExisting = $this->shouldAppendValue($mode);
 
@@ -92,7 +92,7 @@ public function iAppendOrSetConfigurationToSiteaccess(string $mode, $siteaccessN
      *
      * @param mixed $parentNode
      */
-    public function iModifyConfigurationUnderKey(string $mode, $parentNode, PyStringNode $configFragment, string $configFilePath = null)
+    public function iModifyConfigurationUnderKey(string $mode, $parentNode, PyStringNode $configFragment, ?string $configFilePath = null)
     {
         $appendToExisting = $this->shouldAppendValue($mode);
 
@@ -160,7 +160,7 @@ private function shouldAppendValue(string $value): bool
      * @Given I copy the configuration from :keyName to :newKeyName
      * @Given I copy the configuration from :keyName to :newKeyName in :configFilePath
      */
-    public function iCopyTheConfigurationFromTo(string $keyName, string $newKeyName, string $configFilePath = null)
+    public function iCopyTheConfigurationFromTo(string $keyName, string $newKeyName, ?string $configFilePath = null)
     {
         $configFilePath = $configFilePath ? sprintf('%s/%s', $this->projectDir, $configFilePath) : $this->mainProjectConfigFilePath;
         $config = $this->configurationEditor->getConfigFromFile($configFilePath);

tests/bundle/Form/Stub/UnstableChoiceListFactory.php

@@ -30,23 +30,23 @@ public function __construct(int $successfulCallAfterNthTry)
         $this->successfulCallAfterNthTry = $successfulCallAfterNthTry;
     }
 
-    public function createListFromChoices(iterable $choices, callable $value = null)
+    public function createListFromChoices(iterable $choices, ?callable $value = null)
     {
         ++$this->createListFromChoicesCounter;
         $this->failIfNeeded($this->createListFromChoicesCounter);
 
         return new ArrayChoiceList([]);
     }
 
-    public function createListFromLoader(ChoiceLoaderInterface $loader, callable $value = null)
+    public function createListFromLoader(ChoiceLoaderInterface $loader, ?callable $value = null)
     {
         ++$this->createListFromLoaderCounter;
         $this->failIfNeeded($this->createListFromLoaderCounter);
 
         return new ArrayChoiceList([]);
     }
 
-    public function createView(ChoiceListInterface $list, $preferredChoices = null, $label = null, callable $index = null, callable $groupBy = null, $attr = null)
+    public function createView(ChoiceListInterface $list, $preferredChoices = null, $label = null, ?callable $index = null, ?callable $groupBy = null, $attr = null)
     {
         ++$this->createViewCounter;
         $this->failIfNeeded($this->createViewCounter);