Skip to content

Commit e601899

Browse files
committed
[Tests] Fixed incorrect usage of assertNull on void results in SetViewParametersListenerTest
1 parent 8af48a0 commit e601899

File tree

1 file changed

+7
-9
lines changed

1 file changed

+7
-9
lines changed

tests/lib/EventListener/SetViewParametersListenerTest.php

Lines changed: 7 additions & 9 deletions
Original file line numberDiff line numberDiff line change
@@ -13,6 +13,7 @@
1313
use Ibexa\ContentForms\User\View\UserUpdateView;
1414
use Ibexa\Contracts\ContentForms\Content\Form\Provider\GroupedContentFormFieldsProviderInterface;
1515
use Ibexa\Contracts\ContentForms\Data\Content\FieldData;
16+
use Ibexa\Contracts\Core\Repository\Exceptions\Exception;
1617
use Ibexa\Contracts\Core\Repository\LocationService;
1718
use Ibexa\Contracts\Core\Repository\Repository;
1819
use Ibexa\Contracts\Core\Repository\UserService;
@@ -183,18 +184,17 @@ public function testSetViewTemplateParametersWithMainLocationId(): void
183184
self::assertSame(reset($parentLocations), $contentView->getParameter('parent_location'));
184185
}
185186

187+
/**
188+
* @throws Exception
189+
*/
186190
public function testSetViewTemplateParametersWithoutContentEditViewInstance(): void
187191
{
188192
$contentView = $this->createMock(View::class);
189193

190194
$this->locationService->expects(self::never())
191195
->method('loadParentLocationsForDraftContent');
192196

193-
self::assertNull(
194-
$this->viewParametersListener->setContentEditViewTemplateParameters(
195-
new PreContentViewEvent($contentView)
196-
)
197-
);
197+
$this->viewParametersListener->setContentEditViewTemplateParameters(new PreContentViewEvent($contentView));
198198
}
199199

200200
public function testSetUserUpdateViewTemplateParametersWithoutUserUpdateViewInstance(): void
@@ -204,10 +204,8 @@ public function testSetUserUpdateViewTemplateParametersWithoutUserUpdateViewInst
204204
$this->locationService->expects(self::never())
205205
->method('loadParentLocationsForDraftContent');
206206

207-
self::assertNull(
208-
$this->viewParametersListener->setUserUpdateViewTemplateParameters(
209-
new PreContentViewEvent($view)
210-
)
207+
$this->viewParametersListener->setUserUpdateViewTemplateParameters(
208+
new PreContentViewEvent($view)
211209
);
212210
}
213211

0 commit comments

Comments
 (0)