Skip to content

Commit 0c47993

Browse files
Steveb-pSteveb-p
authored
Added PHPStan for 4.5 version
1 parent d5af11c commit 0c47993

File tree

8 files changed

+14054
-1
lines changed

8 files changed

+14054
-1
lines changed

‎.github/workflows/ci.yaml‎

Lines changed: 3 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -67,3 +67,6 @@ jobs:
6767

6868
- name: Run test suite
6969
run: composer run-script --timeout=600 test
70+
71+
- name: Run PHPStan analysis
72+
run: composer run-script phpstan

‎composer.json‎

Lines changed: 5 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -70,7 +70,10 @@
7070
"matthiasnoback/symfony-dependency-injection-test": "^4.0",
7171
"ibexa/doctrine-schema": "~4.5.0@dev",
7272
"ibexa/http-cache": "~4.5.0@dev",
73-
"ibexa/code-style": "^1.0"
73+
"ibexa/code-style": "^1.0",
74+
"phpstan/phpstan": "^1.10",
75+
"phpstan/phpstan-phpunit": "^1.3",
76+
"phpstan/phpstan-symfony": "^1.3"
7477
},
7578
"config": {
7679
"allow-plugins": {
@@ -80,6 +83,7 @@
8083
"scripts": {
8184
"fix-cs": "php-cs-fixer fix --config=.php-cs-fixer.php -v --show-progress=dots",
8285
"check-cs": "@fix-cs --dry-run",
86+
"phpstan": "phpstan analyse",
8387
"test": "phpunit -c phpunit.xml"
8488
},
8589
"extra": {

‎phpstan-baseline-7.4.neon‎

Lines changed: 281 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,281 @@
1+
parameters:
2+
ignoreErrors:
3+
-
4+
message: "#^Method Ibexa\\\\Bundle\\\\AdminUi\\\\Controller\\\\BookmarkController\\:\\:getChoices\\(\\) should return array but returns array\\<false\\>\\|false\\.$#"
5+
count: 1
6+
path: src/bundle/Controller/BookmarkController.php
7+
8+
-
9+
message: "#^Parameter \\#2 \\$search of function array_key_exists expects array, iterable\\<Ibexa\\\\Contracts\\\\Core\\\\Repository\\\\Values\\\\Content\\\\Location\\> given\\.$#"
10+
count: 1
11+
path: src/bundle/Controller/Content/ContentTreeController.php
12+
13+
-
14+
message: "#^Parameter \\#1 \\$stack of function array_shift expects array, iterable\\<Ibexa\\\\Contracts\\\\Core\\\\Repository\\\\Values\\\\Content\\\\Location\\> given\\.$#"
15+
count: 1
16+
path: src/bundle/Controller/Content/VersionDraftConflictController.php
17+
18+
-
19+
message: "#^Parameter \\#1 \\$input of function array_keys expects array, array\\|null given\\.$#"
20+
count: 1
21+
path: src/bundle/Controller/ContentDraftController.php
22+
23+
-
24+
message: "#^Parameter \\#1 \\$versions of class Ibexa\\\\AdminUi\\\\Form\\\\Data\\\\Content\\\\Draft\\\\ContentRemoveData constructor expects array\\|null, array\\<mixed, false\\>\\|false given\\.$#"
25+
count: 1
26+
path: src/bundle/Controller/ContentDraftController.php
27+
28+
-
29+
message: "#^Method Ibexa\\\\Bundle\\\\AdminUi\\\\Controller\\\\ContentTypeController\\:\\:getContentTypesNumbers\\(\\) should return array but returns array\\<false\\>\\|false\\.$#"
30+
count: 1
31+
path: src/bundle/Controller/ContentTypeController.php
32+
33+
-
34+
message: "#^Parameter \\#1 \\$array_arg of function usort expects TArray of array\\<Ibexa\\\\Contracts\\\\Core\\\\Repository\\\\Values\\\\ContentType\\\\ContentType\\>, iterable\\<Ibexa\\\\Contracts\\\\Core\\\\Repository\\\\Values\\\\ContentType\\\\ContentType\\> given\\.$#"
35+
count: 1
36+
path: src/bundle/Controller/ContentTypeController.php
37+
38+
-
39+
message: "#^Parameter \\#1 \\$s1 of function strnatcasecmp expects string, string\\|null given\\.$#"
40+
count: 1
41+
path: src/bundle/Controller/ContentTypeController.php
42+
43+
-
44+
message: "#^Parameter \\#2 \\$s2 of function strnatcasecmp expects string, string\\|null given\\.$#"
45+
count: 1
46+
path: src/bundle/Controller/ContentTypeController.php
47+
48+
-
49+
message: "#^Method Ibexa\\\\Bundle\\\\AdminUi\\\\Controller\\\\ContentTypeGroupController\\:\\:getContentTypeGroupsNumbers\\(\\) should return array but returns array\\<false\\>\\|false\\.$#"
50+
count: 1
51+
path: src/bundle/Controller/ContentTypeGroupController.php
52+
53+
-
54+
message: "#^Parameter \\#1 \\$var of function count expects array\\|Countable, iterable\\<Ibexa\\\\Contracts\\\\Core\\\\Repository\\\\Values\\\\ContentType\\\\ContentType\\> given\\.$#"
55+
count: 1
56+
path: src/bundle/Controller/ContentTypeGroupController.php
57+
58+
-
59+
message: "#^Parameter \\#1 \\$stack of function array_shift expects array, iterable\\<Ibexa\\\\Contracts\\\\Core\\\\Repository\\\\Values\\\\Content\\\\Language\\> given\\.$#"
60+
count: 1
61+
path: src/bundle/Controller/ContentViewController.php
62+
63+
-
64+
message: "#^Parameter \\#1 \\$var of function count expects array\\|Countable, iterable\\<Ibexa\\\\Contracts\\\\Core\\\\Repository\\\\Values\\\\Content\\\\Language\\> given\\.$#"
65+
count: 1
66+
path: src/bundle/Controller/ContentViewController.php
67+
68+
-
69+
message: "#^Method Ibexa\\\\Bundle\\\\AdminUi\\\\Controller\\\\LanguageController\\:\\:getLanguagesNumbers\\(\\) should return array but returns array\\<false\\>\\|false\\.$#"
70+
count: 1
71+
path: src/bundle/Controller/LanguageController.php
72+
73+
-
74+
message: "#^Method Ibexa\\\\Bundle\\\\AdminUi\\\\Controller\\\\ObjectStateController\\:\\:getObjectStatesIds\\(\\) should return array but returns array\\<false\\>\\|false\\.$#"
75+
count: 1
76+
path: src/bundle/Controller/ObjectStateController.php
77+
78+
-
79+
message: "#^Method Ibexa\\\\Bundle\\\\AdminUi\\\\Controller\\\\ObjectStateGroupController\\:\\:getObjectStateGroupsIds\\(\\) should return array but returns array\\<false\\>\\|false\\.$#"
80+
count: 1
81+
path: src/bundle/Controller/ObjectStateGroupController.php
82+
83+
-
84+
message: "#^Method Ibexa\\\\Bundle\\\\AdminUi\\\\Controller\\\\PolicyController\\:\\:getPoliciesNumbers\\(\\) should return array but returns array\\<false\\>\\|false\\.$#"
85+
count: 1
86+
path: src/bundle/Controller/PolicyController.php
87+
88+
-
89+
message: "#^Method Ibexa\\\\Bundle\\\\AdminUi\\\\Controller\\\\RoleAssignmentController\\:\\:getRoleAssignmentsNumbers\\(\\) should return array but returns array\\<int, false\\>\\|false\\.$#"
90+
count: 1
91+
path: src/bundle/Controller/RoleAssignmentController.php
92+
93+
-
94+
message: "#^Parameter \\#1 \\$roles of class Ibexa\\\\AdminUi\\\\Form\\\\Data\\\\Role\\\\RolesDeleteData constructor expects array, array\\<false\\>\\|false given\\.$#"
95+
count: 1
96+
path: src/bundle/Controller/RoleController.php
97+
98+
-
99+
message: "#^Method Ibexa\\\\Bundle\\\\AdminUi\\\\Controller\\\\SectionController\\:\\:getSectionsNumbers\\(\\) should return array but returns array\\<false\\>\\|false\\.$#"
100+
count: 1
101+
path: src/bundle/Controller/SectionController.php
102+
103+
-
104+
message: "#^Parameter \\#2 \\$pieces of function implode expects array, array\\<int, string\\>\\|false given\\.$#"
105+
count: 1
106+
path: src/bundle/Templating/Twig/UniversalDiscoveryExtension.php
107+
108+
-
109+
message: "#^Parameter \\#1 \\$obj of function date_format expects DateTimeInterface, DateTime\\|false given\\.$#"
110+
count: 4
111+
path: src/lib/Behat/Component/Fields/DateAndTime.php
112+
113+
-
114+
message: "#^Parameter \\#1 \\$obj of function date_format expects DateTimeInterface, DateTime\\|false given\\.$#"
115+
count: 4
116+
path: src/lib/Behat/Component/Fields/Time.php
117+
118+
-
119+
message: "#^Parameter \\#2 \\$start of function substr expects int, int\\<0, max\\>\\|false given\\.$#"
120+
count: 1
121+
path: src/lib/Behat/Page/RolePage.php
122+
123+
-
124+
message: "#^Parameter \\#1 \\$input of function array_filter expects array, iterable\\<Ibexa\\\\Contracts\\\\Core\\\\Repository\\\\Values\\\\Content\\\\Field\\> given\\.$#"
125+
count: 1
126+
path: src/lib/EventListener/ContentProxyCreateDraftListener.php
127+
128+
-
129+
message: "#^Parameter \\#1 \\$arr1 of function array_merge expects array, array\\|null given\\.$#"
130+
count: 1
131+
path: src/lib/Form/DataTransformer/FieldType/BinaryFileValueTransformer.php
132+
133+
-
134+
message: "#^Parameter \\#1 \\$arr1 of function array_merge expects array, array\\|null given\\.$#"
135+
count: 1
136+
path: src/lib/Form/DataTransformer/FieldType/ImageAssetValueTransformer.php
137+
138+
-
139+
message: "#^Parameter \\#1 \\$arr1 of function array_merge expects array, array\\|null given\\.$#"
140+
count: 1
141+
path: src/lib/Form/DataTransformer/FieldType/ImageValueTransformer.php
142+
143+
-
144+
message: "#^Parameter \\#1 \\$arr1 of function array_merge expects array, array\\|null given\\.$#"
145+
count: 1
146+
path: src/lib/Form/DataTransformer/FieldType/MediaValueTransformer.php
147+
148+
-
149+
message: "#^Parameter \\#1 \\$input of function array_filter expects array, iterable\\<Ibexa\\\\Contracts\\\\Core\\\\Repository\\\\Values\\\\Content\\\\Language\\> given\\.$#"
150+
count: 1
151+
path: src/lib/Form/EventListener/AddLanguageFieldBasedOnContentListener.php
152+
153+
-
154+
message: "#^Parameter \\#2 \\$pieces of function implode expects array, array\\|null given\\.$#"
155+
count: 2
156+
path: src/lib/Form/Factory/FormFactory.php
157+
158+
-
159+
message: "#^Parameter \\#1 \\$input of function array_filter expects array, iterable\\<Ibexa\\\\Contracts\\\\Core\\\\Repository\\\\Values\\\\Content\\\\Language\\> given\\.$#"
160+
count: 1
161+
path: src/lib/Form/Type/ChoiceList/Loader/AvailableTranslationLanguageChoiceLoader.php
162+
163+
-
164+
message: "#^Parameter \\#1 \\$input of function array_filter expects array, iterable\\<Ibexa\\\\Contracts\\\\Core\\\\Repository\\\\Values\\\\Content\\\\Language\\> given\\.$#"
165+
count: 1
166+
path: src/lib/Form/Type/ChoiceList/Loader/BaseTranslationLanguageChoiceLoader.php
167+
168+
-
169+
message: "#^Parameter \\#1 \\$input of function array_filter expects array, iterable\\<Ibexa\\\\Contracts\\\\Core\\\\Repository\\\\Values\\\\Content\\\\Language\\> given\\.$#"
170+
count: 2
171+
path: src/lib/Form/Type/ChoiceList/Loader/ContentEditTranslationChoiceLoader.php
172+
173+
-
174+
message: "#^Parameter \\#1 \\$array_arg of function usort expects TArray of array\\<Ibexa\\\\Contracts\\\\Core\\\\Repository\\\\Values\\\\ContentType\\\\ContentType\\>, iterable\\<Ibexa\\\\Contracts\\\\Core\\\\Repository\\\\Values\\\\ContentType\\\\ContentType\\> given\\.$#"
175+
count: 1
176+
path: src/lib/Form/Type/ChoiceList/Loader/ContentTypeChoiceLoader.php
177+
178+
-
179+
message: "#^Parameter \\#1 \\$s1 of function strnatcasecmp expects string, string\\|null given\\.$#"
180+
count: 1
181+
path: src/lib/Form/Type/ChoiceList/Loader/ContentTypeChoiceLoader.php
182+
183+
-
184+
message: "#^Parameter \\#2 \\$s2 of function strnatcasecmp expects string, string\\|null given\\.$#"
185+
count: 1
186+
path: src/lib/Form/Type/ChoiceList/Loader/ContentTypeChoiceLoader.php
187+
188+
-
189+
message: "#^Parameter \\#1 \\$input of function array_filter expects array, iterable\\<Ibexa\\\\Contracts\\\\Core\\\\Repository\\\\Values\\\\Content\\\\Language\\> given\\.$#"
190+
count: 1
191+
path: src/lib/Form/Type/Content/Translation/TranslationAddType.php
192+
193+
-
194+
message: "#^Parameter \\#1 \\$input of function array_filter expects array, iterable\\<Ibexa\\\\Contracts\\\\Core\\\\Repository\\\\Values\\\\Content\\\\Language\\> given\\.$#"
195+
count: 1
196+
path: src/lib/Form/Type/ContentType/Translation/TranslationAddType.php
197+
198+
-
199+
message: "#^Parameter \\#1 \\$str of function strtolower expects string, string\\|null given\\.$#"
200+
count: 1
201+
path: src/lib/Form/Type/FieldDefinition/User/PasswordConstraintCheckboxType.php
202+
203+
-
204+
message: "#^Parameter \\#1 \\$input of function array_filter expects array, iterable\\<Ibexa\\\\Contracts\\\\Core\\\\Repository\\\\Values\\\\ObjectState\\\\ObjectState\\> given\\.$#"
205+
count: 1
206+
path: src/lib/Form/Type/ObjectState/ContentObjectStateUpdateType.php
207+
208+
-
209+
message: "#^Parameter \\#1 \\$input of function array_filter expects array, iterable\\<Ibexa\\\\Contracts\\\\Core\\\\Repository\\\\Values\\\\Content\\\\Language\\> given\\.$#"
210+
count: 1
211+
path: src/lib/Pagination/Mapper/AbstractPagerContentToDataMapper.php
212+
213+
-
214+
message: "#^Parameter \\#1 \\$input of function array_filter expects array, iterable\\<Ibexa\\\\Contracts\\\\Core\\\\Repository\\\\Values\\\\Content\\\\Language\\> given\\.$#"
215+
count: 1
216+
path: src/lib/Permission/PermissionChecker.php
217+
218+
-
219+
message: "#^Parameter \\#1 \\$var of function count expects array\\|Countable, iterable\\<Ibexa\\\\Contracts\\\\Core\\\\Repository\\\\Values\\\\User\\\\UserGroup\\> given\\.$#"
220+
count: 1
221+
path: src/lib/Permission/PermissionChecker.php
222+
223+
-
224+
message: "#^Parameter \\#1 \\$input of function array_filter expects array, iterable\\<Ibexa\\\\Contracts\\\\Core\\\\Repository\\\\Values\\\\Content\\\\Language\\> given\\.$#"
225+
count: 1
226+
path: src/lib/Tab/Dashboard/PagerLocationToDataMapper.php
227+
228+
-
229+
message: "#^Parameter \\#1 \\$input of function array_filter expects array, iterable\\<Ibexa\\\\Contracts\\\\Core\\\\Repository\\\\Values\\\\Content\\\\Language\\> given\\.$#"
230+
count: 1
231+
path: src/lib/Tab/LocationView/ContentTab.php
232+
233+
-
234+
message: "#^Method Ibexa\\\\AdminUi\\\\Tab\\\\LocationView\\\\LocationsTab\\:\\:getLocationChoices\\(\\) should return array but returns array\\<int, false\\>\\|false\\.$#"
235+
count: 1
236+
path: src/lib/Tab/LocationView/LocationsTab.php
237+
238+
-
239+
message: "#^Parameter \\#2 \\$languageCodes of class Ibexa\\\\AdminUi\\\\Form\\\\Data\\\\Content\\\\Translation\\\\TranslationDeleteData constructor expects array, array\\<false\\>\\|false given\\.$#"
240+
count: 1
241+
path: src/lib/Tab/LocationView/TranslationsTab.php
242+
243+
-
244+
message: "#^Method Ibexa\\\\AdminUi\\\\Tab\\\\LocationView\\\\UrlsTab\\:\\:getChoices\\(\\) should return array but returns array\\<false\\>\\|false\\.$#"
245+
count: 1
246+
path: src/lib/Tab/LocationView/UrlsTab.php
247+
248+
-
249+
message: "#^Method Ibexa\\\\AdminUi\\\\Tab\\\\LocationView\\\\VersionsTab\\:\\:getVersionNumbers\\(\\) should return array but returns array\\<int, false\\>\\|false\\.$#"
250+
count: 1
251+
path: src/lib/Tab/LocationView/VersionsTab.php
252+
253+
-
254+
message: "#^Parameter \\#1 \\$str of function strtolower expects string, string\\|null given\\.$#"
255+
count: 1
256+
path: src/lib/Translation/Extractor/PolicyTranslationExtractor.php
257+
258+
-
259+
message: "#^Parameter \\#1 \\$array_arg of function usort expects TArray of array\\<Ibexa\\\\Contracts\\\\Core\\\\Repository\\\\Values\\\\ContentType\\\\ContentType\\>, iterable\\<Ibexa\\\\Contracts\\\\Core\\\\Repository\\\\Values\\\\ContentType\\\\ContentType\\> given\\.$#"
260+
count: 1
261+
path: src/lib/UI/Config/Provider/ContentTypes.php
262+
263+
-
264+
message: "#^Parameter \\#1 \\$s1 of function strnatcasecmp expects string, string\\|null given\\.$#"
265+
count: 1
266+
path: src/lib/UI/Config/Provider/ContentTypes.php
267+
268+
-
269+
message: "#^Parameter \\#2 \\$s2 of function strnatcasecmp expects string, string\\|null given\\.$#"
270+
count: 1
271+
path: src/lib/UI/Config/Provider/ContentTypes.php
272+
273+
-
274+
message: "#^Parameter \\#1 \\$input of function array_filter expects array, iterable\\<Ibexa\\\\Contracts\\\\Core\\\\Repository\\\\Values\\\\Content\\\\VersionInfo\\> given\\.$#"
275+
count: 1
276+
path: src/lib/UI/Dataset/ContentDraftsDataset.php
277+
278+
-
279+
message: "#^Parameter \\#2 \\$size of function array_chunk expects int\\<1, max\\>, int given\\.$#"
280+
count: 1
281+
path: src/lib/UI/Module/ContentTree/NodeFactory.php

0 commit comments

Comments
 (0)