-
Notifications
You must be signed in to change notification settings - Fork 205
Open
Description
Hi!
I've been using exifread
for the last couple months and started reading the source code to understand how it works under the hood. I quickly noticed that there's a validation line in exifread.utils.get_gps_coords(...)
that seems to be off:
Line 64 in d60f18d
gps_tags = [lng_ref_tag_name, lng_tag_name, lat_tag_name, lat_tag_name] |
I might be mistaken / speaking out of place, but I think the line should be changed to:
gps_tags = [lng_ref_tag_name, lng_tag_name, lat_ref_tag_name, lat_tag_name]
That way, we ensure that even if one of the metadata fields is missing, we return an empty tuple (or maybe raise an exception?).
Huge props to all contributors, by the way! This library is super helpful, and I imagine keeping track of all the little tidbits that went into parsing data from a fairly complex standard is super hard. I appreciate it immensely.
Metadata
Metadata
Assignees
Labels
No labels